Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

2016-08-10 Thread Al Viro
On Wed, Aug 10, 2016 at 02:46:27PM -0400, Josef Bacik wrote: > On 08/10/2016 02:25 PM, Linus Torvalds wrote: > > On Wed, Aug 10, 2016 at 11:22 AM, Josef Bacik wrote: > > > On 08/10/2016 02:06 PM, Linus Torvalds wrote: > > > > > > > > More information in the original email on lkml.

Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

2016-08-10 Thread Linus Torvalds
On Tue, Aug 9, 2016 at 10:39 PM, kernel test robot wrote: > > [ 1537.558739] nfsd: last server has exited, flushing export cache > [ 1540.627795] BUG: Dentry 880027d7c540{i=1846f,n=0a} still in use (1) > [unmount of btrfs vda] > [ 1540.633915] [ cut here

Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

2016-08-10 Thread Linus Torvalds
On Wed, Aug 10, 2016 at 11:22 AM, Josef Bacik wrote: > On 08/10/2016 02:06 PM, Linus Torvalds wrote: >> >> More information in the original email on lkml. > > I'm not subscribed to lkml and for some reason I can't find the original > email in any of the lkml/linux-nfs archives.

Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

2016-08-10 Thread Josef Bacik
On 08/10/2016 02:06 PM, Linus Torvalds wrote: On Tue, Aug 9, 2016 at 10:39 PM, kernel test robot wrote: [ 1537.558739] nfsd: last server has exited, flushing export cache [ 1540.627795] BUG: Dentry 880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

2016-08-10 Thread Linus Torvalds
On Wed, Aug 10, 2016 at 11:46 AM, Josef Bacik wrote: > > So my naive fix would be something like this Bruce? Josef's patch looks ObviouslyCorrect(tm) to me now that I look at it - all the other callers of fh_compose() also seem to just drop the dentry unconditionally, knowing that

Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

2016-08-10 Thread Linus Torvalds
On Wed, Aug 10, 2016 at 12:09 PM, J. Bruce Fields wrote: > > OK with me if you want to take it, otherwise I'll run it through my > usual tests and send you a pull request probably today or tomorrow. I'll let it go through your tree and your usual tests - it's not like this

Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

2016-08-10 Thread Jeff Layton
On Wed, 2016-08-10 at 14:46 -0400, Josef Bacik wrote: > On 08/10/2016 02:25 PM, Linus Torvalds wrote: > > > > > > On Wed, Aug 10, 2016 at 11:22 AM, Josef Bacik wrote: > > > > > > On 08/10/2016 02:06 PM, Linus Torvalds wrote: > > > > > > > > > > > > More information in the

Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

2016-08-10 Thread J. Bruce Fields
On Wed, Aug 10, 2016 at 11:56:15AM -0700, Linus Torvalds wrote: > On Wed, Aug 10, 2016 at 11:46 AM, Josef Bacik wrote: > > > > So my naive fix would be something like this > > Bruce? Josef's patch looks ObviouslyCorrect(tm) to me now that I look > at it - all the other callers of

Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

2016-08-10 Thread Josef Bacik
On 08/10/2016 02:25 PM, Linus Torvalds wrote: On Wed, Aug 10, 2016 at 11:22 AM, Josef Bacik wrote: On 08/10/2016 02:06 PM, Linus Torvalds wrote: More information in the original email on lkml. I'm not subscribed to lkml and for some reason I can't find the original email in

Re: [lkp] [nfsd] b44061d0b9: BUG: Dentry ffff880027d7c540{i=1846f,n=0a} still in use (1) [unmount of btrfs vda]

2016-08-10 Thread Josef Bacik
On 08/10/2016 02:25 PM, Linus Torvalds wrote: On Wed, Aug 10, 2016 at 11:22 AM, Josef Bacik wrote: On 08/10/2016 02:06 PM, Linus Torvalds wrote: More information in the original email on lkml. I'm not subscribed to lkml and for some reason I can't find the original email in