Re: [review] Btrfs: Allow shrinking close to used space

2009-03-01 Thread Chris Ball
Hi, Here's a new patch that incorporates these comments. We now update device->fs_devices->total_rw_bytes before the shrink, as Josef suggests, and create a new field in btrfs_device to store an on-disk size that is only updated on a successful shrink operation, as requested by Yan. (Thanks, Yan

Re: [review] Btrfs: Allow shrinking close to used space

2009-02-25 Thread Yan Zheng
2009/2/26 Josef Bacik : > On Wed, Feb 25, 2009 at 02:13:10PM -0500, Chris Ball wrote: >> Hi, >> >> This patch (against experimental HEAD) attempts to make shrinking more >> robust, by only updating device size if we've succeeded in creating >> enough free space without any failures in btrfs_relocat

Re: [review] Btrfs: Allow shrinking close to used space

2009-02-25 Thread Josef Bacik
On Wed, Feb 25, 2009 at 02:13:10PM -0500, Chris Ball wrote: > Hi, > > This patch (against experimental HEAD) attempts to make shrinking more > robust, by only updating device size if we've succeeded in creating > enough free space without any failures in btrfs_relocate_chunk(). > > Here's a log w

[review] Btrfs: Allow shrinking close to used space

2009-02-25 Thread Chris Ball
Hi, This patch (against experimental HEAD) attempts to make shrinking more robust, by only updating device size if we've succeeded in creating enough free space without any failures in btrfs_relocate_chunk(). Here's a log with my patch applied. The two things to note are that a near-limit shrink