Re: GRUB writing to grubenv outside of kernel fs code

2018-09-19 Thread Austin S. Hemmelgarn
On 2018-09-19 15:08, Goffredo Baroncelli wrote: On 18/09/2018 19.15, Goffredo Baroncelli wrote: b. The bootloader code, would have to have sophisticated enough Btrfs knowledge to know if the grubenv has been reflinked or snapshot, because even if +C, it may not be valid to overwrite, and COW

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-19 Thread Goffredo Baroncelli
On 18/09/2018 19.15, Goffredo Baroncelli wrote: >> b. The bootloader code, would have to have sophisticated enough Btrfs >> knowledge to know if the grubenv has been reflinked or snapshot, >> because even if +C, it may not be valid to overwrite, and COW must >> still happen, and there's no way the

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Andrei Borzenkov
18.09.2018 22:11, Austin S. Hemmelgarn пишет: > On 2018-09-18 14:38, Andrei Borzenkov wrote: >> 18.09.2018 21:25, Austin S. Hemmelgarn пишет: >>> On 2018-09-18 14:16, Andrei Borzenkov wrote: 18.09.2018 08:37, Chris Murphy пишет: > On Mon, Sep 17, 2018 at 11:24 PM, Andrei Borzenkov >

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Duncan
Chris Murphy posted on Tue, 18 Sep 2018 13:34:14 -0600 as excerpted: > I've run into some issue where grub2-mkconfig and grubby, can change the > grub.cfg, and then do a really fast reboot without cleanly unmounting > the volume - and what happens? Can't boot. The bootloader can't do log > replay

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Chris Murphy
On Mon, Sep 17, 2018 at 9:44 PM, Chris Murphy wrote: > https://btrfs.wiki.kernel.org/index.php/FAQ#Does_grub_support_btrfs.3F > > Does anyone know if this is still a problem on Btrfs if grubenv has > xattr +C set? In which case it should be possible to overwrite and > there's no csums that are

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Chris Murphy
On Tue, Sep 18, 2018 at 1:11 PM, Goffredo Baroncelli wrote: >> I think it's a problem, and near as I can tell it'll be a problem for >> all kinds of complex storage. I don't see how the bootloader itself >> can do an overwrite onto raid5 or raid6. > > >> That's certainly supported by GRUB for

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Chris Murphy
On Tue, Sep 18, 2018 at 1:01 PM, Andrei Borzenkov wrote: > 18.09.2018 21:57, Chris Murphy пишет: >> On Tue, Sep 18, 2018 at 12:16 PM, Andrei Borzenkov >> wrote: >>> 18.09.2018 08:37, Chris Murphy пишет: >> The patches aren't upstream yet? Will they be? >>> >>> I do not know.

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Goffredo Baroncelli
On 18/09/2018 20.52, Chris Murphy wrote: > On Tue, Sep 18, 2018 at 11:15 AM, Goffredo Baroncelli > wrote: >> On 18/09/2018 06.21, Chris Murphy wrote: >>> b. The bootloader code, would have to have sophisticated enough Btrfs >>> knowledge to know if the grubenv has been reflinked or snapshot, >>>

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Austin S. Hemmelgarn
On 2018-09-18 15:00, Chris Murphy wrote: On Tue, Sep 18, 2018 at 12:25 PM, Austin S. Hemmelgarn wrote: It actually is independent of /boot already. I've got it running just fine on my laptop off of the EFI system partition (which is independent of my /boot partition), and thus have no issues

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Austin S. Hemmelgarn
On 2018-09-18 14:57, Chris Murphy wrote: On Tue, Sep 18, 2018 at 12:16 PM, Andrei Borzenkov wrote: 18.09.2018 08:37, Chris Murphy пишет: The patches aren't upstream yet? Will they be? I do not know. Personally I think much easier is to make grub location independent of /boot, allowing

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Austin S. Hemmelgarn
On 2018-09-18 14:38, Andrei Borzenkov wrote: 18.09.2018 21:25, Austin S. Hemmelgarn пишет: On 2018-09-18 14:16, Andrei Borzenkov wrote: 18.09.2018 08:37, Chris Murphy пишет: On Mon, Sep 17, 2018 at 11:24 PM, Andrei Borzenkov wrote: 18.09.2018 07:21, Chris Murphy пишет: On Mon, Sep 17, 2018

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Chris Murphy
On Tue, Sep 18, 2018 at 12:25 PM, Austin S. Hemmelgarn wrote: > It actually is independent of /boot already. I've got it running just fine > on my laptop off of the EFI system partition (which is independent of my > /boot partition), and thus have no issues with handling of the grubenv file. >

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Andrei Borzenkov
18.09.2018 21:57, Chris Murphy пишет: > On Tue, Sep 18, 2018 at 12:16 PM, Andrei Borzenkov > wrote: >> 18.09.2018 08:37, Chris Murphy пишет: > >>> The patches aren't upstream yet? Will they be? >>> >> >> I do not know. Personally I think much easier is to make grub location >> independent of

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Chris Murphy
On Tue, Sep 18, 2018 at 12:16 PM, Andrei Borzenkov wrote: > 18.09.2018 08:37, Chris Murphy пишет: >> The patches aren't upstream yet? Will they be? >> > > I do not know. Personally I think much easier is to make grub location > independent of /boot, allowing grub be installed in separate

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Chris Murphy
On Tue, Sep 18, 2018 at 11:15 AM, Goffredo Baroncelli wrote: > On 18/09/2018 06.21, Chris Murphy wrote: >> b. The bootloader code, would have to have sophisticated enough Btrfs >> knowledge to know if the grubenv has been reflinked or snapshot, >> because even if +C, it may not be valid to

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Andrei Borzenkov
18.09.2018 21:25, Austin S. Hemmelgarn пишет: > On 2018-09-18 14:16, Andrei Borzenkov wrote: >> 18.09.2018 08:37, Chris Murphy пишет: >>> On Mon, Sep 17, 2018 at 11:24 PM, Andrei Borzenkov >>> wrote: 18.09.2018 07:21, Chris Murphy пишет: > On Mon, Sep 17, 2018 at 9:44 PM, Chris Murphy

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Austin S. Hemmelgarn
On 2018-09-18 14:16, Andrei Borzenkov wrote: 18.09.2018 08:37, Chris Murphy пишет: On Mon, Sep 17, 2018 at 11:24 PM, Andrei Borzenkov wrote: 18.09.2018 07:21, Chris Murphy пишет: On Mon, Sep 17, 2018 at 9:44 PM, Chris Murphy wrote:

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Andrei Borzenkov
18.09.2018 08:37, Chris Murphy пишет: > On Mon, Sep 17, 2018 at 11:24 PM, Andrei Borzenkov > wrote: >> 18.09.2018 07:21, Chris Murphy пишет: >>> On Mon, Sep 17, 2018 at 9:44 PM, Chris Murphy >>> wrote: https://btrfs.wiki.kernel.org/index.php/FAQ#Does_grub_support_btrfs.3F Does

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-18 Thread Goffredo Baroncelli
On 18/09/2018 06.21, Chris Murphy wrote: > b. The bootloader code, would have to have sophisticated enough Btrfs > knowledge to know if the grubenv has been reflinked or snapshot, > because even if +C, it may not be valid to overwrite, and COW must > still happen, and there's no way the code in

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-17 Thread Chris Murphy
On Mon, Sep 17, 2018 at 11:24 PM, Andrei Borzenkov wrote: > 18.09.2018 07:21, Chris Murphy пишет: >> On Mon, Sep 17, 2018 at 9:44 PM, Chris Murphy >> wrote: >>> https://btrfs.wiki.kernel.org/index.php/FAQ#Does_grub_support_btrfs.3F >>> >>> Does anyone know if this is still a problem on Btrfs if

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-17 Thread Andrei Borzenkov
18.09.2018 07:21, Chris Murphy пишет: > On Mon, Sep 17, 2018 at 9:44 PM, Chris Murphy wrote: >> https://btrfs.wiki.kernel.org/index.php/FAQ#Does_grub_support_btrfs.3F >> >> Does anyone know if this is still a problem on Btrfs if grubenv has >> xattr +C set? In which case it should be possible to

Re: GRUB writing to grubenv outside of kernel fs code

2018-09-17 Thread Chris Murphy
On Mon, Sep 17, 2018 at 9:44 PM, Chris Murphy wrote: > https://btrfs.wiki.kernel.org/index.php/FAQ#Does_grub_support_btrfs.3F > > Does anyone know if this is still a problem on Btrfs if grubenv has > xattr +C set? In which case it should be possible to overwrite and > there's no csums that are

GRUB writing to grubenv outside of kernel fs code

2018-09-17 Thread Chris Murphy
https://btrfs.wiki.kernel.org/index.php/FAQ#Does_grub_support_btrfs.3F Does anyone know if this is still a problem on Btrfs if grubenv has xattr +C set? In which case it should be possible to overwrite and there's no csums that are invalidated. I kinda wonder if in 2018 it's specious for,