Re: I think btrfs: fix leak of path in btrfs_find_item broke stable trees ...

2015-03-27 Thread Eric Sandeen
On 3/26/15 10:34 PM, Eryu Guan wrote: Just FYI. I think generic/204 is a test case issue, _filter_mkfs failed to print isize and dbsize for btrfs and test failed because of divide by zero error. --- /dev/fd/632015-03-25 12:17:05.987107715 -0400 +++ results/generic/204.out.bad

Re: I think btrfs: fix leak of path in btrfs_find_item broke stable trees ...

2015-03-26 Thread Eryu Guan
On Thu, Mar 26, 2015 at 12:11:51PM -0500, Eric Sandeen wrote: On 3/26/15 9:48 AM, Chris Mason wrote: On Thu, Mar 26, 2015 at 10:11 AM, Eric Sandeen sand...@redhat.com wrote: ... 9c4f61f btrfs: simplify insert_orphan_item made the whole path alloc/free go away. so I think

Re: I think btrfs: fix leak of path in btrfs_find_item broke stable trees ...

2015-03-26 Thread Eric Sandeen
On 3/26/15 9:48 AM, Chris Mason wrote: On Thu, Mar 26, 2015 at 10:11 AM, Eric Sandeen sand...@redhat.com wrote: ... 9c4f61f btrfs: simplify insert_orphan_item made the whole path alloc/free go away. so I think there's no need for my patch; may as well just send the above to stable and

Re: I think btrfs: fix leak of path in btrfs_find_item broke stable trees ...

2015-03-26 Thread Filipe David Manana
On Thu, Mar 26, 2015 at 5:11 PM, Eric Sandeen sand...@redhat.com wrote: On 3/26/15 9:48 AM, Chris Mason wrote: On Thu, Mar 26, 2015 at 10:11 AM, Eric Sandeen sand...@redhat.com wrote: ... 9c4f61f btrfs: simplify insert_orphan_item made the whole path alloc/free go away. so I think

Re: I think btrfs: fix leak of path in btrfs_find_item broke stable trees ...

2015-03-26 Thread Eric Sandeen
On 3/26/15 5:23 AM, Filipe David Manana wrote: On Thu, Mar 26, 2015 at 3:24 AM, Eric Sandeen sand...@redhat.com wrote: Looks like btrfs: fix leak of path in btrfs_find_item got sent to stable trees, but in my testing, it causes deadlocks on mount: [23379.359246] mount D

Re: I think btrfs: fix leak of path in btrfs_find_item broke stable trees ...

2015-03-26 Thread Chris Mason
On Thu, Mar 26, 2015 at 10:11 AM, Eric Sandeen sand...@redhat.com wrote: On 3/26/15 5:23 AM, Filipe David Manana wrote: On Thu, Mar 26, 2015 at 3:24 AM, Eric Sandeen sand...@redhat.com wrote: Looks like btrfs: fix leak of path in btrfs_find_item got sent to stable trees, but in my testing,

I think btrfs: fix leak of path in btrfs_find_item broke stable trees ...

2015-03-25 Thread Eric Sandeen
Looks like btrfs: fix leak of path in btrfs_find_item got sent to stable trees, but in my testing, it causes deadlocks on mount: [23379.359246] mount D 0 22541 22274 0x0080 [23379.366326] 8803ebadf6c8 0086 88027ff10230 00013680