Re: [PATCH 04/15] Btrfs: add ref_count and free function for btrfs_bio

2015-01-15 Thread David Sterba
The cleanups look good in general, some minor nitpicks below. On Tue, Jan 13, 2015 at 08:34:37PM +0800, Zhaolei wrote: - kfree(bbio); + put_btrfs_bio(bbio); Please rename it to btrfs_put_bbio, this is more consistent with other *_put_* helpers and 'bbio' distinguishes

RE: [PATCH 04/15] Btrfs: add ref_count and free function for btrfs_bio

2015-01-15 Thread Zhao Lei
Hi, David Sterba * From: David Sterba [mailto:dste...@suse.cz] The cleanups look good in general, some minor nitpicks below. On Tue, Jan 13, 2015 at 08:34:37PM +0800, Zhaolei wrote: - kfree(bbio); + put_btrfs_bio(bbio); Please rename it to btrfs_put_bbio, this is