Re: [PATCH 6/7] btrfs-progs: Add test for super block recovery

2018-01-23 Thread David Sterba
On Tue, Jan 23, 2018 at 05:29:57PM +0200, Nikolay Borisov wrote: > On 23.01.2018 17:07, David Sterba wrote: > > On Tue, Dec 05, 2017 at 12:04:49PM +0200, Nikolay Borisov wrote: > --- /dev/null > +++ b/tests/fsck-tests/029-superblock-recovery/test.sh > @@ -0,0 +1,64 @@ >

Re: [PATCH 6/7] btrfs-progs: Add test for super block recovery

2018-01-23 Thread Nikolay Borisov
On 23.01.2018 17:07, David Sterba wrote: > On Tue, Dec 05, 2017 at 12:04:49PM +0200, Nikolay Borisov wrote: --- /dev/null +++ b/tests/fsck-tests/029-superblock-recovery/test.sh @@ -0,0 +1,64 @@ +#!/bin/bash +# Test that any superblock is correctly detected +# and

Re: [PATCH 6/7] btrfs-progs: Add test for super block recovery

2018-01-23 Thread David Sterba
On Tue, Dec 05, 2017 at 12:04:49PM +0200, Nikolay Borisov wrote: > >> --- /dev/null > >> +++ b/tests/fsck-tests/029-superblock-recovery/test.sh > >> @@ -0,0 +1,64 @@ > >> +#!/bin/bash > >> +# Test that any superblock is correctly detected > >> +# and fixed by btrfs rescue > >> + > >> +source

Re: [PATCH 6/7] btrfs-progs: Add test for super block recovery

2017-12-05 Thread Qu Wenruo
On 2017年12月05日 19:26, Nikolay Borisov wrote: > > > On 5.12.2017 13:12, Qu Wenruo wrote: >> >> >> On 2017年12月05日 18:04, Nikolay Borisov wrote: >>> >>> >>> On 5.12.2017 11:33, Qu Wenruo wrote: On 2017年12月05日 16:39, Nikolay Borisov wrote: > This functionality regressed some

Re: [PATCH 6/7] btrfs-progs: Add test for super block recovery

2017-12-05 Thread Nikolay Borisov
On 5.12.2017 13:12, Qu Wenruo wrote: > > > On 2017年12月05日 18:04, Nikolay Borisov wrote: >> >> >> On 5.12.2017 11:33, Qu Wenruo wrote: >>> >>> >>> On 2017年12月05日 16:39, Nikolay Borisov wrote: This functionality regressed some time ago and it was never caught. Seems no one

Re: [PATCH 6/7] btrfs-progs: Add test for super block recovery

2017-12-05 Thread Qu Wenruo
On 2017年12月05日 18:04, Nikolay Borisov wrote: > > > On 5.12.2017 11:33, Qu Wenruo wrote: >> >> >> On 2017年12月05日 16:39, Nikolay Borisov wrote: >>> This functionality regressed some time ago and it was never caught. Seems no >>> one complained of that, but to be sure add a regression test to

Re: [PATCH 6/7] btrfs-progs: Add test for super block recovery

2017-12-05 Thread Nikolay Borisov
On 5.12.2017 11:33, Qu Wenruo wrote: > > > On 2017年12月05日 16:39, Nikolay Borisov wrote: >> This functionality regressed some time ago and it was never caught. Seems no >> one complained of that, but to be sure add a regression test to prevent >> future >> regressions. >> >> Signed-off-by:

Re: [PATCH 6/7] btrfs-progs: Add test for super block recovery

2017-12-05 Thread Qu Wenruo
On 2017年12月05日 16:39, Nikolay Borisov wrote: > This functionality regressed some time ago and it was never caught. Seems no > one complained of that, but to be sure add a regression test to prevent > future > regressions. > > Signed-off-by: Nikolay Borisov One nitpick for