Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-26 Thread J. Bruce Fields
On Thu, Jun 25, 2015 at 06:12:57PM -0400, Theodore Ts'o wrote: On Thu, Jun 25, 2015 at 02:46:44PM -0400, J. Bruce Fields wrote: Looks OK to me. As I say I'd expect i_version_seen == true to end up being the common case in a lot of v4 workloads, so I'm more skeptical of the claim of a

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-25 Thread J. Bruce Fields
On Tue, Jun 23, 2015 at 12:32:41PM -0400, Theodore Ts'o wrote: On Thu, Jun 18, 2015 at 04:38:56PM +0200, David Sterba wrote: Moving the discussion to fsdevel. Summary: disabling MS_I_VERSION brings some speedups to btrfs, but the generic 'noiversion' option cannot be used to achieve

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-25 Thread Theodore Ts'o
On Thu, Jun 25, 2015 at 02:46:44PM -0400, J. Bruce Fields wrote: Does this sound reasonable? Just to make sure I understand, the logic is something like: to read the i_version: inode-i_version_seen = true; return inode-i_version to update the

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-24 Thread Liu Bo
On Tue, Jun 23, 2015 at 12:32:41PM -0400, Theodore Ts'o wrote: On Thu, Jun 18, 2015 at 04:38:56PM +0200, David Sterba wrote: Moving the discussion to fsdevel. Summary: disabling MS_I_VERSION brings some speedups to btrfs, but the generic 'noiversion' option cannot be used to achieve

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-24 Thread Theodore Ts'o
On Wed, Jun 24, 2015 at 08:02:15PM +0200, David Sterba wrote: This sounds similar to what Dave proposed, a per-inode I_VERSION attribute that can be changed through chattr. Though the negated meaning of the flag could be confusing, I had to reread the paragraph again. Dave did not specify an

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-24 Thread Dave Chinner
On Wed, Jun 24, 2015 at 07:17:50PM -0400, Theodore Ts'o wrote: On Wed, Jun 24, 2015 at 08:02:15PM +0200, David Sterba wrote: This sounds similar to what Dave proposed, a per-inode I_VERSION attribute that can be changed through chattr. Though the negated meaning of the flag could be

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-24 Thread David Sterba
On Tue, Jun 23, 2015 at 12:32:41PM -0400, Theodore Ts'o wrote: This has caused pain for the nfsv4 folks since it means that they need to tell people to use a special mount option for ext4 if they are actually using this for nfsv4, and I suspect they won't be all that eager to hear that btrfs

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-24 Thread David Sterba
On Tue, Jun 23, 2015 at 06:42:15AM +1000, Dave Chinner wrote: On Thu, Jun 18, 2015 at 04:38:56PM +0200, David Sterba wrote: Moving the discussion to fsdevel. Summary: disabling MS_I_VERSION brings some speedups to btrfs, but the generic 'noiversion' option cannot be used to achieve that.

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-23 Thread Theodore Ts'o
On Thu, Jun 18, 2015 at 04:38:56PM +0200, David Sterba wrote: Moving the discussion to fsdevel. Summary: disabling MS_I_VERSION brings some speedups to btrfs, but the generic 'noiversion' option cannot be used to achieve that. It is processed before it reaches btrfs superblock callback,

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-22 Thread Dave Chinner
On Thu, Jun 18, 2015 at 04:38:56PM +0200, David Sterba wrote: Moving the discussion to fsdevel. Summary: disabling MS_I_VERSION brings some speedups to btrfs, but the generic 'noiversion' option cannot be used to achieve that. It is processed before it reaches btrfs superblock callback,

Re: i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-19 Thread Karel Zak
On Thu, Jun 18, 2015 at 04:38:56PM +0200, David Sterba wrote: AFAICS, ext4 had added it's own i_version before iversion was added to mount: It is not so unusual that some mount option is introduced as fs-specific and later re-implemented as generic (another example is MS_LAZYTIME). The mount(8)

i_version vs iversion (Was: Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION)

2015-06-18 Thread David Sterba
Moving the discussion to fsdevel. Summary: disabling MS_I_VERSION brings some speedups to btrfs, but the generic 'noiversion' option cannot be used to achieve that. It is processed before it reaches btrfs superblock callback, where MS_I_VERSION is forced. The proposed fix is to add

Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION

2015-06-17 Thread Liu Bo
On Wed, Jun 17, 2015 at 07:01:18PM +0200, David Sterba wrote: On Wed, Jun 17, 2015 at 11:52:36PM +0800, Liu Bo wrote: On Wed, Jun 17, 2015 at 05:33:06PM +0200, David Sterba wrote: On Wed, Jun 17, 2015 at 03:54:31PM +0800, Liu Bo wrote: MS_I_VERSION is enabled by default for btrfs, this

Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION

2015-06-17 Thread David Sterba
On Wed, Jun 17, 2015 at 03:54:31PM +0800, Liu Bo wrote: MS_I_VERSION is enabled by default for btrfs, this adds an alternative option to toggle it off. There's an existing generic iversion/noiversion mount option pair, no need to extra add it to btrfs. -- To unsubscribe from this list: send the

Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION

2015-06-17 Thread David Sterba
On Wed, Jun 17, 2015 at 11:52:36PM +0800, Liu Bo wrote: On Wed, Jun 17, 2015 at 05:33:06PM +0200, David Sterba wrote: On Wed, Jun 17, 2015 at 03:54:31PM +0800, Liu Bo wrote: MS_I_VERSION is enabled by default for btrfs, this adds an alternative option to toggle it off. There's an

Re: [RFC PATCH v2 1/2] Btrfs: add noi_version option to disable MS_I_VERSION

2015-06-17 Thread Liu Bo
On Wed, Jun 17, 2015 at 05:33:06PM +0200, David Sterba wrote: On Wed, Jun 17, 2015 at 03:54:31PM +0800, Liu Bo wrote: MS_I_VERSION is enabled by default for btrfs, this adds an alternative option to toggle it off. There's an existing generic iversion/noiversion mount option pair, no need