Re: btrfs: check unsupported filters in balance arguments

2015-10-21 Thread Chris Mason
On Thu, Oct 22, 2015 at 12:52:37AM +0200, David Sterba wrote: > On Wed, Oct 21, 2015 at 11:55:00PM +0300, Dan Carpenter wrote: > > Hello David Sterba, > > > > The patch 8eb934591f8b: "btrfs: check unsupported filters in balance > > arguments" from Oct 12

Re: btrfs: check unsupported filters in balance arguments

2015-10-21 Thread David Sterba
On Wed, Oct 21, 2015 at 11:55:00PM +0300, Dan Carpenter wrote: > Hello David Sterba, > > The patch 8eb934591f8b: "btrfs: check unsupported filters in balance > arguments" from Oct 12, 2015, leads to the following static checker > warning: > > fs/btrfs/i

re: btrfs: check unsupported filters in balance arguments

2015-10-21 Thread Dan Carpenter
Hello David Sterba, The patch 8eb934591f8b: "btrfs: check unsupported filters in balance arguments" from Oct 12, 2015, leads to the following static checker warning: fs/btrfs/ioctl.c:4673 btrfs_ioctl_balance() warn: possible memory leak of 'bctl' fs/

[PATCH for 4.3] btrfs: check unsupported filters in balance arguments

2015-10-12 Thread David Sterba
We don't verify that all the balance filter arguments supplemented by the flags are actually known to the kernel. Thus we let it silently pass and do nothing. At the moment this means only the 'limit' filter, but we're going to add a few more soon so it's better to have that fixed. Also in older s