Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-20 Thread Qu Wenruo
On 2017年09月21日 10:49, Misono, Tomohiro wrote: On 2017/09/20 23:21, Qu Wenruo wrote: On 2017年09月20日 22:03, David Sterba wrote: On Wed, Sep 20, 2017 at 08:22:54AM +0800, Qu Wenruo wrote: The costly part will be tracking the filesystems of subvolumes. We must do it for each subvolume and

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-20 Thread Misono, Tomohiro
On 2017/09/20 23:21, Qu Wenruo wrote: > > > On 2017年09月20日 22:03, David Sterba wrote: >> On Wed, Sep 20, 2017 at 08:22:54AM +0800, Qu Wenruo wrote: >>> The costly part will be tracking the filesystems of subvolumes. >>> We must do it for each subvolume and batch them to address the final >>>

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-20 Thread Qu Wenruo
On 2017年09月20日 22:03, David Sterba wrote: On Wed, Sep 20, 2017 at 08:22:54AM +0800, Qu Wenruo wrote: The costly part will be tracking the filesystems of subvolumes. We must do it for each subvolume and batch them to address the final transaction commit for each fs. I didn't see any easy

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-20 Thread David Sterba
On Wed, Sep 20, 2017 at 08:22:54AM +0800, Qu Wenruo wrote: > The costly part will be tracking the filesystems of subvolumes. > We must do it for each subvolume and batch them to address the final > transaction commit for each fs. > > I didn't see any easy ioctl to get the UUID from fd, meaning

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-19 Thread Qu Wenruo
On 2017年09月19日 22:48, David Sterba wrote: On Tue, Sep 19, 2017 at 04:50:04PM +0900, Misono, Tomohiro wrote: I read the code of "subvolume delete" and found that --commit-after option is not working well. Since it issues BTRFS_IOC_START/WAIT_SYNC to the last fd (of directory containing the

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-19 Thread Misono, Tomohiro
On 2017/09/19 23:48, David Sterba wrote: > On Tue, Sep 19, 2017 at 04:50:04PM +0900, Misono, Tomohiro wrote: >> I read the code of "subvolume delete" and found that --commit-after option is >> not working well. >> >> Since it issues BTRFS_IOC_START/WAIT_SYNC to the last fd (of directory >>

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-19 Thread David Sterba
On Tue, Sep 19, 2017 at 04:50:04PM +0900, Misono, Tomohiro wrote: > I read the code of "subvolume delete" and found that --commit-after option is > not working well. > > Since it issues BTRFS_IOC_START/WAIT_SYNC to the last fd (of directory > containing the last deleted subvolume), > 1. sync

Re: btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-19 Thread Qu Wenruo
On 2017年09月19日 15:50, Misono, Tomohiro wrote: Hello, I read the code of "subvolume delete" and found that --commit-after option is not working well. Since it issues BTRFS_IOC_START/WAIT_SYNC to the last fd (of directory containing the last deleted subvolume), 1. sync operation affects only

btrfs-progs: suggestion of removing --commit-after option of subvol delete

2017-09-19 Thread Misono, Tomohiro
Hello, I read the code of "subvolume delete" and found that --commit-after option is not working well. Since it issues BTRFS_IOC_START/WAIT_SYNC to the last fd (of directory containing the last deleted subvolume), 1. sync operation affects only the last fd's filesystem. ("subvolume delete"