Re: [PATCH V2] btrfs: fix possible deadlock by clearing __GFP_FS flag

2011-03-29 Thread Miao Xie
On tue, 29 Mar 2011 14:48:05 +0900, Itaru Kitayama wrote: Hi Miao, On Sun, 27 Mar 2011 20:27:30 +0800 Miao Xie mi...@cn.fujitsu.com wrote: Changelog V1 - V2: - modify the explanation of the deadlock. - clear __GFP_FS flag in the free space's page cache. I think this is also needed on

Re: [PATCH] Btrfs: add initial tracepoint support for btrfs

2011-03-29 Thread liubo
On 03/29/2011 09:16 AM, liubo wrote: On 03/28/2011 08:59 AM, Chris Mason wrote: Excerpts from Chris Mason's message of 2011-03-26 08:12:04 -0400: Excerpts from liubo's message of 2011-03-24 07:18:59 -0400: Tracepoints can provide insight into why btrfs hits bugs and be greatly helpful for

Re: [PATCH] Btrfs: add initial tracepoint support for btrfs

2011-03-29 Thread liubo
Please ignore this patch... I just found we'd better revise the tracepoint side instead of btrfs side, will dig it more. thanks, liubo From: Liu Bo liubo2...@cn.fujitsu.com [PATCH] Btrfs: fix compile warnings of btrfs tracepoint on 32bit box include/trace/events/btrfs.h:47:1: warning:

Re: [GIT PULL] Btrfs updates for 2.6.39

2011-03-29 Thread Chris Mason
Excerpts from David Sterba's message of 2011-03-28 09:25:28 -0400: Hi, Chris, you did not add my sign-of on the unaligned fix I've posted, nor the tested-by or reported-by. Looking again into the mail, it seems like some automated-misprocessing picked the first part of the mail altough

Re: New btrfsck status

2011-03-29 Thread Thomas Backlund
Chris Mason skrev 10.2.2011 14:17: Excerpts from Ben Gamari's message of 2011-02-09 21:52:20 -0500: Hey all, Over the last several months there have been many claims regarding the release of the rewritten btrfsck. Unfortunately, despite numerous claims that it will be released Real Soon

Re: [PATCH 2/2] mutex: Apply adaptive spinning on mutex_trylock()

2011-03-29 Thread Tejun Heo
Hello, guys. I've been running dbench 50 for a few days now and the result is, well, I don't know how to call it. The problem was that the original patch didn't do anything because x86 fastpath code didn't call into the generic slowpath at all. static inline int

Re: [PATCH 2/2] mutex: Apply adaptive spinning on mutex_trylock()

2011-03-29 Thread Tejun Heo
Here's the combined patch I was planning on testing but didn't get to (yet). It implements two things - hard limit on spin duration and early break if the owner also is spinning on a mutex. Thanks. Index: work1/include/linux/sched.h

Re: [PATCH 2/2] mutex: Apply adaptive spinning on mutex_trylock()

2011-03-29 Thread Peter Zijlstra
On Tue, 2011-03-29 at 19:09 +0200, Tejun Heo wrote: Here's the combined patch I was planning on testing but didn't get to (yet). It implements two things - hard limit on spin duration and early break if the owner also is spinning on a mutex. This is going to give massive conflicts with

How to remove a device on a RAID-1 before replacing it?

2011-03-29 Thread Andrew Lutomirski
I have a disk with a SMART failure. It still works but I assume it'll fail sooner or later. I want to remove it from my btrfs volume, replace it, and add the new one. But the obvious command doesn't work: # btrfs device delete /dev/dm-5 /mnt/foo ERROR: error removing the device '/dev/dm-5'

Re: How to remove a device on a RAID-1 before replacing it?

2011-03-29 Thread cwillu
On Tue, Mar 29, 2011 at 2:09 PM, Andrew Lutomirski l...@mit.edu wrote: I have a disk with a SMART failure.  It still works but I assume it'll fail sooner or later. I want to remove it from my btrfs volume, replace it, and add the new one.  But the obvious command doesn't work: # btrfs

Re: How to remove a device on a RAID-1 before replacing it?

2011-03-29 Thread Helmut Hullen
Hallo, cwillu, Du meintest am 29.03.11: I have a disk with a SMART failure.  It still works but I assume it'll fail sooner or later. I want to remove it from my btrfs volume, replace it, and add the new one.  But the obvious command doesn't work: [...] There's no nice way to remove a

Re: How to remove a device on a RAID-1 before replacing it?

2011-03-29 Thread Andrew Lutomirski
On Tue, Mar 29, 2011 at 4:21 PM, cwillu cwi...@cwillu.com wrote: On Tue, Mar 29, 2011 at 2:09 PM, Andrew Lutomirski l...@mit.edu wrote: I have a disk with a SMART failure.  It still works but I assume it'll fail sooner or later. I want to remove it from my btrfs volume, replace it, and add

Re: How to remove a device on a RAID-1 before replacing it?

2011-03-29 Thread Hugo Mills
On Tue, Mar 29, 2011 at 05:01:39PM -0400, Andrew Lutomirski wrote: On Tue, Mar 29, 2011 at 4:21 PM, cwillu cwi...@cwillu.com wrote: On Tue, Mar 29, 2011 at 2:09 PM, Andrew Lutomirski l...@mit.edu wrote: I have a disk with a SMART failure.  It still works but I assume it'll fail sooner or

Re: [PATCH] btrfs: return EXDEV when linking from different subvolumes

2011-03-29 Thread Harik
On Tue, Mar 22, 2011 at 1:20 PM, Mark Fasheh mfas...@suse.com wrote: btrfs_link returns EPERM if a cross-subvolume link is attempted. However, in this case I believe EXDEV to be the more appropriate value. From the link(2) man page: This makes makes sense, that's the behavior link(2) normally

[PATCH] Btrfs: fix compiler warning in file.c

2011-03-29 Thread Tsutomu Itoh
While compiling Btrfs, I got following messages: CC [M] fs/btrfs/file.o fs/btrfs/file.c: In function '__btrfs_buffered_write': fs/btrfs/file.c:909: warning: 'ret' may be used uninitialized in this function CC [M] fs/btrfs/tree-defrag.o This patch fixes compiler warning. Signed-off-by: