[PATCH] btrfs: scrub: errors in tree enumeration

2011-06-03 Thread Arne Jansen
due to the semantics of btrfs_search_slot the path can point to an invalid slot when ret > 0. This condition went unnoticed, which in turn could have led to an incomplete scrubbing. Signed-off-by: Arne Jansen --- fs/btrfs/scrub.c | 21 - 1 files changed, 12 insertions(+), 9

Re: btrfs hang on brd

2011-06-03 Thread Adrian Hunter
On 01/06/11 13:07, Adrian Hunter wrote: On 01/06/11 11:54, David Sterba wrote: On Tue, May 31, 2011 at 10:03:12AM +0300, Adrian Hunter wrote: Hi I seem to be able to get btrfs reproducibly to produce warnings and finally hang when running a stress test on a ramdisk. Testing was done using the

Re: linux-next: build warninga in Linus' tree

2011-06-03 Thread David Sterba
On Wed, Jun 01, 2011 at 10:16:48AM -0500, Mitch Harder wrote: > I've been playing around with resurrecting the basic sysfs > capabilities that had been previously incorporated into btrfs. > > As it stands right now, it was relatively easy to re-implement sysfs > as it was originally. However, tha

Re: linux-next: build warninga in Linus' tree

2011-06-03 Thread Hugo Mills
On Fri, Jun 03, 2011 at 01:10:49PM +0200, David Sterba wrote: > On Wed, Jun 01, 2011 at 10:16:48AM -0500, Mitch Harder wrote: > > I've been playing around with resurrecting the basic sysfs > > capabilities that had been previously incorporated into btrfs. > > > > As it stands right now, it was rel

[PATCH] btrfs: add CONFIG_BTRFS_DEBUG option

2011-06-03 Thread David Sterba
Signed-off-by: David Sterba --- lives in git://repo.or.cz/linux-2.6/btrfs-unstable.git #config-debug-option fs/btrfs/Kconfig | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig index ecb9fd3..5601066 100644 --- a/fs/btrfs/Kconf

[PATCH] btrfs: move extra checks under debug option in btrfs_search_slot

2011-06-03 Thread David Sterba
CC: Josef Bacik Signed-off-by: David Sterba --- this patch is in conflict with josef's patch http://git.kernel.org/?p=linux/kernel/git/josef/btrfs-work.git;a=commit;h=98cdd9ffc5da7aa4c516347f7fc8f65cb08df6ae fs/btrfs/ctree.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --

Re: linux-next: build warninga in Linus' tree

2011-06-03 Thread Sedat Dilek
using gcc v4.5.2 (instead of v4.4.4) if that makes a > difference. I see the same warnings with Debian's gcc-4.6 (here: next-20110603), plus some more: fs/btrfs/ioctl.c: In function 'btrfs_ioctl_fs_info.isra.24': fs/btrfs/ioctl.c:2080:1: warning: the frame size

Re: linux-next: build warninga in Linus' tree

2011-06-03 Thread Greg KH
On Fri, Jun 03, 2011 at 01:10:49PM +0200, David Sterba wrote: > On Wed, Jun 01, 2011 at 10:16:48AM -0500, Mitch Harder wrote: > > I've been playing around with resurrecting the basic sysfs > > capabilities that had been previously incorporated into btrfs. > > > > As it stands right now, it was rel

Re: [PATCH] btrfs: move extra checks under debug option in btrfs_search_slot

2011-06-03 Thread Josef Bacik
On 06/03/2011 08:09 AM, David Sterba wrote: > CC: Josef Bacik > Signed-off-by: David Sterba > --- > Lets use this instead, I'll drop mine. Thanks, Reviewed-by: Josef Bacik -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.ker

[PATCH] btrfs: fix uninitialized variable warning

2011-06-03 Thread David Sterba
From: David Sterba With Linus' tree, today's linux-next build (powercp ppc64_defconfig) produced this warning: fs/btrfs/delayed-inode.c: In function 'btrfs_delayed_update_inode': fs/btrfs/delayed-inode.c:1598:6: warning: 'ret' may be used uninitialized in this function Introduced by commit 16cd

Re: [PATCH] btrfs: fix uninitialized variable warning

2011-06-03 Thread Chris Mason
Excerpts from David Sterba's message of 2011-06-03 10:50:14 -0400: > From: David Sterba > > With Linus' tree, today's linux-next build (powercp ppc64_defconfig) > produced this warning: > > fs/btrfs/delayed-inode.c: In function 'btrfs_delayed_update_inode': > fs/btrfs/delayed-inode.c:1598:6: war

Quota Implementation

2011-06-03 Thread Arne Jansen
Hi, If no one is already working on it, I'd like to take the Quota lock and see how far I come. Let me sketch out in short what I'm planning to do: - Quota will be subvolume based. Only the FS-trees and data extents will be accounted. - Quota Groups can be defined. Every quota group can com

Re: [PATCH][RESEND] btrfs: separate superblock items out of fs_info

2011-06-03 Thread David Sterba
On Thu, Jun 02, 2011 at 09:36:43PM +0300, Sergei Trofimovich wrote: > ... > > @@ -801,6 +800,15 @@ static struct dentry *btrfs_mount(struct > > file_system_type *fs_type, int flags, > > fs_info->fs_devices = fs_devices; > > tree_root->fs_info = fs_info; > > > > + fs_info->super_copy =

Re: Quota Implementation

2011-06-03 Thread Hugo Mills
On Fri, Jun 03, 2011 at 06:24:41PM +0200, Arne Jansen wrote: > Hi, > > If no one is already working on it, I'd like to take the Quota lock and > see how far I come. > Let me sketch out in short what I'm planning to do: > > - Quota will be subvolume based. Only the FS-trees and data extents >

[PATCH] btrfs-progs: Avoid buffer overflow for device name

2011-06-03 Thread Milan Broz
btrfs overwrites memory for too long device paramater try btrfs device scan $(awk 'BEGIN{$5090=OFS="x";print}') ... ** buffer overflow detected ***: btrfs terminated === Backtrace: = /lib64/libc.so.6(__fortify_fail+0x37)[0x7f0ef2ea0607] /lib64/libc.so.6(+0xf6580)[0x7f0ef2e9e580] btrfs

[PATCH] btrfs: Null terminate string in scan device ioctl

2011-06-03 Thread Milan Broz
btrfs_scan_one_device() directly uses vol->name without additional checks so in the case of unterminated string in ioctl it can access memory outside of btrfs_ioctl_vol_args struct. Always terminate name string (as the same as other users do already). Signed-off-by: Milan Broz --- fs/btrfs/supe

Delayed inode operations not doing the right thing with enospc

2011-06-03 Thread Josef Bacik
Hello, I got a lot of these when running stress.sh on my test box [ 9792.654889] [ cut here ] [ 9792.654898] WARNING: at fs/btrfs/extent-tree.c:5681 btrfs_alloc_free_block+0xca/0x27c [btrfs]() [ 9792.654899] Hardware name: To Be Filled By O.E.M. [ 9792.654900] Modules link

Re: Quota Implementation

2011-06-03 Thread Andrey Kuzmin
On Fri, Jun 3, 2011 at 8:47 PM, Hugo Mills wrote: > On Fri, Jun 03, 2011 at 06:24:41PM +0200, Arne Jansen wrote: >> Hi, >> >> If no one is already working on it, I'd like to take the Quota lock and >> see how far I come. >> Let me sketch out in short what I'm planning to do: >> >>  - Quota will be

Re: Quota Implementation

2011-06-03 Thread Johannes Hirte
On Friday 03 June 2011 18:24:41 Arne Jansen wrote: > Hi, > > If no one is already working on it, I'd like to take the Quota lock and > see how far I come. > Let me sketch out in short what I'm planning to do: > > - Quota will be subvolume based. Only the FS-trees and data extents > will be

Re: Announcing btrfs-gui

2011-06-03 Thread Hugo Mills
On Thu, Jun 02, 2011 at 09:41:08AM +0100, Hugo Mills wrote: > On Thu, Jun 02, 2011 at 03:31:16PM +0700, Fajar A. Nugraha wrote: > > On Thu, Jun 2, 2011 at 6:20 AM, Hugo Mills wrote: > > >   Over the last few weeks, I've been playing with a foolish idea, > > > mostly triggered by a cluster of peopl

Fwd: btrfs causing reboots and kernel oops on SL 6 (RHEL 6)

2011-06-03 Thread Joel Pearson
Hi, I'm using SL 6 (RHEL 6) and I've been playing around with running PostgreSQL on btrfs. Snapshotting works ok, but the computer keeps rebooting without warning (can be 5 mins or 1.5 hours), finally I actually managed to get a Kernel Crash instead of just a reboot. I took a picture of the scree

Re: Quota Implementation

2011-06-03 Thread Arne Jansen
On 03.06.2011 23:18, Johannes Hirte wrote: On Friday 03 June 2011 18:24:41 Arne Jansen wrote: Hi, If no one is already working on it, I'd like to take the Quota lock and see how far I come. Let me sketch out in short what I'm planning to do: - Quota will be subvolume based. Only the FS-tree

Re: Quota Implementation

2011-06-03 Thread Arne Jansen
On 03.06.2011 22:44, Andrey Kuzmin wrote: On Fri, Jun 3, 2011 at 8:47 PM, Hugo Mills wrote: On Fri, Jun 03, 2011 at 06:24:41PM +0200, Arne Jansen wrote: Hi, If no one is already working on it, I'd like to take the Quota lock and see how far I come. Let me sketch out in short what I'm planning