[PATCH v2] Btrfs: rewrite btrfs_trim_block_group()

2011-11-24 Thread Li Zefan
There are various bugs in block group trimming: - It may trim from offset smaller than user-specified offset. - It may trim beyond user-specified range. - It may leak free space for extents smaller than specified minlen. - It may truncate the last trimmed extent thus leak free space. - With mixed

[PATCH] btrfs: polish names of kmem caches

2011-11-24 Thread David Sterba
Usecase: watch 'grep btrfs /proc/slabinfo' easy to watch all caches in one go. Signed-off-by: David Sterba dste...@suse.cz --- fs/btrfs/delayed-inode.c |2 +- fs/btrfs/extent_io.c |4 ++-- fs/btrfs/extent_map.c|2 +- fs/btrfs/inode.c | 10 +- 4 files

Re: btrfs encryption problems

2011-11-24 Thread 810d4rk
Now when I tried to mount the disk I get this: Error mounting: mount exited with exit code 12: NTFS signature is missing. Failed to mount '/dev/mapper/udisks-luks-uuid-269300fe-1329-42f8-b7fa-4a399a71d56f-uid1000': Invalid argument The device

Re: btrfs encryption problems

2011-11-24 Thread Jérôme Carretero
On Wed, 23 Nov 2011 19:38:37 + 810d4rk 810d...@gmail.com wrote: [ 4836.897206] sd 20:0:0:0: [sdc] Attached SCSI disk [ 4844.803652] EXT3-fs (dm-1): error: can't find ext3 filesystem on dev dm-1. [ 4844.856054] EXT2-fs (dm-1): error: can't find an ext2 filesystem on dev dm-1. [

Re: btrfs encryption problems

2011-11-24 Thread 810d4rk
These printks indicate that the encryption or password is not the same as used when creating the device. So at this stage, this has nothing to do with btrfs. No, Ive decrypted the volume with the password, I can confirm it and also I haven't change it, BTW I have some new output from the

Re: btrfs encryption problems

2011-11-24 Thread Jérôme Carretero
On Thu, 24 Nov 2011 21:43:50 + 810d4rk 810d...@gmail.com wrote: These printks indicate that the encryption or password is not the same as used when creating the device. So at this stage, this has nothing to do with btrfs. No, Ive decrypted the volume with the password, I can confirm

Re: mount errors

2011-11-24 Thread René Vangsgaard
After reboot my partition table was gone, and neither gpart og testdisk could recover it. Sad. Even though the missing partition table right after upgrading btrfs-tools is a coincidence, I will wait a while before giving btrfs another chance. Best of luck with creating a fsck for this promising

Re: [patch 03/99] btrfs: Panic on bad rbtree operations

2011-11-24 Thread David Sterba
On Wed, Nov 23, 2011 at 07:35:36PM -0500, Jeff Mahoney wrote: diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c index a1c9404..5a53d94 100644 --- a/fs/btrfs/ordered-data.c +++ b/fs/btrfs/ordered-data.c @@ -59,6 +59,14 @@ static struct rb_node *tree_insert(struct rb_root *root,

Re: [patch 13/99] btrfs: clear_extent_uptodate can drop gfp_t argumetn

2011-11-24 Thread David Sterba
Subject: Re: [patch 13/99] btrfs: clear_extent_uptodate can drop gfp_t argumetn typo in subject s/argumetn/argument/, same in the next 2 patches -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [patch 65/99] btrfs: -submit_bio_hook error push-up

2011-11-24 Thread David Sterba
On Wed, Nov 23, 2011 at 07:36:38PM -0500, Jeff Mahoney wrote: --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -2752,10 +2759,12 @@ retry: static void flush_epd_write_bio(struct extent_page_data *epd) { if (epd-bio) { + int ret; if (epd-sync_io) -

Re: [patch 03/99] btrfs: Panic on bad rbtree operations

2011-11-24 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/24/2011 06:41 PM, David Sterba wrote: On Wed, Nov 23, 2011 at 07:35:36PM -0500, Jeff Mahoney wrote: diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c index a1c9404..5a53d94 100644 --- a/fs/btrfs/ordered-data.c +++

Re: [patch 13/99] btrfs: clear_extent_uptodate can drop gfp_t argumetn

2011-11-24 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/24/2011 06:57 PM, David Sterba wrote: Subject: Re: [patch 13/99] btrfs: clear_extent_uptodate can drop gfp_t argumetn typo in subject s/argumetn/argument/, same in the next 2 patches Thanks. Fixed. - -Jeff - -- Jeff Mahoney SUSE Labs

Re: [patch 65/99] btrfs: -submit_bio_hook error push-up

2011-11-24 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/24/2011 07:46 PM, David Sterba wrote: On Wed, Nov 23, 2011 at 07:36:38PM -0500, Jeff Mahoney wrote: --- a/fs/btrfs/extent_io.c +++ b/fs/btrfs/extent_io.c @@ -2752,10 +2759,12 @@ retry: static void flush_epd_write_bio(struct extent_page_data

Re: [patch 01/99] btrfs: Add btrfs_panic()

2011-11-24 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/24/2011 01:37 AM, David Brown wrote: On Wed, Nov 23, 2011 at 09:22:06PM -0500, Jeff Mahoney wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 11/23/2011 09:05 PM, David Brown wrote: On Wed, Nov 23, 2011 at 07:35:34PM -0500, Jeff

Re: btrfs and load (sys)

2011-11-24 Thread Chris Samuel
On 24/11/11 12:00, Chris Samuel wrote: You're running quite an old kernel btrfs wise - it would be very interesting to see if you have the same issue with Linus's current git version (which has the latest btrfs code) or wait for 3.2-rc3. 3.2-rc3 is now out, Linus is after testers around the

Re: [patch 01/99] btrfs: Add btrfs_panic()

2011-11-24 Thread David Brown
On Thu, Nov 24, 2011 at 09:36:55PM -0500, Jeff Mahoney wrote: Probably best not to, it makes them inconsistent with the rest of the kernel's history when imported into git. The body becomes the commit text directly. I'll change them to do this since you're obviously correct. You're the first