To improve the code reuse its better to have btrfs_list_subvols
just return list of subvols witout printing
Signed-off-by: Anand Jain anand.j...@oracle.com
---
btrfs-list.c | 28 ++--
btrfs-list.h | 2 +-
cmds-subvolume.c | 4 ++--
3 files changed, 21
Signed-off-by: Anand Jain anand.j...@oracle.com
---
btrfs-list.c | 32 +++-
btrfs-list.h | 1 +
cmds-subvolume.c | 6 +-
3 files changed, 33 insertions(+), 6 deletions(-)
diff --git a/btrfs-list.c b/btrfs-list.c
index b656286..cc065e9 100644
---
Currently you can print subvol in a list or table format.
This patch will provide a way to extend this to other formats
like the upcoming raw format.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
btrfs-list.c | 26 +++---
btrfs-list.h | 3 +++
cmds-subvolume.c
The definition of the function open_file_or_dir() is moved from common.c
to utils.c in order to be able to share some common code between scrub
and the device stats in the following step. That common code uses
open_file_or_dir(). Since open_file_or_dir() makes use of the function
dirfd(3), the
We need a function which can get the root_info of a given
subvol. This is in preparation to add support for the show
sub-cli.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
btrfs-list.c | 38 ++
btrfs-list.h | 1 +
2 files changed, 39 insertions(+)
diff
This adds show sub-command to the btrfs subvol cli
to display detailed inforamtion of the given subvol
or snapshot.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
btrfs-list.c | 25 +++-
btrfs-list.h | 3 +-
cmds-subvolume.c | 176
get_subvol_name can be used other than the just with in cmds-send.c
so this patch will make it possible with out changing the original
intentions.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
cmds-send.c | 12 ++--
commands.h | 1 +
2 files changed, 7 insertions(+), 6
A useful function need to define it in a header file.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
commands.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/commands.h b/commands.h
index 8114a73..9b77f3e 100644
--- a/commands.h
+++ b/commands.h
@@ -103,3 +103,6 @@ int
Signed-off-by: Anand Jain anand.j...@oracle.com
---
btrfs-list.c | 6 ++
btrfs-list.h | 1 +
2 files changed, 7 insertions(+)
diff --git a/btrfs-list.c b/btrfs-list.c
index ec64a36..f5958cf 100644
--- a/btrfs-list.c
+++ b/btrfs-list.c
@@ -1144,6 +1144,11 @@ static int
As we would add more ways to list and manage the subvols
and snapshots, its better if we have struct root_info
defined in the header file.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
btrfs-list.c | 47 ---
btrfs-list.h | 47
On Wed, Jan 23, 2013 at 02:33:27PM +0800, Miao Xie wrote:
On wed, 23 Jan 2013 14:06:21 +0800, Liu Bo wrote:
On Wed, Jan 23, 2013 at 12:44:49PM +0800, Miao Xie wrote:
No, we can't. The other tasks which flush the delalloc data may remove the
inode
from the delalloc list/splice list. If we
kindly note
The patch-set in this email-thread is now obsolete,
since a newer patch-set[1] based on the git repo at
git://repo.or.cz/btrfs-progs-unstable/devel.git for-chris
has been submitted which IMO is easy and good for integration.
[1]
Subject: [PATCH 00/10] add show sub-command
On wed, 23 Jan 2013 16:17:53 +0800, Liu Bo wrote:
On Wed, Jan 23, 2013 at 02:33:27PM +0800, Miao Xie wrote:
On wed, 23 Jan 2013 14:06:21 +0800, Liu Bo wrote:
On Wed, Jan 23, 2013 at 12:44:49PM +0800, Miao Xie wrote:
No, we can't. The other tasks which flush the delalloc data may remove the
Hi Miao,
thank you for addressing the issue. I will try out this 5/5 patchset
and let you know what I see. I will apply it on top of latest
for-linus branch.
Thanks,
Alex.
On Wed, Jan 23, 2013 at 10:58 AM, Miao Xie mi...@cn.fujitsu.com wrote:
On wed, 23 Jan 2013 16:17:53 +0800, Liu Bo wrote:
On Wed, Jan 23, 2013 at 04:58:27PM +0800, Miao Xie wrote:
On wed, 23 Jan 2013 16:17:53 +0800, Liu Bo wrote:
On Wed, Jan 23, 2013 at 02:33:27PM +0800, Miao Xie wrote:
On wed, 23 Jan 2013 14:06:21 +0800, Liu Bo wrote:
On Wed, Jan 23, 2013 at 12:44:49PM +0800, Miao Xie wrote:
No, we can't.
On Wed, 23 Jan 2013 17:52:14 +0800, Liu Bo wrote:
On Wed, Jan 23, 2013 at 04:58:27PM +0800, Miao Xie wrote:
On wed, 23 Jan 2013 16:17:53 +0800, Liu Bo wrote:
On Wed, Jan 23, 2013 at 02:33:27PM +0800, Miao Xie wrote:
On wed, 23 Jan 2013 14:06:21 +0800, Liu Bo wrote:
On Wed, Jan 23, 2013 at
On Tue, Jan 22, 2013 at 03:45:35PM -0500, Josef Bacik wrote:
I noticed a WARN_ON going off when adding csums because we were going over
the amount of csum bytes that should have been allowed for an ordered
extent. This is a leftover from when we used to hold the csums privately
for direct io,
From: Chen Yang chenyang.f...@cn.fujitsu.com
Date: Fri, 18 Jan 2013 14:54:31 +0800
Subject: [PATCH] Btrfs-progs/receive: sparse and pre-allocated file support
for btrfs-send mechanism
When sending a file with sparse or pre-allocated part,
these parts will be sent as ZERO streams, and it's
From: Chen Yang chenyang.f...@cn.fujitsu.com
Date: Wed, 23 Jan 2013 11:21:51 +0800
Subject: [PATCH] Btrfs/send: sparse and pre-allocated file support for
btrfs-send mechanism
When sending a file with sparse or pre-allocated part,
these parts will be sent as ZERO streams, and it's unnecessary.
From: Chen Yang chenyang.f...@cn.fujitsu.com
Date: Fri, 18 Jan 2013 14:52:12 +0800
Subject: [PATCH] Btrfs-progs: Complete the help information of btrfs
send/receive
When typing command btrfs send --help or btrfs receive --help,
the help information of the commands is incomplete, which only
W dniu 22.01.2013 20:51, Zach Brown pisze:
It doesn't look like there's any easy answers in the code: no unbalanced
lock and unlocks and nothing scary done while holding the lock. (Some
list traversal, but the traces don't show another cpu stuck spinning on
a corrupt list).
If I had to guess,
Hi,
On Wed, Jan 23, 2013 at 1:04 PM, Chen Yang chenyang.f...@cn.fujitsu.com wrote:
From: Chen Yang chenyang.f...@cn.fujitsu.com
Date: Wed, 23 Jan 2013 11:21:51 +0800
Subject: [PATCH] Btrfs/send: sparse and pre-allocated file support for
btrfs-send mechanism
When sending a file with sparse
On Wed, Jan 23, 2013 at 1:04 PM, Chen Yang chenyang.f...@cn.fujitsu.com wrote:
From: Chen Yang chenyang.f...@cn.fujitsu.com
Date: Fri, 18 Jan 2013 14:54:31 +0800
Subject: [PATCH] Btrfs-progs/receive: sparse and pre-allocated file support
for btrfs-send mechanism
When sending a file with
On Tue, Jan 22, 2013 at 07:29:47PM +0400, Pavel Vasilyev wrote:
In single data mode, btrfs makes no special attempt to keep files
together on the same disk, but if a file is written linearly and never
modified there's a chance it might happen. (Each modification will COW
the file, putting
On 01/22/2013 04:52 PM, Mike Fleetwood wrote:
On 22 January 2013 17:22, Gene Czarcinskig...@czarc.net wrote:
This adds the archive target to the Makefile which simply executes
do-archive.sh. It also adds the remove of btrfs-progs.spec.in to
I think you mean btrfs-progs.spec without the .in
On Wed, Jan 23, 2013 at 12:01:08PM +0100, David Sterba wrote:
Survived a few hours of Chris' test and I'm running the full xfstests
again now.
After 4.5 hours of the same testsuite as before, this popped up in
syslog:
[53489.99] btrfs csum failed ino 63793 off 106496 csum 2411266714
On Wed, Jan 23, 2013 at 07:04:33PM +0800, Chen Yang wrote:
When sending a file with sparse or pre-allocated part,
these parts will be sent as ZERO streams, and it's unnecessary.
To improve this, we add a punch command on the sending side, so the
receiving side changed with it. The main
On Tue, Jan 22, 2013 at 11:39:31PM +0200, Racz Zoli wrote:
Can somebody help me with links to documentations, books or howtos
about how and where to start file system development in linux? It
doesn`t necessarily need to contain a full source code. I don`t want
to only copy paste somebody
On Wed, Jan 23, 2013 at 1:51 AM, Liu Bo bo.li@oracle.com wrote:
On Tue, Jan 22, 2013 at 11:41:19AM -0600, Mitch Harder wrote:
On Thu, Jan 17, 2013 at 8:42 AM, Mitch Harder
mitch.har...@sabayonlinux.org wrote:
On Wed, Jan 16, 2013 at 6:36 AM, Liu Bo bo.li@oracle.com wrote:
This comes
On Wed, Jan 23, 2013 at 08:41:25AM +1100, Skender wrote:
The only lines the have anythinf with btrfs are as follows:
[...]
That lacks information to analyze the error, so let's try it the usual
way. I'm not sure if you can grab the state of free space (via
btrfs fi df) from the time it happened,
On Tue, Jan 22, 2013 at 12:34:01PM -0500, Gene Czarcinski wrote:
I missed this better fix because I only started looking for outstanding
patches starting in June/July 2012.
No problem, there are multuple patches for some longstanging bugs, or
several versions of patch series. This is something
Hi Miao,
I have tested your patch, and the two discussed issues (OOM and
handling the same inode more than once) are solved with it.
However, snap creation under IO still takes 5-10 minutes for me.
Basically, now the situation is similar to kernel 3.6, before your
change to push the work to the
On Tue, Jan 22, 2013 at 01:00:56PM -0500, Gene Czarcinski wrote:
The patch which created btrfs-show-super.c had an extra line at the end and
I got annoyed at git-am complaining about it. This first patch fixes that.
This should have been a separate commit.
No need to send separate patches for
On Tue, Jan 22, 2013 at 03:51:19PM -0500, Gene Czarcinski wrote:
From: Christian Hesse l...@eworm.de
Hello everybody,
man pages for btrfs-progs are compressed by gzip by default. In Makefile the
variable GZIP is use, this evaluates to 'gzip gzip' on my system. From man
gzip:
The
On Tue, Jan 22, 2013 at 04:25:44PM -0500, Gene Czarcinski wrote:
I believe that this if the likely source of this patch:
http://article.gmane.org/gmane.comp.file-systems.btrfs/4547
Thanks for the pointer.
I do wonder how much this is still applicable. However, it has been in the
btrfs-progs
On 01/21/2013 10:56 AM, David Sterba wrote:
On Sun, Jan 20, 2013 at 04:04:06PM -0500, Gene Czarcinski wrote:
From: Nageswara R Sastrynasas...@in.ibm.com
Check for the return value of 'open_ctree()' before dereferencing it.
--- a/btrfs-image.c
+++ b/btrfs-image.c
@@ -491,6 +491,7 @@ static int
We will try to give it a shot. But it might be hard to reproduce.
This problem occurred only once, after one week of very heavy
(over)stress tests.
Yeah, understood.
Is it at least possible to confirm, that this is definitely the BTRFS
problem?
*Definitely*? No, sadly, the kernel is
Hi,
os: Gentoo
kernel: 3.7.3 from kernel.org
2 harddisks with btrfs and Raid1, lzo compression
trying to start a virtual machine (qemu-kvm) the system crashed giving
following messages:
kernel: [177417.378526] [ cut here ]
kernel: [177417.378562] kernel BUG at
On 1/19/13 12:06 PM, Gene Czarcinski wrote:
A small part of this patch proved unnecessary because it was
already corrected by the plug a memory leak reported by cppcheck
patch.
Thanks Gene - I'd kind of like to hold off on this one (just in
case it was on the verge of being merged) because
Here you go
sudo btrfs fi df /media/Storage/
Data, RAID0: total=1.48TB, used=980.54GB
System, RAID1: total=8.00MB, used=112.00KB
System: total=4.00MB, used=0.00
Metadata, RAID1: total=94.00GB, used=1.45GB
sudo btrfs fi df /
Data: total=353.45GB, used=263.93GB
System, DUP: total=40.00MB,
On 01/23/2013 03:12 AM, Anand Jain wrote:
David, Gene
Please accept this patch set which is on top of
git://repo.or.cz/btrfs-progs-unstable/devel.git for-chris
Oops. I am sorry to rain on your parade but the patches need another
rebasing. The ones in for-chris are the original set of
On Wed, Jan 23, 2013 at 08:21:07AM -0700, David Sterba wrote:
On Wed, Jan 23, 2013 at 12:01:08PM +0100, David Sterba wrote:
Survived a few hours of Chris' test and I'm running the full xfstests
again now.
After 4.5 hours of the same testsuite as before, this popped up in
syslog:
On Wed, Jan 23, 2013 at 10:05:04AM -0600, Mitch Harder wrote:
On Wed, Jan 23, 2013 at 1:51 AM, Liu Bo bo.li@oracle.com wrote:
On Tue, Jan 22, 2013 at 11:41:19AM -0600, Mitch Harder wrote:
On Thu, Jan 17, 2013 at 8:42 AM, Mitch Harder
mitch.har...@sabayonlinux.org wrote:
On Wed, Jan
On Wed, Jan 23, 2013 at 08:14:44PM +0100, F. Frederich wrote:
Hi,
os: Gentoo
kernel: 3.7.3 from kernel.org
2 harddisks with btrfs and Raid1, lzo compression
trying to start a virtual machine (qemu-kvm) the system crashed
giving following messages:
kernel: [177417.378526] [
On wed, 23 Jan 2013 19:02:30 +0200, Alex Lyakas wrote:
Hi Miao,
I have tested your patch, and the two discussed issues (OOM and
handling the same inode more than once) are solved with it.
However, snap creation under IO still takes 5-10 minutes for me.
Basically, now the situation is
However, you may want to wait a bit as David has a few more patches he
is working on. Also, one of the new (not in for-chris) patches has a
conflict with another patch in the first set.
Pls let me know when David's repo is ready for the rebase
so that I can resolve conflicts with this
On 1/23/13 2:12 AM, Anand Jain wrote:
The definition of the function open_file_or_dir() is moved from common.c
to utils.c in order to be able to share some common code between scrub
and the device stats in the following step. That common code uses
open_file_or_dir(). Since open_file_or_dir()
On 1/23/13 2:12 AM, Anand Jain wrote:
We need a function which can get the root_info of a given
subvol. This is in preparation to add support for the show
sub-cli.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
btrfs-list.c | 38 ++
btrfs-list.h |
On 1/23/13 2:12 AM, Anand Jain wrote:
This adds show sub-command to the btrfs subvol cli
to display detailed inforamtion of the given subvol
or snapshot.
Couple things below.
Signed-off-by: Anand Jain anand.j...@oracle.com
---
btrfs-list.c | 25 +++-
btrfs-list.h | 3 +-
49 matches
Mail list logo
