Re: Segfault in btrfs balance start due to kernel page allocation failure

2015-01-09 Thread Remy Blank
Duncan wrote on 2015-01-09 23:43: Also, when you post errors, please post kernel and btrfs-progs versions. I see from the trace that your kernel version is 3.17.7 so you're reasonably current there, but of course that doesn't give the userspace version. I did mention 3.17.7, but I forgot

Re: btrfs scrub and kernel parent transid

2015-01-09 Thread Duncan
Lars Callenbach posted on Fri, 09 Jan 2015 16:13:45 +0100 as excerpted: in kernel logs I get an error message of the type 'parent transid verify failed' but 'btrfs scrub ...' does not show any errors/inconsistencies. Do I have to worry about these kernel error messages? I believe you're

Re: btrfs_inode_item's otime?

2015-01-09 Thread David Sterba
On Thu, Jan 08, 2015 at 09:52:30PM +1100, Chris Samuel wrote: Sorry for the delay, took a while to poke around the code to figure out possible ways it would get done (and what the right structure was). No delay noticed :) Set the otime in btrfs_new_inode after the call to fill_inode_item.

Re: price to pay for nocow file bit?

2015-01-09 Thread David Sterba
On Thu, Jan 08, 2015 at 01:36:21PM -0500, Zygo Blaxell wrote: Hmmm...it seems the handwaving about tail-packing that I was previously ignoring is important after all. A few quick tests with filefrag show that btrfs isn't doing full tail-packing, only small file allocation (i.e. files smaller

Re: price to pay for nocow file bit?

2015-01-09 Thread Zygo Blaxell
On Fri, Jan 09, 2015 at 04:41:03PM +0100, David Sterba wrote: On Thu, Jan 08, 2015 at 01:36:21PM -0500, Zygo Blaxell wrote: Hmmm...it seems the handwaving about tail-packing that I was previously ignoring is important after all. A few quick tests with filefrag show that btrfs isn't doing

[PATCH 1/2] btrfs-progs:btrfstune: choose to ignore error when setting seeding enabled

2015-01-09 Thread Fan Chengniang
Before with -S option, setting positive value on seeding-enabled btrfs filesystem will cause error. So I add -i option which can ignore it. Reported-by: Chen Hanxiao chenhanx...@cn.fujitsu.com Signed-off-by: Fan Chengniang fancn.f...@cn.fujitsu.com --- Documentation/btrfstune.txt | 9 +++--

[PATCH 2/2] btrfs-progs:btrfstune:fix multiple options error

2015-01-09 Thread Fan Chengniang
when we use multiple options, error return status will be override by the last option status. example: btrfstune -S 1 -r /dev/loop0 when -S option fails and -r option succeeds, return value is 0, rather than 1, where 1 is the right return status. Reported-by: Chen Hanxiao

Re: BTRFS free space handling still needs more work: Hangs again (no complete lockups, just tasks stuck for some time)

2015-01-09 Thread Duncan
Martin Steigerwald posted on Thu, 08 Jan 2015 11:18:40 +0100 as excerpted: Duncan, I *did* file a bug. I think you misunderstood me... I understood that and actually said as much: But the recommendation is to file the bugzilla report precisely so it does /not/ get lost, and you've done

[PATCH] Btrfs: fix typo of variable in scrub_stripe

2015-01-09 Thread Tsutomu Itoh
The address that should be freed is not 'ppath' but 'path'. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- fs/btrfs/scrub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index f2bb13a..403fbdb 100644 --- a/fs/btrfs/scrub.c +++

Re: [PATCH] Btrfs: fix typo of variable in scrub_stripe

2015-01-09 Thread Miao Xie
On Fri, 09 Jan 2015 17:37:52 +0900, Tsutomu Itoh wrote: The address that should be freed is not 'ppath' but 'path'. Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com --- fs/btrfs/scrub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/scrub.c

Re: [PATCH] btrfs-progs: Fix a copy-n-paste bug in btrfs_read_fs_root().

2015-01-09 Thread David Sterba
Please also mention the commit that introdued the typo, I'll do that myself now. Thanks for catching the typo. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH] btrfs-progs: make btrfs qgroups show human readable sizes

2015-01-09 Thread David Sterba
On Fri, Jan 09, 2015 at 11:48:53AM -0200, Christian Robottom Reis wrote: On Fri, Jan 09, 2015 at 02:47:05PM +0800, Fan Chengniang wrote: make btrfs qgroups show human readable sizes, using -h option, example: Oh! This is really nice. I wonder, would there be a sane way to show the actual

Re: [PATCH] btrfs: delete chunk allocation attemp when setting block group ro

2015-01-09 Thread Shaohua Li
On Fri, Jan 09, 2015 at 10:50:17AM +0800, Miao Xie wrote: On Thu, 08 Jan 2015 18:06:50 -0800, Shaohua Li wrote: On Fri, Jan 09, 2015 at 09:01:57AM +0800, Miao Xie wrote: On Thu, 08 Jan 2015 13:23:13 -0800, Shaohua Li wrote: Below test will fail currently: mkfs.ext4 -F /dev/sda

Btrfs progs release 3.18.1

2015-01-09 Thread David Sterba
Hi, this is a followup that updates documentation, contains a few fixes from coverity reports and a few recent small-sized fixes. There's a pile of patches that reorder subcommands in the manpages. I did not send them to the mailinglist as they're pretty trivial and would be just noise. Similar

Re: [PATCH] Documentation: fix broken conversion

2015-01-09 Thread David Sterba
On Mon, Jan 05, 2015 at 03:10:09PM +0100, Peter Wu wrote: In this patch, the sed expression is dropped and asciidoc is configured to recognize `...` as a unconstrained quoted string (such that `attrs` is correctly emphasized) and to avoid adding quotes in contexts where it is not needed.

Re: [PATCH] btrfs-progs: make btrfs qgroups show human readable sizes

2015-01-09 Thread David Sterba
On Fri, Jan 09, 2015 at 02:47:05PM +0800, Fan Chengniang wrote: make btrfs qgroups show human readable sizes, using -h option, example: Thanks. Please add all the long options from the 'fi df' subcommands as well. As the subcommand is not entierly space size oriented, I'd like to keep the

btrfs scrub and kernel parent transid

2015-01-09 Thread Lars Callenbach
Hello, in kernel logs I get an error message of the type 'parent transid verify failed' but 'btrfs scrub ...' does not show any errors/inconsistencies. Do I have to worry about these kernel error messages? Best regards, Lars ~ # uname -a Linux 3.17.8-MYVERSION #1 SMP PREEMPT Thu Jan 8

Re: price to pay for nocow file bit?

2015-01-09 Thread David Sterba
On Thu, Jan 08, 2015 at 02:30:36PM +0100, Lennart Poettering wrote: On Wed, 07.01.15 15:10, Josef Bacik (jba...@fb.com) wrote: On 01/07/2015 12:43 PM, Lennart Poettering wrote: Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in

[PATCH RESEND v8 0/3] Introduce RCU string API

2015-01-09 Thread Omar Sandoval
Hi, everyone, Now that the merge window and the holidays are over, I've rebased this on v3.19-rc3 for the next merge window. This patch series introduces the RCU string API and cleans up the wreckage of sparse warnings which follow from it (shown here from when the patch was briefly in the btrfs

[PATCH RESEND v8 2/3] btrfs: refactor btrfs_device-name updates

2015-01-09 Thread Omar Sandoval
The rcu_string API introduced some new sparse errors but also revealed existing ones. First of all, the name in struct btrfs_device should be annotated as __rcu to prevent unsafe reads. Additionally, updates should go through rcu_dereference_protected to make it clear what's going on. This

[PATCH RESEND v8 1/3] Move BTRFS RCU string to common library

2015-01-09 Thread Omar Sandoval
The RCU-friendly string API used internally by BTRFS is generic enough for common use. This doesn't add any new functionality but instead just moves the code and documents the existing API. Reviewed-by: Josh Triplett j...@joshtriplett.org Acked-by: Paul E. McKenney paul...@linux.vnet.ibm.com

[RFC][PATCH] fstests: add dm-log-writes test and supporting code

2015-01-09 Thread Josef Bacik
This is a proof of concept that I've gotten working with my dm-log-writes target. I'd like to get feedback on this test and my approach in general. Currently this test fails on XFS because of either the ZERO RANGE or COLLAPSE RANGE operations in fsx. If I turn those off it passes fine as do all

Re: Segfault in btrfs balance start due to kernel page allocation failure

2015-01-09 Thread Duncan
Remy Blank posted on Fri, 09 Jan 2015 12:19:23 +0100 as excerpted: I have a btrfs filesystem that shows the following errors. This happens either when writing to the FS or when snapshotting, I'm not sure (this FS holds my backup, and I write to it with rsync and snapshot afterward). Jan 8

[PATCH] btrfs-progs: Remove redundant short description from cmd_snapshot_usage

2015-01-09 Thread Martin Volf
cmd_snapshot_usage in cmds-subvolume.c contains the short description twice. Remove the first one. Signed-off-by: Martin Volf martin.volf...@gmail.com --- diff --git a/cmds-subvolume.c b/cmds-subvolume.c index 15d4b97..9618cae 100644 --- a/cmds-subvolume.c +++ b/cmds-subvolume.c @@ -565,7 +565,6

Re: Regular rebalancing should be unnecessary? (Was: Re: BTRFS free space handling still needs more work: Hangs again)

2015-01-09 Thread Martin Steigerwald
Am Freitag, 9. Januar 2015, 11:04:32 schrieb Peter Waller: Apologies to those receiving this twice. On 27 December 2014 at 09:30, Hugo Mills h...@carfax.org.uk wrote: Now, since you're seeing lockups when the space on your disks is all allocated I'd say that's a bug. However, you're the

Segfault in btrfs balance start due to kernel page allocation failure

2015-01-09 Thread Remy Blank
I have a btrfs filesystem that shows the following errors. This happens either when writing to the FS or when snapshotting, I'm not sure (this FS holds my backup, and I write to it with rsync and snapshot afterward). Jan 8 13:54:33 twin kernel: BTRFS error (device dm-2): error inheriting props

Re: [PATCH] btrfs-progs: make btrfs qgroups show human readable sizes

2015-01-09 Thread Christian Robottom Reis
On Fri, Jan 09, 2015 at 02:47:05PM +0800, Fan Chengniang wrote: make btrfs qgroups show human readable sizes, using -h option, example: Oh! This is really nice. I wonder, would there be a sane way to show the actual path the qgroup is associated with as well? -- To unsubscribe from this list:

Re: Regular rebalancing should be unnecessary? (Was: Re: BTRFS free space handling still needs more work: Hangs again)

2015-01-09 Thread Peter Waller
Apologies to those receiving this twice. On 27 December 2014 at 09:30, Hugo Mills h...@carfax.org.uk wrote: Now, since you're seeing lockups when the space on your disks is all allocated I'd say that's a bug. However, you're the *only* person who's reported this as a regular occurrence.