Re: [PATCH] btrfs: explicitly set control file's private_data

2015-03-24 Thread David Sterba
On Mon, Mar 23, 2015 at 06:34:13PM +0100, Tom Van Braeckel wrote: The private_data member of the Btrfs control device file (/dev/btrfs-control) is used to hold the current transaction and needs to be initialized to NULL to signify that no transaction is in progress. We explicitly set the

Re: [PATCH] btrfs: Fix implicit inclusion of linux/uio.h

2015-03-24 Thread David Sterba
On Sun, Mar 22, 2015 at 04:46:15PM +, Mark Brown wrote: The btrfs inode.c relies on implicit inclusion of linux/uio.h for definitions of struct iov_iter and iov_iter_alignment() which breaks the current ARM allmodconfig build where that implicit inclusion does not happen. Add an explicit

Re: Upgrade to 3.19.2 Kernel fails to boot

2015-03-24 Thread Rich Freeman
On Tue, Mar 24, 2015 at 2:31 AM, Anand Jain anand.j...@oracle.com wrote: Do you have this fix .. [PATCH] Btrfs: release path before starting transaction in can_nocow_extent could you try ?. I believe I already have this patch. 3.18.9 contains this: commit

Re: WARNING at fs/btrfs/super.c:260 __btrfs_abort_transaction (error -17)

2015-03-24 Thread Sophie
On 24/03/15 17:34, Chris Mason wrote: On Tue, Mar 24, 2015 at 9:43 AM, Sophie Dexter just4pleis...@gmail.com wrote: On 20/03/2015 15:19, Sophie Dexter wrote: I'm given to understand that this is the right place to report a btrfs problem, I apologise if not :-( I have been using my router as

Re: btrfs balance fails with no space errors (despite having plenty)

2015-03-24 Thread Roman Mamedov
On Tue, 24 Mar 2015 22:25:30 + Kline, Matthew matthew.kl...@flukenetworks.com wrote: Sorry to necrobump this, but the issue came up again. I'm now on Linux 3.19.2 with btrfs-progs 3.19, and I converted my work laptop from ext4 to btrfs. Same issue - the conversion goes well, removing the

RE: btrfs balance fails with no space errors (despite having plenty)

2015-03-24 Thread Kline, Matthew
Post your btrfs fi df for the filesystem. In my experience it looks like the conversion may designate large portions of data as metadata for whatever reason. A way to clean this up is to run btrfs fi balance start -musage=5 -dusage=5 /path try repeating this again and again increasing

Re: btrfs balance fails with no space errors (despite having plenty)

2015-03-24 Thread Roman Mamedov
On Tue, 24 Mar 2015 23:09:47 + Kline, Matthew matthew.kl...@flukenetworks.com wrote: Data, single: total=44.00GiB, used=43.37GiB System, single: total=32.00MiB, used=12.00KiB Metadata, single: total=2.00GiB, used=876.84MiB GlobalReserve, single: total=296.00MiB, used=0.00B Total

[PATCH] fstests: fix _filter_transcation_commit_default

2015-03-24 Thread Eric Sandeen
btrfs has started emitting new information from cmd_subvol_delete(), so filter that out or it breaks btrfs/001: -Delete subvolume 'SCRATCH_MNT/snap' +Delete subvolume (no-commit): 'SCRATCH_MNT/snap' (Spell transaction correctly while we're at it.) Signed-off-by: Eric Sandeen

Re: btrfs balance fails with no space errors (despite having plenty)

2015-03-24 Thread Kline, Matthew
Sorry to necrobump this, but the issue came up again. I'm now on Linux 3.19.2 with btrfs-progs 3.19, and I converted my work laptop from ext4 to btrfs. Same issue - the conversion goes well, removing the ext* subvolume is fine, defragging is works, and then when I balance, it claims there is no

Re: btrfs balance fails with no space errors (despite having plenty)

2015-03-24 Thread Hugo Mills
On Tue, Mar 24, 2015 at 11:09:47PM +, Kline, Matthew wrote: Post your btrfs fi df for the filesystem. In my experience it looks like the conversion may designate large portions of data as metadata for whatever reason. A way to clean this up is to run btrfs fi balance start

[PATCH] fstests: update _filter_btrfs_version

2015-03-24 Thread Eric Sandeen
The btrfs cmd now sometimes emits btrfs-progs not Btrfs-progs as it used to, so update the filter accordingly. (This fixes a failure on btrfs/006 w/ btrfs-progs v3.19) Signed-off-by: Eric Sandeen sand...@redhat.com --- diff --git a/common/filter.btrfs b/common/filter.btrfs index

[PATCH 1/1] btrfs: incorrect handling for fiemap_fill_next_extent return

2015-03-24 Thread Chengyu Song
fiemap_fill_next_extent returns 0 on success, -errno on error, 1 if this was the last extent that will fit in user array. If 1 is returned, the return value may eventually returned to user space, which should not happen, according to manpage of ioctl. Signed-off-by: Chengyu Song

Re: [PATCH 1/1] btrfs: incorrect handling for fiemap_fill_next_extent return

2015-03-24 Thread David Sterba
On Tue, Mar 24, 2015 at 06:12:56PM -0400, Chengyu Song wrote: fiemap_fill_next_extent returns 0 on success, -errno on error, 1 if this was the last extent that will fit in user array. If 1 is returned, the return value may eventually returned to user space, which should not happen, according

Re: [PATCH 1/3] dm: log writes target V2

2015-03-24 Thread Mike Snitzer
On Fri, Mar 20 2015 at 10:50am -0400, Josef Bacik jba...@fb.com wrote: This creates a new target that is meant for file system developers to test file system integrity at particular points in the life of a file system. We capture all write requests and the data and log the requests and

[PATCH v2] btrfs: explicitly set control file's private_data

2015-03-24 Thread Tom Van Braeckel
The private_data member of the Btrfs control device file (/dev/btrfs-control) is used to hold the current transaction and needs to be initialized to NULL to signify that no transaction is in progress. We explicitly set the control file's private_data to NULL to be independent of whatever value

Re: WARNING at fs/btrfs/super.c:260 __btrfs_abort_transaction

2015-03-24 Thread David Sterba
On Fri, Mar 20, 2015 at 12:59:01PM +0800, Eryu Guan wrote: Filling a dm/lvm snapshot triggered this btrfs WARNING, kernel is 4.0-rc3+ It's an EIO because the underlying storage does not want to write the data. The same script can trigger warning on ext4 too, I'll file another bug report to

Re: New tool to recursive compress / decompress of files

2015-03-24 Thread David Sterba
On Sat, Mar 21, 2015 at 07:16:47PM +0100, Petr Bena wrote: I am just wondering, does that defragment trick work for non-root users? Defragmentation works where read and write would work for the user. Root can also defrag files that do not have the wite rwx bit set, but it's a special case

Re: [PATCH] btrfs-progs: Fix autoconf handling of --enable-convert

2015-03-24 Thread David Sterba
On Tue, Mar 24, 2015 at 08:55:41PM -0400, Mike Gilbert wrote: AC_ARG_ENABLE(convert) sets $enable_convert, not $enable_btrfsconvert. Signed-off-by: Mike Gilbert flop...@gentoo.org Applied, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message

Re: [PATCH] fstests: fix _filter_transcation_commit_default

2015-03-24 Thread Eryu Guan
On Tue, Mar 24, 2015 at 05:02:03PM -0500, Eric Sandeen wrote: btrfs has started emitting new information from cmd_subvol_delete(), so filter that out or it breaks btrfs/001: -Delete subvolume 'SCRATCH_MNT/snap' +Delete subvolume (no-commit): 'SCRATCH_MNT/snap' (Spell transaction

Re: [PATCH] fstests: update _filter_btrfs_version

2015-03-24 Thread Eryu Guan
On Tue, Mar 24, 2015 at 04:38:20PM -0500, Eric Sandeen wrote: The btrfs cmd now sometimes emits btrfs-progs not Btrfs-progs as it used to, so update the filter accordingly. (This fixes a failure on btrfs/006 w/ btrfs-progs v3.19) Signed-off-by: Eric Sandeen sand...@redhat.com Looks good

Re: [PATCH v2 3/5] btrfs-progs: Record and report every file extent hole.

2015-03-24 Thread Qu Wenruo
Thanks, I'll investigate it soon. Thanks, Qu On 1/2/15 1:12 AM, Qu Wenruo wrote: Record every file extent discontinuous hole in inode_record using a rb_tree member. Before the patch, btrfsck will only record the first file extent hole by using first_extent_gap, that's good for detecting

[PATCH] btrfs-progs: Fix autoconf handling of --enable-convert

2015-03-24 Thread Mike Gilbert
AC_ARG_ENABLE(convert) sets $enable_convert, not $enable_btrfsconvert. Signed-off-by: Mike Gilbert flop...@gentoo.org --- configure.ac | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 0692d5a..1171ed7 100644 --- a/configure.ac +++

Re: btrfs dedup - available or experimental? Or yet to be?

2015-03-24 Thread Rich Freeman
On Mon, Mar 23, 2015 at 7:22 PM, Hugo Mills h...@carfax.org.uk wrote: On Mon, Mar 23, 2015 at 11:10:46PM +, Martin wrote: As titled: Does btrfs have dedup (on raid1 multiple disks) that can be enabled? The current state of play is on the wiki:

Re: New tool to recursive compress / decompress of files

2015-03-24 Thread David Sterba
On Sat, Mar 21, 2015 at 07:12:52PM +0100, Petr Bena wrote: I would be certainly useful if this kind of tricks were mentioned on https://btrfs.wiki.kernel.org/index.php/Compression or anywhere on wiki There's a gap between developers (who don't want to write documentation because they know how

Re: [PATCH v2 3/5] btrfs-progs: Record and report every file extent hole.

2015-03-24 Thread Eric Sandeen
On 1/2/15 1:12 AM, Qu Wenruo wrote: Record every file extent discontinuous hole in inode_record using a rb_tree member. Before the patch, btrfsck will only record the first file extent hole by using first_extent_gap, that's good for detecting error, but not suitable for fixing it. This

Re: btrfs balance fails with no space errors (despite having plenty)

2015-03-24 Thread Russell Coker
I've been having ongoing issues with balance failing with no space errors in spite of having plenty. Strangely it seems to most often happen from cron jobs, when a cron job fails I can count on a manual balance succeeding. I'm running the latest Debian/Jessie kernel. -- Sent from my Samsung

Re: kvm bug, guest I/O blk device errors when qcow2 backing file is on Btrfs

2015-03-24 Thread Chris Murphy
It seems like it may not be a kernel bug. I've been able to reproduce, and not reproduce it, with kernel 3.18.9, varying in some other factor (Fedora 21, vs Fedora 20 live installs). The short version, With these, the problem does not reproduce: libvirt-* 1.1.3.9 qemu-* 1.6.1 With these, the

Re: btrfs fstrim status (RAID5)

2015-03-24 Thread Russell Coker
Debian/Wheezy userspace can't be expected to work as well as desired with a 3.19 kernel. Wheezy with BTRFS single or RAID1-1 works reasonably well as long as you have lots of free space, balance it regularly, and configure it not to resume a balance on reboot. Debian/Jessie works well with

Re: WARNING at fs/btrfs/super.c:260 __btrfs_abort_transaction (error -17)

2015-03-24 Thread Chris Mason
On Tue, Mar 24, 2015 at 9:43 AM, Sophie Dexter just4pleis...@gmail.com wrote: On 20/03/2015 15:19, Sophie Dexter wrote: I'm given to understand that this is the right place to report a btrfs problem, I apologise if not :-( I have been using my router as a simple NFS NAS for around 2 years

Re: WARNING at fs/btrfs/super.c:260 __btrfs_abort_transaction (error -17)

2015-03-24 Thread Sophie Dexter
On 20/03/2015 15:19, Sophie Dexter wrote: I'm given to understand that this is the right place to report a btrfs problem, I apologise if not :-( I have been using my router as a simple NFS NAS for around 2 years with an ext3 formatted 2 TB Western Digital 2.5 USB Passport disk. I have been

Re: kvm bug, guest I/O blk device errors when qcow2 backing file is on Btrfs

2015-03-24 Thread Chris Murphy
On Mon, Mar 23, 2015 at 3:13 PM, Chris Mason c...@fb.com wrote: On Mon, Mar 23, 2015 at 02:01:41PM -0600, Chris Murphy wrote: I can't tell if this is a kvm virtio blk device regression, with cache=none and cache=directsync, or if it's a Btrfs regression. The summary is that on a host using

Re: Upgrade to 3.19.2 Kernel fails to boot

2015-03-24 Thread Anand Jain
Do you have this fix .. [PATCH] Btrfs: release path before starting transaction in can_nocow_extent could you try ?. Thanks, Anand On 03/24/2015 12:37 AM, Rich Freeman wrote: On Mon, Mar 23, 2015 at 9:22 AM, Rich Freeman r-bt...@thefreemanclan.net wrote: I'm having a similar

[PATCH] btrfs-progs: convert, add long options for all short options

2015-03-24 Thread David Sterba
Signed-off-by: David Sterba dste...@suse.cz --- Documentation/btrfs-convert.txt | 21 +++-- btrfs-convert.c | 27 ++- 2 files changed, 29 insertions(+), 19 deletions(-) diff --git a/Documentation/btrfs-convert.txt

Is rbtree really needed to restore ref_root in btrfs_delayed_ref_head?

2015-03-24 Thread Qu Wenruo
Hi all and maintainers. I'm investigating several qgroup bugs, and find out current delayed ref implement has several possible problem which may lead to qgroup bugs. Although my previous RFC patchset (http://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg42458.html) is trying to