Re: [PATCH v2 8/9] btrfs-progs: convert: Introduce function to check if convert image is able to be rolled back

On Fri, Feb 24, 2017 at 01:52:31PM +0800, Qu Wenruo wrote: > +static int check_image_file_extents(struct btrfs_root *image_root, u64 ino, > + u64 total_size, char *reserved_ranges[]) > +{ > + struct btrfs_key key; > + struct btrfs_path path; > + struct

Re: [PATCH] qgroup: Retry after commit on getting EDQUOT

On 03/09/2017 10:54 AM, David Sterba wrote: > On Sun, Feb 19, 2017 at 07:30:59AM -0600, Goldwyn Rodrigues wrote: >> From: Goldwyn Rodrigues >> >> We are facing the same problem with EDQUOT which was experienced with >> ENOSPC. Not sure if we require a full ticketing system

Re: [PATCH v3] btrfs: add missing memset while reading compressed inline extents

On Fri, Mar 10, 2017 at 11:19:24AM -0500, Chris Mason wrote: > On 03/09/2017 11:41 PM, Zygo Blaxell wrote: > >On Thu, Mar 09, 2017 at 10:39:49AM -0500, Chris Mason wrote: > >> > >> > >>On 03/08/2017 09:12 PM, Zygo Blaxell wrote: > >>>This is a story about 4 distinct (and very old) btrfs bugs. >

Re: [PATCH v3] btrfs: add missing memset while reading compressed inline extents

On 03/10/2017 01:56 PM, Zygo Blaxell wrote: On Fri, Mar 10, 2017 at 11:19:24AM -0500, Chris Mason wrote: On 03/09/2017 11:41 PM, Zygo Blaxell wrote: On Thu, Mar 09, 2017 at 10:39:49AM -0500, Chris Mason wrote: On 03/08/2017 09:12 PM, Zygo Blaxell wrote: This is a story about 4 distinct

[PATCH v2] Btrfs: add file item tracepoint

While debugging truncate problems, I found that these tracepoints could help us quickly know what went wrong. Two sets of tracepoints are created to track regular/prealloc file item and inline file item respectively, I put inline as a separate one since what inline file items cares about are way

Re: [PATCH v3] btrfs: add missing memset while reading compressed inline extents

On 03/09/2017 11:41 PM, Zygo Blaxell wrote: On Thu, Mar 09, 2017 at 10:39:49AM -0500, Chris Mason wrote: On 03/08/2017 09:12 PM, Zygo Blaxell wrote: This is a story about 4 distinct (and very old) btrfs bugs. Really great write up. [ ... ] diff --git a/fs/btrfs/inode.c

Re: [PATCH] qgroup: Retry after commit on getting EDQUOT

On Sun, Feb 19, 2017 at 1:30 PM, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > We are facing the same problem with EDQUOT which was experienced with > ENOSPC. Not sure if we require a full ticketing system such as ENOSPC, but > here is a fix. Let me

Re: [PATCH v3] btrfs: add missing memset while reading compressed inline extents

On Fri, Mar 10, 2017 at 02:12:54PM -0500, Chris Mason wrote: > > > On 03/10/2017 01:56 PM, Zygo Blaxell wrote: > >On Fri, Mar 10, 2017 at 11:19:24AM -0500, Chris Mason wrote: > >>On 03/09/2017 11:41 PM, Zygo Blaxell wrote: > >>>On Thu, Mar 09, 2017 at 10:39:49AM -0500, Chris Mason wrote: >

[PATCH v4] btrfs: add missing memset while reading compressed inline extents

This is a story about 4 distinct (and very old) btrfs bugs. Commit c8b978188c ("Btrfs: Add zlib compression support") added three data corruption bugs for inline extents (bugs #1-3). Commit 93c82d5750 ("Btrfs: zero page past end of inline file items") fixed bug #1: uncompressed inline extents

Re: [PATCH] qgroup: Retry after commit on getting EDQUOT

On 03/10/2017 10:06 AM, Filipe Manana wrote: > On Sun, Feb 19, 2017 at 1:30 PM, Goldwyn Rodrigues wrote: >> From: Goldwyn Rodrigues >> >> We are facing the same problem with EDQUOT which was experienced with >> ENOSPC. Not sure if we require a full

Oops in btrfs_recover_relocation, kernel 4.8.1

Does anyone recall seeing this oops before? Is it something that can be fixed with a newer kernel? (I'm on a USB stick for this, so a new kernel is a major undertaking, and I'd like some reasonable expectation of success if I do it). Background: I'm rebuilding a dead server. I needed to