[PATCH] btrfs: qgroup: move noisy underflow warning to debugging build

The WARN_ON and warning from report_reserved_underflow can become very noisy and is visible unconditionally although this is namely for debugging. The patch "btrfs: Add WARN_ON for qgroup reserved underflow" (18dc22c19bef520cca11ce4c0807ac9dec48d31f) went to 4.11-rc1 and the plan was to get the

Re: [PATCH 9/9] btrfs-progs: modify: Introduce option to specify the pattern to fill mirror

Nice. With this new option, it should be possible to achieve something like RAID56 corruption test-script say, https://patchwork.kernel.org/patch/9583455/ right? Cheers, Lakshmipathi.G FOSS Programmer. http://www.giis.co.in http://www.webminal.org On Mon, Apr 17, 2017 at 8:56 AM, Qu Wenruo

Re: btrfs check --check-data-csum malfunctioning?

On Tue, Apr 18, 2017 at 02:41:49PM +0200, Werner Braun wrote: > Hi, > > i have a WD WD40EZRX with strange beaviour off btrfs check vs. btrfs scrub > > running btrfs check --check-data-csum returns no errors on the disk > > running btrfs scrub on the disk finds tons of errors > > i could clear

Re: [PATCH v4 5/7] btrfs: use q which is already obtained from bdev_get_queue

On Thu, Apr 06, 2017 at 11:22:51AM +0800, Anand Jain wrote: > We have already assigned q from bdev_get_queue() so use it. > And rearrange the code for better view. > > Signed-off-by: Anand Jain > Reviewed-by: David Sterba JFYI, this patch has been added

Re: [PATCH v4 6/7] btrfs: delete unused member nobarriers

On Thu, Apr 06, 2017 at 11:22:52AM +0800, Anand Jain wrote: > The last consumer of nobarriers is removed by the commit [1] and sync > won't fail with EOPNOTSUPP anymore. Thus, now when write cache is write > through it just return success without actually transpiring such a > request to the block

Re: [PATCH v4 7/7] btrfs: check if the device is flush capable

On Thu, Apr 06, 2017 at 11:22:53AM +0800, Anand Jain wrote: > The blkdev_issue_flush() will check if the write cache is enabled > before submitting the flush. This will add a code to fail fast if > its not. > > Signed-off-by: Anand Jain > --- Reviewed-by: David Sterba

btrfs check --check-data-csum malfunctioning?

Hi, i have a WD WD40EZRX with strange beaviour off btrfs check vs. btrfs scrub running btrfs check --check-data-csum returns no errors on the disk running btrfs scrub on the disk finds tons of errors i could clear the disk and send it to anyone intrested in ;-) -- Werner Braun +49 178 145

Re: btrfs check --check-data-csum malfunctioning?

On 18.04.2017 15:15, Hugo Mills wrote: On Tue, Apr 18, 2017 at 02:41:49PM +0200, Werner Braun wrote: Hi, i have a WD WD40EZRX with strange beaviour off btrfs check vs. btrfs scrub running btrfs check --check-data-csum returns no errors on the disk running btrfs scrub on the disk finds tons

Re: Btrfs/SSD

On 2017-04-18 09:02, Imran Geriskovan wrote: On 4/17/17, Austin S. Hemmelgarn wrote: Regarding BTRFS specifically: * Given my recently newfound understanding of what the 'ssd' mount option actually does, I'm inclined to recommend that people who are using high-end SSD's

Re: [PATCH v4 1/7] btrfs: use blkdev_issue_flush to flush the device cache

On Thu, Apr 06, 2017 at 11:22:47AM +0800, Anand Jain wrote: > As of now we do alloc an empty bio and then use the flag REQ_PREFLUSH > to flush the device cache, instead we can use blkdev_issue_flush() > for this puspose. This would change the scheduling characteristics. Right now, the caller

Re: Remounting read-write after error is not allowed

So you think this might be a bug in the Kernel? In fact I wanted to try with a newer kernel, but could no longer reproduce the issue. In addition, I did a scrub on the partition and there were no errors. So wither there was some transient disk issue that affected only that partition, or there is a

Re: Btrfs/SSD

On Tue, Apr 18, 2017 at 07:31:34AM -0400, Austin S. Hemmelgarn wrote: > On 2017-04-17 15:39, Chris Murphy wrote: > >On Mon, Apr 17, 2017 at 1:26 PM, Austin S. Hemmelgarn > > wrote: > >>On 2017-04-17 14:34, Chris Murphy wrote: [...] > >It's almost like we need these things

Re: Btrfs/SSD

On 2017-04-17 15:22, Imran Geriskovan wrote: On 4/17/17, Roman Mamedov wrote: "Austin S. Hemmelgarn" wrote: * Compression should help performance and device lifetime most of the time, unless your CPU is fully utilized on a regular basis (in which

btrfs check bug

Hi, i have to try to create a new extent-tree after checksum error not solveable with srub or init-csum-tree. Now i got this failure output from btrfs --repair:   ERROR: errors found in extent allocation tree or chunk allocation Fixed 0 roots. checking free space cache checking fs roots root 5

Re: [PATCH v6 2/2] btrfs: scrub: Fix RAID56 recovery race condition

On Fri, Apr 14, 2017 at 08:35:55AM +0800, Qu Wenruo wrote: > When scrubbing a RAID5 which has recoverable data corruption (only one > data stripe is corrupted), sometimes scrub will report more csum errors > than expected. Sometimes even unrecoverable error will be reported. > > The problem can

Re: [PATCH v6 1/2] btrfs: scrub: Introduce full stripe lock for RAID56

On Fri, Apr 14, 2017 at 08:35:54AM +0800, Qu Wenruo wrote: > Unlike mirror based profiles, RAID5/6 recovery needs to read out the > whole full stripe. > > And if we don't do proper protect, it can easily cause race condition. > > Introduce 2 new functions: lock_full_stripe() and

Re: Btrfs/SSD

On 2017-04-17 15:39, Chris Murphy wrote: On Mon, Apr 17, 2017 at 1:26 PM, Austin S. Hemmelgarn wrote: On 2017-04-17 14:34, Chris Murphy wrote: Nope. The first paragraph applies to NVMe machine with ssd mount option. Few fragments. The second paragraph applies to SD

Re: [PATCH 8/8] nowait aio: btrfs

On Fri, Apr 14, 2017 at 07:02:57AM -0500, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > Return EAGAIN if any of the following checks fail > + i_rwsem is not lockable > + NODATACOW or PREALLOC is not set > + Cannot nocow at the desired location > + Writing beyond

Re: btrfs check --check-data-csum malfunctioning?

Werner Braun posted on Tue, 18 Apr 2017 14:41:49 +0200 as excerpted: > Hi, > > i have a WD WD40EZRX with strange beaviour off btrfs check vs. btrfs > scrub > > running btrfs check --check-data-csum returns no errors on the disk > > running btrfs scrub on the disk finds tons of errors A dev

Re: [PATCH] btrfs: qgroup: move noisy underflow warning to debugging build

At 04/18/2017 11:09 PM, David Sterba wrote: The WARN_ON and warning from report_reserved_underflow can become very noisy and is visible unconditionally although this is namely for debugging. The patch "btrfs: Add WARN_ON for qgroup reserved underflow" (18dc22c19bef520cca11ce4c0807ac9dec48d31f)

Re: [PATCH v4 1/7] btrfs: use blkdev_issue_flush to flush the device cache

On 04/14/2017 02:41 AM, Liu Bo wrote: On Thu, Apr 06, 2017 at 11:22:47AM +0800, Anand Jain wrote: As of now we do alloc an empty bio and then use the flag REQ_PREFLUSH to flush the device cache, instead we can use blkdev_issue_flush() for this puspose. Also now no need to check the return

Re: [PATCH v4 1/7] btrfs: use blkdev_issue_flush to flush the device cache

On 04/18/2017 09:54 PM, David Sterba wrote: On Thu, Apr 06, 2017 at 11:22:47AM +0800, Anand Jain wrote: As of now we do alloc an empty bio and then use the flag REQ_PREFLUSH to flush the device cache, instead we can use blkdev_issue_flush() for this puspose. This would change the scheduling

Re: btrfs check --check-data-csum malfunctioning?

At 04/18/2017 08:41 PM, Werner Braun wrote: Hi, i have a WD WD40EZRX with strange beaviour off btrfs check vs. btrfs scrub running btrfs check --check-data-csum returns no errors on the disk running btrfs scrub on the disk finds tons of errors i could clear the disk and send it to anyone