Re: New data=ordered code pushed out to btrfs-unstable

2008-07-20 Thread Ric Wheeler
Chris Mason wrote: On Fri, 2008-07-18 at 18:35 -0400, Ric Wheeler wrote: Chris Mason wrote: On Fri, 2008-07-18 at 16:09 -0400, Ric Wheeler wrote: Just to kick the tires, I tried the same test that I ran last week on ext4. Everything was going great, I decided to kill it after

Re: New data=ordered code pushed out to btrfs-unstable

2008-07-20 Thread Chris Mason
On Sun, 2008-07-20 at 08:19 -0400, Ric Wheeler wrote: Chris Mason wrote: On Fri, 2008-07-18 at 18:35 -0400, Ric Wheeler wrote: Chris Mason wrote: On Fri, 2008-07-18 at 16:09 -0400, Ric Wheeler wrote: Just to kick the tires, I tried the same test that I ran last week

Re: New data=ordered code pushed out to btrfs-unstable

2008-07-20 Thread Ric Wheeler
Chris Mason wrote: On Sun, 2008-07-20 at 08:19 -0400, Ric Wheeler wrote: Chris Mason wrote: On Fri, 2008-07-18 at 18:35 -0400, Ric Wheeler wrote: Chris Mason wrote: On Fri, 2008-07-18 at 16:09 -0400, Ric Wheeler wrote: Just to kick the

Re: Problem during implementing NFS support

2008-07-20 Thread David Woodhouse
On Mon, 2008-07-21 at 00:41 +0530, Balaji Rao wrote: Hi, There's a problem in btrfs_readdir that tries to lock a root node with one being held. This happens when NFS calls vfs_readdir function with a nfs specific filldir function pointer. This filldir function, called with the lock held

Re: Problem during implementing NFS support

2008-07-20 Thread David Woodhouse
On Mon, 2008-07-21 at 01:06 +0530, Balaji Rao wrote: The idea of the patch seems correct to me, that once we own the lock, an attempt to take it again should be a nop. Well, kind of correct. There are potentially race conditions with the handling of f-readdir_process, but given that we only