Re: btrfs: compression breaks cp and cross-FS mv, FS_IOC_FIEMAP bug?

2011-02-15 Thread Pádraig Brady
On 14/02/11 17:58, Marti Raudsepp wrote: On Mon, Feb 14, 2011 at 17:01, Chris Mason chris.ma...@oracle.com wrote: Or, it could just be delalloc ;) I suspect delalloc. After creating the file, filefrag reports 1 extent found, but for some reason it doesn't actually print out details of the

[PATCH] Btrfs: fix uncheck memory allocations

2011-02-15 Thread Yoshinori Sano
To make Btrfs code more robust, several return value checks where memory allocation can fail are introduced. I use BUG_ON where I don't know how to handle the error properly, which increases the number of using the notorious BUG_ON, though. Signed-off-by: Yoshinori Sano yoshinori.s...@gmail.com

Re: [PATCH] Btrfs: fix uncheck memory allocations

2011-02-15 Thread Yoshinori Sano
This is the modified version of my previous patch. This patch is created by removing the duplicated (conflicted) code of the following work. Tsutomu Itoh (1) commits (+7/-3): Btrfs: check return value of alloc_extent_map() http://marc.info/?l=linux-btrfsm=129774185204197w=2 Regards,

Re: btrfs: compression breaks cp and cross-FS mv, FS_IOC_FIEMAP bug?

2011-02-15 Thread Josef Bacik
On Tue, Feb 15, 2011 at 11:30:38AM +, Pádraig Brady wrote: On 14/02/11 17:58, Marti Raudsepp wrote: On Mon, Feb 14, 2011 at 17:01, Chris Mason chris.ma...@oracle.com wrote: Or, it could just be delalloc ;) I suspect delalloc. After creating the file, filefrag reports 1 extent

Building btrfs as a dkms module on Debian

2011-02-15 Thread Yuri D'Elia
Hi everyone. I was trying to test a more recent version of btrfs on my current kernel (2.6.37) using dkms, without success. I followed these instructions: https://btrfs.wiki.kernel.org/index.php/Btrfs_source_repositories - cloned the repo - symlinked to /usr/src/btrfs-git - patched version.sh:

[PATCH] Btrfs: set FMODE_EXCL in btrfs_device-mode

2011-02-15 Thread Ilya Dryomov
This fixes a bug introduced in d4d77629, where the device added online (and therefore initialized via btrfs_init_new_device()) would be left with the positive bdev-bd_holders after unmount. Since d4d77629 we no longer OR FMODE_EXCL explicitly on blkdev_put(), set it in btrfs_device-mode.

[PATCH] Btrfs: make btrfs_rm_device() fail gracefully

2011-02-15 Thread Ilya Dryomov
If shrinking done as part of the online device removal fails add that device back to the allocation list and increment the rw_devices counter. This fixes two bugs: 1) we could have a perfectly good device out of alloc list for no good reason; 2) in the btrfs consisting of two devices, failure in

Excluding a device from storing snapshot data?

2011-02-15 Thread Bert Wesarg
Hi all, I'm currently envision a backup setup for my laptop which has a SSD. I would like to use an external HDD und span a raid1 over these two devices and also creating snapshots. What I would like to prevent, is that these snapshots take storage space on the SSD, because SSD storage is

[PATCH] btrfs: fixed a braces code style issue

2011-02-15 Thread Tim Peters
i fixed a braces code style issue on inode.c Signed-off-by: Tim Peters m...@darksecond.nl --- fs/btrfs/inode.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index fb9bd78..46125c3 100644 --- a/fs/btrfs/inode.c +++

Re: [PATCH V2 0/3] drivers/staging: zcache: dynamic page cache/swap compression

2011-02-15 Thread Matt
On Mon, Feb 14, 2011 at 8:59 PM, Matt jackdac...@gmail.com wrote: On Mon, Feb 14, 2011 at 1:29 AM, Matt jackdac...@gmail.com wrote: On Mon, Feb 14, 2011 at 1:24 AM, Matt jackdac...@gmail.com wrote: On Mon, Feb 14, 2011 at 12:08 AM, Matt jackdac...@gmail.com wrote: On Wed, Feb 9, 2011 at 1:03

Re: [PATCH V2 0/3] drivers/staging: zcache: dynamic page cache/swap compression

2011-02-15 Thread Matt
On Mon, Feb 14, 2011 at 4:35 AM, Minchan Kim minchan@gmail.com wrote: On Mon, Feb 14, 2011 at 10:29 AM, Matt jackdac...@gmail.com wrote: On Mon, Feb 14, 2011 at 1:24 AM, Matt jackdac...@gmail.com wrote: On Mon, Feb 14, 2011 at 12:08 AM, Matt jackdac...@gmail.com wrote: On Wed, Feb 9, 2011

RE: [PATCH V2 0/3] drivers/staging: zcache: dynamic page cache/swap compression

2011-02-15 Thread Dan Magenheimer
-Original Message- From: Matt [mailto:jackdac...@gmail.com] Sent: Tuesday, February 15, 2011 5:12 PM To: Minchan Kim Cc: Dan Magenheimer; gre...@suse.de; Chris Mason; linux- ker...@vger.kernel.org; linux...@kvack.org; ngu...@vflare.org; linux- bt...@vger.kernel.org; Josef Bacik; Dan

Re: [PATCH V2 0/3] drivers/staging: zcache: dynamic page cache/swap compression

2011-02-15 Thread Matt
On Wed, Feb 16, 2011 at 1:27 AM, Dan Magenheimer dan.magenhei...@oracle.com wrote: -Original Message- From: Matt [mailto:jackdac...@gmail.com] Sent: Tuesday, February 15, 2011 5:12 PM To: Minchan Kim Cc: Dan Magenheimer; gre...@suse.de; Chris Mason; linux- ker...@vger.kernel.org;

Re: Building btrfs as a dkms module on Debian

2011-02-15 Thread liubo
On 02/15/2011 11:35 PM, Yuri D'Elia wrote: Hi everyone. I was trying to test a more recent version of btrfs on my current kernel (2.6.37) using dkms, without success. I followed these instructions: https://btrfs.wiki.kernel.org/index.php/Btrfs_source_repositories - cloned the repo -

Re: [PATCH V2 0/3] drivers/staging: zcache: dynamic page cache/swap compression

2011-02-15 Thread Minchan Kim
On Wed, Feb 16, 2011 at 10:27 AM, Dan Magenheimer dan.magenhei...@oracle.com wrote: -Original Message- From: Matt [mailto:jackdac...@gmail.com] Sent: Tuesday, February 15, 2011 5:12 PM To: Minchan Kim Cc: Dan Magenheimer; gre...@suse.de; Chris Mason; linux- ker...@vger.kernel.org;

[PATCH 1/2] Btrfs: Fix BTRFS_IOC_SUBVOL_SETFLAGS ioctl

2011-02-15 Thread Li Zefan
- Check user-specified flags correctly - Check the inode owership - Search root item in root tree but not fs tree Reported-by: Dan Rosenberg drosenb...@vsecurity.com Signed-off-by: Li Zefan l...@cn.fujitsu.com --- fs/btrfs/ioctl.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-)

[PATCH 2/2] Btrfs: Avoid accessing unmapped kernel address

2011-02-15 Thread Li Zefan
When decompressing a chunk of data, we'll copy the data out to a working buffer if the data is stored in more than one page, otherwise we'll use the mapped page directly to avoid memory copy. In the latter case, we'll end up accessing the kernel address after we've unmapped the page in a corner