[PATCH] btrfs-progs: mkfs: rename nodiscard option to K

2012-07-17 Thread David Sterba
The original patch named the option -T, mkfs.xfs uses -K let's keep it same. Signed-off-by: David Sterba dste...@suse.cz --- Based on 8935d8436147f (current master) not yet tagged as 0.20, I hope it's still time to fix it before it's released. Sorry for not sending the patch earlier.

[PATCH] btrfs-progs: mkfs: create root directory with 755 permissions

2012-07-17 Thread David Sterba
That's what all other mkfs do and there's no reason for 0555. Signed-off-by: David Sterba dste...@suse.cz --- utils.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/utils.c b/utils.c index aade9e2..cfe7c49 100644 --- a/utils.c +++ b/utils.c @@ -614,7 +614,7 @@ int

[PATCH v2] btrfs-progs: mkfs: rename nodiscard option to K

2012-07-17 Thread David Sterba
The original patch named the option -T, mkfs.xfs uses -K let's keep it same. Signed-off-by: David Sterba dste...@suse.cz --- v1-v2: original patch at http://comments.gmane.org/gmane.comp.file-systems.btrfs/16287 listed the shot option, dunno where it got lost, adding it now.

[PATCH] btrfs-progs: fsck: understand the -s option

2012-07-17 Thread David Sterba
Short options have to be repeated at the getopt_long call. Signed-off-by: David Sterba dste...@suse.cz --- btrfsck.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/btrfsck.c b/btrfsck.c index 088b9f4..2e81adc 100644 --- a/btrfsck.c +++ b/btrfsck.c @@ -3499,7 +3499,7 @@

[PATCH] btrfs-progs: sort devices by id in fi show

2012-07-17 Thread David Sterba
Devids are printed in descending order now, switch it to ascending. Signed-off-by: David Sterba dste...@suse.cz --- btrfs-show.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/btrfs-show.c b/btrfs-show.c index 8210fd2..2a85932 100644 --- a/btrfs-show.c +++

[PATCH] Btrfs: cleanup for unused ref cache stuff

2012-07-17 Thread Liu Bo
As ref cache has been removed from btrfs, there is no user on its lock and its check. Signed-off-by: Liu Bo liubo2...@cn.fujitsu.com --- fs/btrfs/ctree.h |3 --- fs/btrfs/disk-io.c |5 - 2 files changed, 0 insertions(+), 8 deletions(-) diff --git a/fs/btrfs/ctree.h

Unmountable btrfs filesystem

2012-07-17 Thread Providence M. SALUMU
Hi devs, I can't mount my btrfs-based external disk. I don't know what happened to the disk, but usually it gets disconnected (usb cable pulled out) buy my 8 months old daughter. Here's the output from dmesg: [ 299.699543] parent transid verify failed on 528952573952 wanted 22726 found 22728 [

Re: [PATCH] Btrfs: add DEVICE_READY ioctl

2012-07-17 Thread David Sterba
On Fri, Jun 22, 2012 at 08:12:52PM +0200, Goffredo Baroncelli wrote: On 06/21/2012 10:10 PM, Josef Bacik wrote: This will be used in conjunction with btrfs device ready dev. This is needed for initrd's to have a nice and lightweight way to tell if all of the devices needed for a file

Re: [PATCH 0/5] btrfs: lz4/lz4hc compression

2012-07-17 Thread David Sterba
On Sat, Jul 07, 2012 at 11:06:44PM +0200, Jan Killius wrote: I get lots of kick the bucket messages with the newest lz4 patches. Is there any way to debug/fix this ? That was a debugging message, harmless, will be removed in another round. david -- To unsubscribe from this list: send the line

Re: [PATCH 0/2] Support for small units in display

2012-07-17 Thread David Sterba
On Mon, Jul 09, 2012 at 05:27:41PM +, Pierre Carrier wrote: I didn't test the initial patches enough. A second round is coming. Please indicate the updated version by eg. adding a v2 to the subject of the cover letter and describe the changes, makes it more clear to maintainers/reviewers

Re: [PATCH 1/2] utils.c: fix sizes in B malloc in pretty_sizes

2012-07-17 Thread David Sterba
On Mon, Jul 09, 2012 at 05:29:34PM +, Pierre Carrier wrote: Before, sizes below 1KB are still displayed in KB, but without a unit. Does it matter when the only size below 1KB one can get is 0 ? Though for sake of consistency the B unit could be there in that case as well. -- To unsubscribe

Re: [PATCH 2/2] utils.c: offer to limit divisions in pretty_sizes

2012-07-17 Thread David Sterba
On Mon, Jul 09, 2012 at 05:30:21PM +, Pierre Carrier wrote: Dirty hack to allow inspection of sizes in lower units. A commandline option would suit better IMHO. If this is a one-shot task to find the sizes expressed with a different multiplier, then I don't understhand the env variable

Re: [PATCH 2/2] Btrfs: kill root from btrfs_is_free_space_inode

2012-07-17 Thread David Sterba
On Tue, Jul 10, 2012 at 07:28:39PM +0800, Liu Bo wrote: Since root can be fetched via BTRFS_I macro directly, we can save an args for btrfs_is_free_space_inode(). I see a great opportunity to rename the function :) It does not cover just the free space inode anymore and it'll be more confusing

Re: [PATCH] btrfs-progs: mkfs: rename nodiscard option to K

2012-07-17 Thread Tomasz Torcz
On Tue, Jul 17, 2012 at 11:14:17AM +0200, David Sterba wrote: The original patch named the option -T, mkfs.xfs uses -K let's keep it same. mkfs.ext2 used to have -K also, so one more +1 for this patch. -- Tomasz TorczOnly gods can safely risk perfection, xmpp:

[PATCH 0/2] Btrfs: remove unwanted kernel log output

2012-07-17 Thread Stefan Behrens
People complained about unwanted kernel log output at mount time, related to btrfs device I/O statistics. With these two commits, the two messages are removed or filtered, respectively. Stefan Behrens (2): Btrfs: remove unwanted printk() for btrfs device I/O stats Btrfs: suppress printk() if

[PATCH 2/2] Btrfs: suppress printk() if all device I/O stats are zero

2012-07-17 Thread Stefan Behrens
Code is added to suppress the I/O stats printing at mount time if all statistic values are zero. Signed-off-by: Stefan Behrens sbehr...@giantdisaster.de --- fs/btrfs/volumes.c | 8 1 file changed, 8 insertions(+) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index

[PATCH 1/2] Btrfs: remove unwanted printk() for btrfs device I/O stats

2012-07-17 Thread Stefan Behrens
People complained about the annoying kernel log message btrfs: no dev_stats entry found ... (OK on first mount after mkfs) everytime a filesystem is mounted for the first time after running mkfs. Since the distribution of the btrfs-progs is not synchronized to the kernel version, mkfs like it is

Re: [PATCH] Btrfs: add DEVICE_READY ioctl

2012-07-17 Thread Goffredo Baroncelli
On 07/17/2012 01:53 PM, David Sterba wrote: On Fri, Jun 22, 2012 at 08:12:52PM +0200, Goffredo Baroncelli wrote: On 06/21/2012 10:10 PM, Josef Bacik wrote: This will be used in conjunction with btrfs device ready dev. This is [] Finally I am starting to think that we should definitely

Re: [PATCH v1 00/15] Btrfs: subvolume quota groups (qgroups)

2012-07-17 Thread Alex Lyakas
Jan, I have studied to some extent the PDF and the code. I have some questions; perhaps you can address them? 1) btrfs_qgroup_account_ref() calling btrfs_find_all_roots(): I understand that bytenr indicates some EXTENT_ITEM, which is a back-reference for extent, which is perhaps a tree block

Re: [PATCH v1 00/15] Btrfs: subvolume quota groups (qgroups)

2012-07-17 Thread Arne Jansen
On 07/17/2012 08:33 PM, Alex Lyakas wrote: Jan, I have studied to some extent the PDF and the code. I have some questions; perhaps you can address them? 1) btrfs_qgroup_account_ref() calling btrfs_find_all_roots(): I understand that bytenr indicates some EXTENT_ITEM, which is a

Re: [PATCH v1 00/15] Btrfs: subvolume quota groups (qgroups)

2012-07-17 Thread Jan Schmidt
On 17.07.2012 21:25, Arne Jansen wrote: On 07/17/2012 08:33 PM, Alex Lyakas wrote: extent? Also, how do we encounter roots (which is what we need in the output) during this walking? Hope you can shed some light, or you can iirc the root backreferences itself, which is the criterion that we

Re: Unmountable btrfs filesystem

2012-07-17 Thread Providence M. SALUMU
Hi Kyle, I've just tried both of the options you've suggested, they all fail :-( btrfsch --repair /dev/sdb6 breaks with: btrfsck: btrfsck.c:1933: check_owner_ref: Assertion `!(rec-is_root)' I don't have more success with mount -t btrfs -o recovery command unfortunately. Here is the output I

Re: [PATCH 2/2] Btrfs: kill root from btrfs_is_free_space_inode

2012-07-17 Thread Liu Bo
On 07/17/2012 09:43 PM, David Sterba wrote: On Tue, Jul 10, 2012 at 07:28:39PM +0800, Liu Bo wrote: Since root can be fetched via BTRFS_I macro directly, we can save an args for btrfs_is_free_space_inode(). I see a great opportunity to rename the function :) It does not cover just the free