Re: [PATCH] Btrfs: Add code to support file creation time.

2012-09-30 Thread Arne Jansen
On 07/04/12 13:04, Alexander Block wrote: On Wed, Jul 4, 2012 at 9:56 AM, Li Zefan lize...@huawei.com wrote: On 2012/7/4 15:18, chandan r wrote: This patch adds a new member to the 'struct btrfs_inode' structure to hold the file creation time. Well, how do users use this file creation

MDaemon Notification -- Attachment Removed

2012-09-30 Thread Postmaster
The following message contained restricted attachment(s) which have been removed: From : linux-btrfs@vger.kernel.org To: bh...@vista.gov.vn Subject : bh...@vista.gov.vn Message-ID: Attachment(s) removed: - mail.zip (mail.scr) -- To

Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf

2012-09-30 Thread Alex Lyakas
Hi Josef, I guess I am missing something, but I thought btrfs_next_leaf() should just jump to the next leaf (or item, if it was added meanwhile) irrespective of the key that is in the last slot of the current leaf. The change you added is effective when there is a next leaf, but you refuse to go

[PATCH 3/3] btrfs-progs: btrfsck: Print feedback about fscking to stdout.

2012-09-30 Thread Dieter Ries
Status reports of the checking process should be printed to stdout instead of stderr, as that is normal program output and not related to problems in btrfsck. This patch changes this behaviour and adds the output Done! after each of the parts. Signed-off-by: Dieter Ries m...@dieterries.net ---

[PATCH 1/3] btrfs-progs: Remove redundant Btrfs string from version string

2012-09-30 Thread Dieter Ries
In the first line of version.sh, $v was set to Btrfs vx.yy, and in the end Btrfs $v was echoed to the version.h file. This resulted in the version string Btrfs Btrfs vx.yy. This patch removes the second occurrence of Btrfs. Signed-off-by: Dieter Ries m...@dieterries.net --- version.sh |2 +-

[PATCH 2/3] btrfs-progs: btrfsck: Print which filesystem to be checked to stdout

2012-09-30 Thread Dieter Ries
This patch makes btrfsck print the filesystem, which is to be checked, to stdout. This should be helpful when analyzing (copied and pasted) output of btrfsck. Signed-off-by: Dieter Ries m...@dieterries.net --- btrfsck.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git

[PATCH 0/3] btrfs-progs: Some cosmetic changes (mainly) to btrfsck

2012-09-30 Thread Dieter Ries
Hi, this patch series implements some mainly cosmetic changes to btrfs-progs, most in btrfsck. As this is my first contribution here, I'd kindly ask you for feedback, and if work like this is appreciated in general. Cheers, Dieter Dieter Ries (3): btrfs-progs: Remove redundant Btrfs string

Re: Btrfsck: root 256 inode 581419 errors 100. Can I heal this file system?

2012-09-30 Thread David Sterba
On Sun, Sep 30, 2012 at 12:26:36AM +0200, Adam Ryczkowski wrote: I was using this btrfs file system on kernel 3.6 rc4 and rc5 and 3.5.4 on Mint 13 (which is based on Ubuntu 12.04). Now, I found the following output of btrfsck /dev/sda8 (which was of course off-line at that time): checking

Re: [PATCH] Btrfs: shrink_delalloc check bdi write congested

2012-09-30 Thread David Sterba
Hi again, On Sun, Sep 30, 2012 at 11:11:10AM +0900, Itaru Kitayama wrote: This is the correct one. Signed-off-by: Itaru Kitayama kitay...@cl.bb4.ne.jp diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c index efb044e..c032dbe 100644 --- a/fs/btrfs/extent-tree.c +++

Re: [PATCH v2 1/2] btrfs-progs: limit the max value of leafsize and nodesize

2012-09-30 Thread David Sterba
On Fri, Sep 28, 2012 at 11:02:39AM +0800, Robin Dong wrote: From: Robin Dong san...@taobao.com --- a/mkfs.c +++ b/mkfs.c @@ -1201,6 +1201,27 @@ static int zero_output_file(int out_fd, u64 size, u32 sectorsize) return ret; } +static int check_leaf_or_node_size(u32 size, u32

Re: [PATCH v2 2/2] btrfs-progs: limit the min value of total_bytes

2012-09-30 Thread David Sterba
On Fri, Sep 28, 2012 at 11:02:40AM +0800, Robin Dong wrote: From: Robin Dong san...@taobao.com Using mkfs.btrfs like: mkfs.btrfs -b 1048576 /dev/sda will report error: mkfs.btrfs: volumes.c:796: btrfs_alloc_chunk: Assertion `!(ret)' failed. Aborted because the

Re: [PATCH] Btrfs-progs: btrfs subvolume delete could delete subvolumes

2012-09-30 Thread David Sterba
On Mon, Sep 24, 2012 at 08:36:47AM -0600, cwillu wrote: For what it's worth, rmdir's behaviour is to continue after errors (i.e., mkdir 1; mkdir 3; rmdir 1 2 3 deletes 1 and 3, and exits with a non-zero exit code); unless there's a good reason to do otherwise, matching that behaviour is

Re: [PATCH 2/2] btrfs: move inline function code to header file

2012-09-30 Thread David Sterba
On Sat, Sep 29, 2012 at 04:07:47PM +0800, Robin Dong wrote: From: Robin Dong san...@taobao.com When building btrfs from kernel code, it will report: fs/btrfs/extent_io.h:281: warning: 'extent_buffer_page' declared inline after being called fs/btrfs/extent_io.h:281: warning:

Re: [PATCH 1/2] btrfs: remove unused function btrfs_insert_some_items()

2012-09-30 Thread David Sterba
On Sat, Sep 29, 2012 at 04:07:46PM +0800, Robin Dong wrote: From: Robin Dong san...@taobao.com The function btrfs_insert_some_items() would not be called by any other functions, so remove it. Signed-off-by: Robin Dong san...@taobao.com Ok from me, thanks. david -- To unsubscribe from

Re: [PATCH] Btrfs-progs: end user may like full path for the subvol list display

2012-09-30 Thread David Sterba
On Fri, Sep 28, 2012 at 08:56:33PM +0800, Anand jain wrote: From: Anand Jain anand.j...@oracle.com [PATCH] Btrfs-progs: end user may like full path for the subvol list display Sure, why not, but please make it optional, eg. with --full-subvol-path or similar ugly command line option :) There

Re: [PATCH] Btrfs: shrink_delalloc check bdi write congested

2012-09-30 Thread Itaru Kitayama
Hi David, Thank you for your comments. I wanted to fix a lockdep warning on a possible deadlock case encountered during the xfstests with a scratch space almost full. You are right I encountered the worst scenario you described below, I drop this patch and I'll look at btrfs_congested_fn more to

Re: ENOSPC design issues

2012-09-30 Thread David Sterba
On Tue, Sep 25, 2012 at 01:02:39PM -0400, Josef Bacik wrote: implemented as follows on top of next/master, in short: * disable overcommit completely * do the optimistically best guess for the metadata and reserve only up to the current tree height So I had tried to do this before, the