Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf

2012-10-02 Thread Alex Lyakas
Hi Josef, thanks for clarifying. By wants to walk forward based on a particular item you mean - find all items that have the same objectid, until objectid changes? I wrote some code once (for educational purposes) that just walked the tree irrespective of a particular objectid, so that's why I was

[GIT PULL] btrfs-progs: Handful of fixes for 0.20-rc1

2012-10-02 Thread David Sterba
Hi Chris, please pull a few fixes to the 0.20-rc series, these are easy to review and fix problems that people reported. There are more fixes in the mailinglist, but they do not IMHO fit current -rc period, the crowd is waiting for 0.20. git://repo.or.cz/btrfs-progs-unstable/devel.git

[Btrfs-next] bulid failure at fs/btrfs/ctree.h

2012-10-02 Thread Gordon Ng
Hello Josef, FYI build failure occured in fs/btrfs/ctree.h. CC fs/btrfs/super.o In file included from fs/btrfs/delayed-inode.h:30:0, from fs/btrfs/super.c:45: fs/btrfs/ctree.h:3235:1: error: expected identifier or ‘(’ before ‘’ token make[3]: *** [fs/btrfs/super.o] Error 1

Re: [Btrfs-next] bulid failure at fs/btrfs/ctree.h

2012-10-02 Thread Josef Bacik
On Tue, Oct 02, 2012 at 06:50:26AM -0600, Gordon Ng wrote: Hello Josef, FYI build failure occured in fs/btrfs/ctree.h. CC fs/btrfs/super.o In file included from fs/btrfs/delayed-inode.h:30:0, from fs/btrfs/super.c:45: fs/btrfs/ctree.h:3235:1: error: expected

Re: [Btrfs-next] bulid failure at fs/btrfs/ctree.h

2012-10-02 Thread David Sterba
On Tue, Oct 02, 2012 at 10:50:26PM +1000, Gordon Ng wrote: Hello Josef, FYI build failure occured in fs/btrfs/ctree.h. CC fs/btrfs/super.o In file included from fs/btrfs/delayed-inode.h:30:0, from fs/btrfs/super.c:45: fs/btrfs/ctree.h:3235:1: error: expected

Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf

2012-10-02 Thread David Sterba
Hi, On Mon, Sep 24, 2012 at 04:02:59PM -0400, Josef Bacik wrote: --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -571,6 +571,7 @@ struct btrfs_path { unsigned int skip_locking:1; unsigned int leave_spinning:1; unsigned int search_commit_root:1; + unsigned int

Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf

2012-10-02 Thread Josef Bacik
On Tue, Oct 02, 2012 at 08:25:38AM -0600, David Sterba wrote: Hi, On Mon, Sep 24, 2012 at 04:02:59PM -0400, Josef Bacik wrote: --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -571,6 +571,7 @@ struct btrfs_path { unsigned int skip_locking:1; unsigned int leave_spinning:1;

Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf

2012-10-02 Thread David Sterba
On Tue, Oct 02, 2012 at 10:32:32AM -0400, Josef Bacik wrote: On Tue, Oct 02, 2012 at 08:25:38AM -0600, David Sterba wrote: Hi, On Mon, Sep 24, 2012 at 04:02:59PM -0400, Josef Bacik wrote: --- a/fs/btrfs/ctree.h +++ b/fs/btrfs/ctree.h @@ -571,6 +571,7 @@ struct btrfs_path {

[PATCH] Btrfs: Remove orphaned comment.

2012-10-02 Thread Mitch Harder
Remove a comment that was orphaned by a previous commit which removed the function associated with the comment. See commit efd049fb26a162c3830fd3cb1001fdc09b147f3b This left the comment in a confusing context that seemed to be associated with another function. Signed-off-by: Mitch Harder

Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf

2012-10-02 Thread Josef Bacik
On Tue, Oct 02, 2012 at 09:05:43AM -0600, David Sterba wrote: On Tue, Oct 02, 2012 at 10:32:32AM -0400, Josef Bacik wrote: On Tue, Oct 02, 2012 at 08:25:38AM -0600, David Sterba wrote: Hi, On Mon, Sep 24, 2012 at 04:02:59PM -0400, Josef Bacik wrote: --- a/fs/btrfs/ctree.h +++

Re: [PATCH] Btrfs: try to avoid doing a search in btrfs_next_leaf

2012-10-02 Thread Arne Jansen
On 02.10.2012 17:27, Josef Bacik wrote: On Tue, Oct 02, 2012 at 09:05:43AM -0600, David Sterba wrote: On Tue, Oct 02, 2012 at 10:32:32AM -0400, Josef Bacik wrote: On Tue, Oct 02, 2012 at 08:25:38AM -0600, David Sterba wrote: Hi, On Mon, Sep 24, 2012 at 04:02:59PM -0400, Josef Bacik wrote:

[PATCH][BTRFS-PROGS] btrfs filesystem disk-usage

2012-10-02 Thread Goffredo Baroncelli
Hi all, This serie of patches adds a new command called btrfs filesystem disk-usage. I added this command because it is not so easy to get the information about the disk usage from the command fi df and fi show. From the man page (see 2nd patch): [...] The command btrfs filesystem

[PATCH 1/2] Add btrfs filesystem disk-usage command

2012-10-02 Thread Goffredo Baroncelli
From: Goffredo Baroncelli kreij...@inwind.it The command btrfs filesystem disk-usage is used to query the status of the chunks, how many space on the disk(s) are used by the chunks, how many space are available in the chunks, and an estimation of the free space of the filesystem. ---

[PATCH 2/2] Update help page

2012-10-02 Thread Goffredo Baroncelli
From: Goffredo Baroncelli kreij...@inwind.it --- man/btrfs.8.in | 94 1 file changed, 94 insertions(+) diff --git a/man/btrfs.8.in b/man/btrfs.8.in index 4b0a9f9..3215216 100644 --- a/man/btrfs.8.in +++ b/man/btrfs.8.in @@ -27,6 +27,8

Re: [e2fsprogs] ext2_dir_entry To ext2_dir_entry_2 Casting

2012-10-02 Thread Theodore Ts'o
On Tue, Oct 02, 2012 at 12:02:22PM -0700, Wade Cline wrote: Hello Theodore Ts'o, Is there a function similar to ext2fs_dir_iterate2() that will call a hook function on an ext2_dir_entry_2 structure and not an ext2_dir_entry structure? The reason I ask is because btrfs-convert currently

Re: [PATCH][BTRFS-PROGS] btrfs filesystem disk-usage

2012-10-02 Thread Chris Mason
On Tue, Oct 02, 2012 at 12:36:08PM -0600, Goffredo Baroncelli wrote: Hi all, This serie of patches adds a new command called btrfs filesystem disk-usage. I added this command because it is not so easy to get the information about the disk usage from the command fi df and fi show. From the

Re: [GIT PULL] btrfs-progs: Handful of fixes for 0.20-rc1

2012-10-02 Thread Chris Mason
On Tue, Oct 02, 2012 at 05:27:07AM -0600, David Sterba wrote: Hi Chris, please pull a few fixes to the 0.20-rc series, these are easy to review and fix problems that people reported. There are more fixes in the mailinglist, but they do not IMHO fit current -rc period, the crowd is waiting

Re: [PATCH V4 0/7 ] Btrfs-progs: enhance btrfs subvol list only to show read-only snapshots

2012-10-02 Thread Chris Mason
On Tue, Sep 18, 2012 at 04:35:25AM -0600, Miao Xie wrote: We want 'btrfs subvolume list' only to list readonly subvolumes, this patch set introduces a new option 'r' to implement it. You can use the command like that: btrfs subvolume list -r mnt Changelog v3 - v4: - modify the

Re: [RFC][PATCH] Btrfs-progs, btrfsck: add block group check function

2012-10-02 Thread Chris Mason
On Thu, Aug 02, 2012 at 04:14:37AM -0600, Miao Xie wrote: From: Chen Yang chenyang.f...@cn.fujitsu.com This patch adds the function to check correspondence between block group, chunk and device extent. Excellent, thank you. Could you please put this into a git tree? I'm having trouble with

Re: [RFC] [PATCH] Btrfs: rework can_nocow_odirect

2012-10-02 Thread Wade Cline
Hi Josef, This patch is causing fragmentation with O_DIRECT on preallocated extents located -after- the first write to the preallocated extent. This happens regardless of nodatacow/autodefrag mount options. Thank you, Wade On 10/01/2012 12:00 PM, Josef Bacik wrote: I need everybody to go