[PATCH] Btrfs: make delayed ref lock logic more readable

2012-12-19 Thread Miao Xie
Locking and unlocking delayed ref mutex are in the different functions, and the name of lock functions is not uniform, so the readability is not so good, this patch optimizes the lock logic and makes it more readable. Signed-off-by: Miao Xie mi...@cn.fujitsu.com --- fs/btrfs/delayed-ref.c | 8

Re: Feeback on RAID1 feature of Btrfs

2012-12-19 Thread C Anthony Risinger
On Tue, Dec 18, 2012 at 6:13 AM, Hugo Mills h...@carfax.org.uk wrote: On Tue, Dec 18, 2012 at 01:20:20PM +0200, Brendan Hide wrote: On 2012/12/17 06:23 PM, Hugo Mills wrote: On Mon, Dec 17, 2012 at 04:51:33PM +0100, Sebastien Luttringer wrote: Hello, snip I get the feeling that RAID1 only

About btrfs qgroup import/export command

2012-12-19 Thread Miao Xie
Hi, everyone. As we know, there is no backup function for qgroup. when the problem occurs, the users must recover qgroup configuration manually, it is not convenient. And besides that, some users might want to import an existed qgroup configuration into a new filesystem. Btrfs does not have such

Re: About btrfs qgroup import/export command

2012-12-19 Thread Arne Jansen
On 19.12.2012 12:25, Miao Xie wrote: Hi, everyone. As we know, there is no backup function for qgroup. when the problem occurs, the users must recover qgroup configuration manually, it is not convenient. And besides that, some users might want to import an existed qgroup configuration into

Re: BTree lock contention

2012-12-19 Thread David Sterba
On Tue, Dec 18, 2012 at 07:57:23PM +0530, Atri Sharma wrote: I am pretty weak with Mediawiki. Is there any way somebody could please place my name 'Atri Sharma' for the Btree locking contention in the wiki? Done. We're using templates for the project descriptions, and clicking 'edit' leads to

Re: [RFC PATCH V6 2/2] Btrfs: Add a new ioctl to change the label of a mounted file system

2012-12-19 Thread David Sterba
On Tue, Dec 18, 2012 at 11:06:07AM +0800, Jeff Liu wrote: +static int btrfs_ioctl_set_fslabel(struct file *file, void __user *arg) +{ + struct btrfs_root *root = BTRFS_I(fdentry(file)-d_inode)-root; + struct btrfs_super_block *super_block = root-fs_info-super_copy; + struct

Re: BTree lock contention

2012-12-19 Thread David Sterba
On Wed, Dec 19, 2012 at 08:34:08PM +0530, Atri Sharma wrote: Sorry for bothering again, but I cant see Btree Lock contention marked as in progress or my name anywhere on https://btrfs.wiki.kernel.org/index.php/Project_ideas Could you please check? I don't know what happened to the edit, but

HIT WARN_ON WARNING: at fs/btrfs/extent-tree.c:6339 btrfs_alloc_free_block+0x126/0x330 [btrfs]()

2012-12-19 Thread Rock Lee
Hi all, Did someone have met this problem before. When doing the tests, I hit the WARN_ON. Is this log make sense or someone had fixed the problem. If needed, I can supply the detail log and the testcase source file. Version: the latest codes at linus git tree. [ 2140.981293]

Re: HIT WARN_ON WARNING: at fs/btrfs/extent-tree.c:6339 btrfs_alloc_free_block+0x126/0x330 [btrfs]()

2012-12-19 Thread cwillu
On Wed, Dec 19, 2012 at 9:12 AM, Rock Lee zim...@code-trick.com wrote: Hi all, Did someone have met this problem before. When doing the tests, I hit the WARN_ON. Is this log make sense or someone had fixed the problem. If needed, I can supply the detail log and the testcase source

Re: HIT WARN_ON WARNING: at fs/btrfs/extent-tree.c:6339 btrfs_alloc_free_block+0x126/0x330 [btrfs]()

2012-12-19 Thread Josef Bacik
On Wed, Dec 19, 2012 at 08:12:01AM -0700, Rock Lee wrote: Hi all, Did someone have met this problem before. When doing the tests, I hit the WARN_ON. Is this log make sense or someone had fixed the problem. If needed, I can supply the detail log and the testcase source file.

Re: HIT WARN_ON WARNING: at fs/btrfs/extent-tree.c:6339 btrfs_alloc_free_block+0x126/0x330 [btrfs]()

2012-12-19 Thread Rock Lee
Hi, I just try to write the testcase a few hours before. So there will be some problems. Maybe you can ignore the unimplemented and the ugly parts. Welcome any feedback. :) I have uploaded the test source file to Github. Please open this link:

Re: Bug: trying to create reflink on different device results in empty file

2012-12-19 Thread David Sterba
On Tue, Dec 11, 2012 at 11:16:03PM +0100, Koen De Wit wrote: When trying to create a clone (reflink) of a file on a different device, you'll get this error: Invalid cross-device link However, an empty file is created on the target location. An invalid clone operation should not result

Re: BUG during log recovery

2012-12-19 Thread David Sterba
On Tue, Dec 18, 2012 at 03:10:24PM +0100, Jan Steffens wrote: if (!caching_ctl) { BUG_ON(!block_group_cache_done(block_group)); ret = btrfs_remove_free_space(block_group, start, num_bytes); BUG_ON(ret); /* -ENOMEM */ // 6185 The actual

Re: Online Deduplication for Btrfs (Master's thesis)

2012-12-19 Thread Martin Křížek
On Mon, Dec 17, 2012 at 2:33 PM, Alexander Block abloc...@gmail.com wrote: I did some research on deduplication in the past and there are some problems that you will face. I'll try to list some of them (for sure not all). On Mon, Dec 17, 2012 at 1:05 PM, Martin Křížek martin.kri...@gmail.com

Re: [GIT PULL] Btrfs updates

2012-12-19 Thread Roy Sigurd Karlsbakk
[ sorry, resend. My lbdb autocompleted with an extra r in kernel.org ] Hi everyone, My for-linus branch has a big set of fixes and features: Does this include raid-[56]? Vennlige hilsener / Best regards roy -- Roy Sigurd Karlsbakk (+47) 98013356 r...@karlsbakk.net

Re: [GIT PULL] Btrfs updates

2012-12-19 Thread Hugo Mills
On Wed, Dec 19, 2012 at 07:09:57PM +0100, Roy Sigurd Karlsbakk wrote: [ sorry, resend. My lbdb autocompleted with an extra r in kernel.org ] Hi everyone, My for-linus branch has a big set of fixes and features: Does this include raid-[56]? As Chris's last sentence in that mail

Re: [PATCH] Btrfs: don't bother updating the inode when evicting

2012-12-19 Thread Miao Xie
On wed, 19 Dec 2012 10:02:59 -0500, Josef Bacik wrote: On Tue, Dec 18, 2012 at 06:58:33PM -0700, Miao Xie wrote: On tue, 18 Dec 2012 15:51:57 -0500, Josef Bacik wrote: We're deleting the stupid thing, no sense in updating the inode for the new size. We're running into having 50-100

Re: About btrfs qgroup import/export command

2012-12-19 Thread Miao Xie
On Wed, 19 Dec 2012 12:40:25 +0100, Arne Jansen wrote: On 19.12.2012 12:25, Miao Xie wrote: Hi, everyone. As we know, there is no backup function for qgroup. when the problem occurs, the users must recover qgroup configuration manually, it is not convenient. And besides that, some users

btrfs warning in 3.7.0 with nfsd

2012-12-19 Thread Steve Leung
I'm getting some kernel warnings from a btrfs raid1 filesystem that's serving up nfs4 to a couple of other computers on a small home network. I ran 3.6.x for several weeks before upgrading and didn't see any warnings like this. [ 1712.223791] WARNING: at fs/btrfs/tree-log.c:3716