Re: About btrfs qgroup import/export command

2013-01-09 Thread Miao Xie
Hi, Arne On Wed, 19 Dec 2012 12:40:25 +0100, Arne Jansen wrote: On 19.12.2012 12:25, Miao Xie wrote: As we know, there is no backup function for qgroup. when the problem occurs, the users must recover qgroup configuration manually, it is not convenient. And besides that, some users might want

[PATCH] btrfs-progs: remove '-h' from btrfs man page

2013-01-09 Thread Simon Xu
Remove '-h' from btrfs man page as it's not supported by the btrfs utility. --- man/btrfs.8.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/man/btrfs.8.in b/man/btrfs.8.in index 9222580..bf3ea13 100644 --- a/man/btrfs.8.in +++ b/man/btrfs.8.in @@ -52,7 +52,7 @@ btrfs \-

Re: btrfsck: extent-tree.c:2549: btrfs_reserve_extent: Assertion `!(ret)' failed.

2013-01-09 Thread Richard Cooper
On 3 Jan 2013, at 16:43, Richard Cooper wrote: On 3 Jan 2013, at 15:06, Josef Bacik wrote: On Thu, Jan 03, 2013 at 05:26:38AM -0700, Richard Cooper wrote: Hi All, I'm trying to repair a broken fs using btrfsck and am hitting a failed assertion. I'd appreciate any suggestions for what

Re: [PATCH 3/4] Btrfs: remove unnecessary cur_trans set before goto loop in join_transaction

2013-01-09 Thread Jiri Kosina
On Mon, 24 Sep 2012, Wang Sheng-Hui wrote: In the big loop, cur_trans will be set fs_info-running_transaction before it's used. And after kmem_cache_free it and goto loop, it will be setup again. No need to setup it immediately after freed. Signed-off-by: Wang Sheng-Hui shh...@gmail.com

Re: [PATCH] Btrfs: fix off-by-one in lseek

2013-01-09 Thread David Sterba
On Wed, Jan 09, 2013 at 12:34:45PM +0800, Liu Bo wrote: [20191.948060] D: __set_extent_bit isize = 0 odd range [774144,7384799041917984768) [20191.956581] D: clear_extent_bit isize = 0 odd range [774144,7384799041917984768) so I'm not sending it as a separate patch yet until the

Re: About btrfs qgroup import/export command

2013-01-09 Thread Arne Jansen
On 09.01.2013 11:17, Miao Xie wrote: Hi, Arne On Wed, 19 Dec 2012 12:40:25 +0100, Arne Jansen wrote: On 19.12.2012 12:25, Miao Xie wrote: As we know, there is no backup function for qgroup. when the problem occurs, the users must recover qgroup configuration manually, it is not convenient.

Re: [PATCH] Btrfs: fix off-by-one in lseek

2013-01-09 Thread David Sterba
On Wed, Jan 09, 2013 at 12:50:25PM +0100, David Sterba wrote: I've added only the 2 fixes from you, no other change. I'll do another test based on current btrfs-next. reproduced on linus/master + btrfs-next + debugging patch + your fixes with test 068 [ 1285.152973] [ cut here

[PATCH 0/2] send: Avoid sending disknr==0 and PREALLOC extents when possible

2013-01-09 Thread Alex Lyakas
These two patches address the issue of sending unneeded zero data for disknr==0 and PREALLOC extents. There is room for additional improvement for PREALLOC extents, but it requires adding a new command, so for now this is not addressed. Please review and comment. Thanks, Alex. Alex Lyakas (2):

[PATCH 1/2] Avoid sending disknr==0 extents when possible

2013-01-09 Thread Alex Lyakas
Subject: [PATCH 1/2] Avoid sending disknr==0 extents in the following cases: 1) full send 2) new inode in a diff-send 3) when disknr==0 extents are added to the end of an inode Original-version-by: Chen Yang chenyang.f...@cn.fujitsu.com Signed-off-by: Alex Lyakas alex.bt...@zadarastorage.com

[PATCH 2/2] On a diff-send, avoid sending PREALLOC extent

2013-01-09 Thread Alex Lyakas
Subject: [PATCH 2/2] On a diff-send, avoid sending PREALLOC extents, if the parent root has only PREALLOC extents on an appropriate file range. This does not fully avoids sending PREALLOC extents, because on full-send or new inode we need a new send command to do that. But this patch improves

Re: Btrfs: wipe all the superblock [redhat bugzilla 889888]

2013-01-09 Thread Karel Zak
On Wed, Jan 09, 2013 at 06:48:28PM +0100, Goffredo Baroncelli wrote: Hi Karel, You can specify more than one magic strings for the same filesystem, the .magics = { } is array. thanks for you suggestion. However this seems to me not applicable. I tried to change the code, and what I

[PATCH][v2] Btrfs: wipe all the superblock [redhat bugzilla 889888]

2013-01-09 Thread Goffredo Baroncelli
Hi all, Currently wipefs doesn't clear all the superblock of btrfs. Only the first one is cleared. Btrfs has three superblocks. The first one is placed at 64KB, the second one at 64MB, the third one at 256GB. If the first superblock is valid except that the magic field is zeroed, btrfs skips

Re: [PATCH 1/2] Btrfs: add leak debug for extent map

2013-01-09 Thread Liu Bo
On Tue, Jan 08, 2013 at 12:07:34PM -0800, Zach Brown wrote: This is for detecting extent map leak. Hmm, I guess it's cool to get the allocation-specific decoding which you don't get from the generic kernel leak tracking? Hi Zach, Thanks for the advice, but what allocation-specific decoding

Re: [PATCH] Btrfs: fix off-by-one in lseek

2013-01-09 Thread Liu Bo
On Wed, Jan 09, 2013 at 12:50:25PM +0100, David Sterba wrote: On Wed, Jan 09, 2013 at 12:34:45PM +0800, Liu Bo wrote: [20191.948060] D: __set_extent_bit isize = 0 odd range [774144,7384799041917984768) [20191.956581] D: clear_extent_bit isize = 0 odd range

Re: [PATCH RESEND] vfs: re-implement writeback_inodes_sb(_nr)_if_idle() and rename them

2013-01-09 Thread Miao Xie
On Fri, 28 Dec 2012 15:33:38 +0100, David Sterba wrote: On Thu, Dec 20, 2012 at 06:09:35PM +0800, Miao Xie wrote: --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -1314,7 +1314,6 @@ void writeback_inodes_sb_nr(struct super_block *sb, bdi_queue_work(sb-s_bdi, work);

[PATCH V3] Btrfs: flush all dirty inodes if writeback can not start

2013-01-09 Thread Miao Xie
We may try to flush some dirty pages when there is no enough space to reserve. But it is possible that this operation fails, in order to get enough space to reserve successfully, we will sync all the delalloc file. This operation is safe, we needn't worry about the case that the filesystem goes

Re: Btrfs fs not mounting or being identified after power loss.

2013-01-09 Thread Randy Barlow
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/08/2013 10:46 PM, Jordan Windsor wrote: kernel is at 3.6.11-1-ARCH Sorry I don't know much to help you, but I would suggest perhaps using a newer kernel in the future. It sounds like your FS might be in trouble as is, but I would recommend

[PATCH V2] vfs: re-implement writeback_inodes_sb(_nr)_if_idle() and rename them

2013-01-09 Thread Miao Xie
writeback_inodes_sb(_nr)_if_idle() is re-implemented by replacing down_read() with down_read_trylock() because - If -s_umount is write locked, then the sb is not idle. That is writeback_inodes_sb(_nr)_if_idle() needn't wait for the lock. - writeback_inodes_sb(_nr)_if_idle() grabs s_umount lock