Re: btrfs zero divide

2013-08-13 Thread Geert Uytterhoeven
On Fri, Aug 9, 2013 at 2:30 PM, Andreas Schwab sch...@linux-m68k.org wrote: Andreas Schwab sch...@linux-m68k.org writes: Josef Bacik jba...@fusionio.com writes: So stripe_len shouldn't be 0, if it is you have bigger problems :). [ lost context: this is about the first do_div() in

Re: Kernel BUG on Snapshot Deletion (3.11.0-rc5)

2013-08-13 Thread Josef Bacik
On Mon, Aug 12, 2013 at 11:06:27PM -0500, Mitch Harder wrote: I'm hitting a btrfs Kernel BUG running a snapshot stress script with linux-3.11.0-rc5. I can haz script? Thanks, Josef -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to

Re: btrfs-ino-cache is running on each reboot

2013-08-13 Thread Josef Bacik
On Tue, Aug 13, 2013 at 10:28:59AM +0900, dima wrote: Hello all, About a week or so ago I noticed that [btrfs-ino-cache] process was appearing in the 'top' on each reboot and disk is spinning like crazy for about five minutes or so. Quite so often this caused X failing to start because all

Re: [PATCH] _test_generic_punch: Extend $testfile's size to work with 64k block.

2013-08-13 Thread chandan
Hello Dave, So, to do this properly, I'd suggest that the code needs to scale the offset/size of the IO being done by the filesystem block size, not use a fixed size. Using a filter on the bmap output to handle the different block ranges will ensure everything works correctly from a golden

Re: Kernel BUG on Snapshot Deletion (3.11.0-rc5)

2013-08-13 Thread Mitch Harder
Let me work on making that script more portable, and hopefully quicker to reproduce. On Tue, Aug 13, 2013 at 9:15 AM, Josef Bacik jba...@fusionio.com wrote: On Mon, Aug 12, 2013 at 11:06:27PM -0500, Mitch Harder wrote: I'm hitting a btrfs Kernel BUG running a snapshot stress script with

Re: [PATCH v3 1/2] xfstests: add fssum tool

2013-08-13 Thread Eric Sandeen
On 8/13/13 10:28 AM, Josef Bacik wrote: On Sun, Aug 11, 2013 at 09:54:41PM -0500, Eric Sandeen wrote: On Aug 11, 2013, at 8:15 PM, Dave Chinner da...@fromorbit.com wrote: On Thu, Aug 08, 2013 at 12:40:55PM -0500, Eric Sandeen wrote: On 8/8/13 3:17 AM, Jan Schmidt wrote: SUBDIRS = LLDLIBS =

Re: btrfs zero divide

2013-08-13 Thread Geert Uytterhoeven
On Fri, 9 Aug 2013, Zach Brown wrote: On Fri, Aug 09, 2013 at 02:26:36PM +0200, Andreas Schwab wrote: Josef Bacik jba...@fusionio.com writes: So stripe_len shouldn't be 0, if it is you have bigger problems :). The bigger problem is that stripe_nr is u64, this is completely bogus.

[PATCH v4 2/2] xfstests btrfs/316: test send / receive

2013-08-13 Thread Jan Schmidt
Basic send / receive functionality test for btrfs. Requires current version of fsstress built (-x support). Relies on fssum tool but can skip the test if it failed to build. Signed-off-by: Jan Schmidt list@jan-o-sch.net Reviewed-by: Josef Bacik jba...@fusionio.com --- tests/btrfs/316 |

[PATCH v4 0/2] xfstest btrfs/316: test send / receive

2013-08-13 Thread Jan Schmidt
These two patches add the announced tests for btrfs send / receive. As requested, the fssum tool is now included. -- v1-v2: - included fssum - test number is now 316 (was 314) v2-v3: - added missing -lcrypto to build fssum - removed obsolete change in README now that fssum is included -

[PATCH] Btrfs: fix the error handling wrt orphan items

2013-08-13 Thread Josef Bacik
There are several places where we BUG_ON() if we fail to remove the orphan items and such, which is not ok, so remove those and either abort or just carry on. This also fixes a problem where if we couldn't start a transaction we wouldn't actually remove the orphan item reserve for the inode.

Re: [PATCH v4 0/2] xfstest btrfs/316: test send / receive

2013-08-13 Thread Eric Sandeen
On 8/13/13 12:24 PM, Jan Schmidt wrote: These two patches add the announced tests for btrfs send / receive. As requested, the fssum tool is now included. Thanks for the updates. Both: Reviewed-by: Eric Sandeen sand...@redhat.com -- v1-v2: - included fssum - test number is now 316 (was

[PATCH] xfstests: btrfs/003: regression test for subvol delete V2

2013-08-13 Thread Josef Bacik
We were allowing users to delete their default subvolume, which is problematic. This test is a regression test to make sure we don't let that happen in the future. Thanks, Signed-off-by: Josef Bacik jba...@fusionio.com --- V1-V2: address the comments made by Eric Sandeen. tests/btrfs/003 |

Re: [PROGS PATCH] Import btrfs-extent-same

2013-08-13 Thread Mark Fasheh
Hey Dave, On Tue, Aug 06, 2013 at 05:31:12PM +0200, David Sterba wrote: On Thu, Jun 27, 2013 at 12:38:19AM +0200, Gabriel de Perthuis wrote: Originally from https://github.com/markfasheh/duperemove/blob/master/btrfs-extent-same.c Can you (or Mark) please turn it into a subcommand of

Re: [PATCH] xfstests: btrfs/003: regression test for subvol delete V2

2013-08-13 Thread Eric Sandeen
On 8/13/13 2:34 PM, Josef Bacik wrote: We were allowing users to delete their default subvolume, which is problematic. This test is a regression test to make sure we don't let that happen in the future. Thanks, Signed-off-by: Josef Bacik jba...@fusionio.com --- V1-V2: address the

Re: [PATCH v4 0/2] xfstest btrfs/316: test send / receive

2013-08-13 Thread Rich Johnston
On 08/13/2013 01:33 PM, Eric Sandeen wrote: On 8/13/13 12:24 PM, Jan Schmidt wrote: These two patches add the announced tests for btrfs send / receive. As requested, the fssum tool is now included. Thanks for the updates. Both: Reviewed-by: Eric Sandeen sand...@redhat.com Thanks Jan, this

[PATCH v2 1/3] Btrfs: fix oops when writing dirty qgroups to disk

2013-08-13 Thread Wang Shilong
When disabling quota, we should clear out list 'dirty_qgroups',otherwise, we will get oops if enabling quota again. Fix this by abstracting similar code from del_qgroup_rb(). Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Reviewed-by: Miao Xie mi...@cn.fujitsu.com Reviewed-by: Arne Jansen

[PATCH v2 3/3] Btrfs: remove reduplicate check when disabling quota

2013-08-13 Thread Wang Shilong
We have checked 'quota_root' with qgroup_ioctl_lock held before,So here the check is reduplicate, remove it. Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Reviewed-by: Miao Xie mi...@cn.fujitsu.com Reviewed-by: Arne Jansen sensi...@gmx.net --- v1-v2: nothing(except adding Arne's

Re: [PATCH 4/6] btrfs-progs: mkfs.c overwrites fd without appropriate close

2013-08-13 Thread Anand Jain
On 08/14/2013 03:14 AM, Josef Bacik wrote: On Fri, Jul 26, 2013 at 01:35:28AM +0800, Anand Jain wrote: Signed-off-by: Anand Jain anand.j...@oracle.com --- mkfs.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/mkfs.c b/mkfs.c index 60f906c..66f558a 100644 ---

[PATCH 0/2] BTRFS_IOC_INO_LOOKUP ioctl fixes

2013-08-13 Thread Filipe David Borba Manana
This set of patches fixes 2 issues with the BTRFS_IOC_INO_LOOKUP ioctl: 1) missing error code return when path is too long; 2) ocassional ENOENT error even when the desired inode ref items exist. Filipe David Borba Manana (2): Btrfs: add missing error code to BTRFS_IOC_INO_LOOKUP handler

Re: [PATCH 4/6] btrfs-progs: mkfs.c overwrites fd without appropriate close

2013-08-13 Thread Anand Jain
On 08/14/2013 10:04 AM, Anand Jain wrote: On 08/14/2013 03:14 AM, Josef Bacik wrote: On Fri, Jul 26, 2013 at 01:35:28AM +0800, Anand Jain wrote: Signed-off-by: Anand Jain anand.j...@oracle.com --- mkfs.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/mkfs.c

[PATCH v3 1/8] Btrfs-progs: add missing man page information for btrfsck

2013-08-13 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- v2-v3: availiable parts is not true anymore,remove it. v1-v2: remove wrong copyrights. --- man/btrfsck.8.in | 35 --- 1 file changed, 24 insertions(+), 11

[PATCH] btrfs-progs: Fix: mkfs.c overwrites fd without appropriate close patch

2013-08-13 Thread Anand Jain
btrfs_add_to_fsid() saves the fd in the device list. close_ctree() will retrive the device list to handle the close(). So the device fd shouldn't closed here. Signed-off-by: Anand Jain anand.j...@oracle.com --- mkfs.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git

[PATCH v3 5/8] Btrfs-progs: add man page information for btrfs-convert

2013-08-13 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- v2-v3: remove 'AVAILIABLE' parts. v1-v2: GPLv3-GPLv2 --- man/Makefile | 3 ++- man/btrfs-convert.8.in | 33 + 2 files changed, 35 insertions(+), 1

[PATCH v3 7/8] Btrfs-progs: add missing man page information for btrfs-zero-log

2013-08-13 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- v2-v3: remove 'AVAILIABLE' parts. v1-v2: GPLv3-GPLv2 --- man/Makefile| 2 +- man/btrfs-zero-log.8.in | 23 +++ 2 files changed, 24 insertions(+), 1

[PATCH v3 8/8] Btrfs-progs: add missing man page for btrfs-map-logical

2013-08-13 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- v2-v3: remove 'AVAILIABLE' parts. v1-v2: GPLv3-GPLv2 --- man/Makefile | 2 +- man/btrfs-map-logical.8.in | 33 + 2 files changed, 34

[PATCH v3 6/8] Btrfs-progs: add missing man page for btrfstune

2013-08-13 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- v2-v3: remove 'AVAILIABLE' parts. v1-v2: GPLv3-GPLv2 --- man/Makefile | 2 +- man/btrfstune.8.in | 31 +++ 2 files changed, 32 insertions(+), 1

[PATCH v3 3/8] Btrfs-progs: add missing man page for btrfs-show-super

2013-08-13 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- v2-v3: remove 'AVAILIABLE' parts v1-v2: GPLv3-GPLv2 --- man/Makefile | 2 +- man/btrfs-show-super.8.in | 30 ++ 2 files changed, 31 insertions(+),

[PATCH v3 2/8] Btrfs-progs: add missing man information for btrfs-debug-tree

2013-08-13 Thread Wang Shilong
Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- v2-v3: remove 'AVAILIABLE' parts. v1-v2: GPLv3-GPLv2 --- btrfs-debug-tree.c| 2 +- man/Makefile | 3 ++- man/btrfs-debug-tree.8.in | 35