On Thu, Sep 12, 2013 at 10:38 PM, Josh Boyer wrote:
> On Thu, Sep 12, 2013 at 11:36 AM, Chris Mason
> wrote:
>> Mark Fasheh (4):
>> btrfs: offline dedupe
>
> This commit adds calls to __put_user_unaligned, which causes build
> failures on ARM if btrfs is configured:
>
> + make -s ARCH=arm
On Thursday, September 12, 2013 03:29:52 PM David Sterba wrote:
>
> The number 5 is an implementation detail, we should recommend to use 0.
>
In the current btrfs kernel code if 0 is passed as the subvolume id,
the btrfs_ioctl_default_subvol() function sets the subvolume id to the
objectid of the
于 2013年09月13日 09:47, Liu Bo 写道:
On Thu, Sep 12, 2013 at 04:08:24PM +0800, Qu Wenruo wrote:
The original btrfs_workers uses the fs_info->thread_pool_size as the
max_active, and the previous patches followed this way.
But the kernel workqueue has the default value(0) for workqueue,
and workqueue
于 2013年09月13日 01:37, David Sterba 写道:
On Thu, Sep 12, 2013 at 04:08:15PM +0800, Qu Wenruo wrote:
Use kernel workqueue and kernel workqueue based new btrfs_workqueue_struct to
replace
the old btrfs_workers.
The main goal is to reduce the redundant codes(800 lines vs 200 lines) and
try to get ben
On Thu, Sep 12, 2013 at 04:08:24PM +0800, Qu Wenruo wrote:
> The original btrfs_workers uses the fs_info->thread_pool_size as the
> max_active, and the previous patches followed this way.
>
> But the kernel workqueue has the default value(0) for workqueue,
> and workqueue itself has some threshold
于 2013年09月13日 09:29, Liu Bo 写道:
On Thu, Sep 12, 2013 at 04:08:17PM +0800, Qu Wenruo wrote:
Use the kernel workqueue to replace the btrfs_workers which are only
used as normal workqueue.
Other btrfs_workers will use some extra functions like requeue, high
priority and ordered work.
These btrfs_w
On Thu, Sep 12, 2013 at 04:08:17PM +0800, Qu Wenruo wrote:
> Use the kernel workqueue to replace the btrfs_workers which are only
> used as normal workqueue.
>
> Other btrfs_workers will use some extra functions like requeue, high
> priority and ordered work.
> These btrfs_workers will not be touc
Various people have hit a deadlock when running btrfs/011. This is because when
replacing nocow extents we will take the i_mutex to make sure nobody messes with
the file while we are replacing the extent. The problem is we are already
holding a transaction open, which is a locking inversion, so i
On Thu, Sep 12, 2013 at 11:36 AM, Chris Mason wrote:
> Mark Fasheh (4):
> btrfs: offline dedupe
This commit adds calls to __put_user_unaligned, which causes build
failures on ARM if btrfs is configured:
+ make -s ARCH=arm V=1 -j4 modules
fs/btrfs/ioctl.c: In function 'btrfs_ioctl_file_exte
On Thu, Sep 12, 2013 at 04:08:15PM +0800, Qu Wenruo wrote:
> Use kernel workqueue and kernel workqueue based new btrfs_workqueue_struct to
> replace
> the old btrfs_workers.
> The main goal is to reduce the redundant codes(800 lines vs 200 lines) and
> try to get benefits from the latest workqueue
On Fri, Sep 06, 2013 at 05:37:52PM +0800, Anand Jain wrote:
> +static char *group_type_str(u64 flag)
> {
> - struct btrfs_ioctl_space_args *sargs, *sargs_orig;
> - u64 count = 0, i;
> - int ret;
> - int fd;
> - int e;
> - char *path;
> - DIR *dirstream = NULL;
> -
> -
On Fri, Sep 06, 2013 at 05:37:53PM +0800, Anand Jain wrote:
> Further, to scan for the disks this patch will use
> lblkid, so that we don't have to manually scan the
> /dev or /dev/mapper which means we don't need the
> all-devices options.
Thanks for implementing it! I found a few things to fix,
Hi Linus,
Please pull my for-linus branch:
git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus
This is against 3.11-rc7, but was pulled and tested against your tree as
of yesterday. We do have two small incrementals queued up, but I wanted
to get this bunch out the doo
On Wed, Sep 11, 2013 at 02:34:05PM +0530, chandan wrote:
> --- a/man/btrfs.8.in
> +++ b/man/btrfs.8.in
> @@ -244,7 +244,8 @@ is similar to \fBsubvolume list\fR command.
> \fBsubvolume set-default\fR\fI \fR
> Set the subvolume of the filesystem \fI\fR which is mounted as
> \fIdefault\fR. The sub
On Thu, Sep 12, 2013 at 07:29:28PM +0800, Anand Jain wrote:
>
>
> In the item 7 below, any idea why would the disk byte be 0 ?
> (its not an inline extent)
>
It's a hole.
Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vge
In the item 7 below, any idea why would the disk byte be 0 ?
(its not an inline extent)
--
item 6 key (257 EXTENT_DATA 0) itemoff 3531 itemsize 53
extent data disk byte 456130560 nr 4096
extent data offset 0 nr 4096 ram 4096
ext
In btrfs_sync_file(), if the call to btrfs_log_dentry_safe() returns
a negative error (for e.g. -ENOMEM via btrfs_log_inode()), we would
return without ending/freeing the transaction.
Signed-off-by: Filipe David Borba Manana
---
V2: If btrfs_log_dentry_safe() returns error, don't fall through be
Use kernel workqueue to implement a new btrfs_workqueue_struct, which
has the ordering execution feature like the btrfs_worker.
The func is executed in a concurrency way, and the
ordred_func/ordered_free is executed in the sequence them are queued
after the corresponding func is done.
The new btrf
Use the kernel workqueue to replace the btrfs_workers which are only
used as normal workqueue.
Other btrfs_workers will use some extra functions like requeue, high
priority and ordered work.
These btrfs_workers will not be touched in this patch.
The followings are the untouched btrfs_workers:
ge
Use the newly created btrfs_workqueue_struct to replace the original
fs_info->workers
Signed-off-by: Qu Wenruo
---
fs/btrfs/ctree.h | 2 +-
fs/btrfs/disk-io.c | 36 +++-
fs/btrfs/super.c | 3 ++-
3 files changed, 18 insertions(+), 23 deletions(-)
diff --git
Much like the fs_info->workers, replace the fs_info->delalloc_workers
use the same btrfs_workqueue.
Signed-off-by: Qu Wenruo
---
fs/btrfs/ctree.h | 2 +-
fs/btrfs/disk-io.c | 13 +
fs/btrfs/inode.c | 19 +--
fs/btrfs/super.c | 2 +-
4 files changed, 16 inserti
Add high priority workqueue, which added a new workqueue to
btrfs_workqueue_struct.
Whether using the high priority workqueue must be decided at
initialization.
Signed-off-by: Qu Wenruo
---
fs/btrfs/bwq.c | 29 -
fs/btrfs/bwq.h | 8
2 files changed, 36 inse
Replace the submit worker with kernel workqueue.
The submit_workers is different from other workers in the following
things:
1) Requeue:
This is quiet easy, just queue_work can handle it.
2) Initialize:
The work_struct in btrfs_devices should be initialized carefully to
prevent broken work_struct
The original btrfs_workers uses the fs_info->thread_pool_size as the
max_active, and the previous patches followed this way.
But the kernel workqueue has the default value(0) for workqueue,
and workqueue itself has some threshold mechanism to prevent creating
too many threads, so we should use the
Since the patches before implemented the new kernel workqueue based
btrfs_worqueue_struct, the old btrfs workqueue(btrfs_worker) can be
removed without any problem.
Signed-off-by: Qu Wenruo
---
fs/btrfs/Makefile | 2 +-
fs/btrfs/async-thread.c | 714 --
Use kernel workqueue and kernel workqueue based new btrfs_workqueue_struct to
replace
the old btrfs_workers.
The main goal is to reduce the redundant codes(800 lines vs 200 lines) and
try to get benefits from the latest workqueue changes.
About the performance, the test suite I used is bonnie++,
The struct async_sched is not used by any codes and can be removed.
Signed-off-by: Qu Wenruo
---
fs/btrfs/volumes.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index 78b8717..12eaf89 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@
27 matches
Mail list logo