[PATCH] Btrfs: skip locking when searching commit root

2014-02-12 Thread Wang Shilong
We won't change commit root, skip locking dance with commit root when walking backrefs, this can speed up btrfs send operations. Signed-off-by: Wang Shilong --- fs/btrfs/backref.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index

[PATCH 2/3] xfstests/btrfs: add basic functional test for btrfs quota groups

2014-02-12 Thread Wang Shilong
Add missing test for btrfs quota groups feature,test idea is to create a parent qgroup that groups some subvolume groups, we try to write some data into every subvolume and then check if we exceed parent qgroup's limit size. Signed-off-by: Wang Shilong --- tests/btrfs/039 | 94 ++

[PATCH 2/4] btrfs-progs: remove a dead break before usage()

2014-02-12 Thread Gui Hecheng
The usage() in help.c calls exit(1), so the break behind is nonsense and should be removed. Signed-off-by: Gui Hecheng --- cmds-property.c | 1 - 1 file changed, 1 deletion(-) diff --git a/cmds-property.c b/cmds-property.c index 3d1f18c..df53f91 100644 --- a/cmds-property.c +++ b/cmds-property.

[PATCH 1/4] btrfs-progs: use usage() to replace the warning msg on no-arg usage

2014-02-12 Thread Gui Hecheng
To be consistent with the other cmds, replace the warning msg with usage() when send/receive are used without any args. Signed-off-by: Gui Hecheng --- cmds-receive.c | 6 ++ cmds-send.c| 7 ++- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/cmds-receive.c b/cmds-recei

[PATCH 3/4] btrfs-progs: cleanup nonsense ret value assignment

2014-02-12 Thread Gui Hecheng
The "ret" will be soon used to hold the return value of another function, assign -1 to it before is nonsense. Signed-off-by: Gui Hecheng --- free-space-cache.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/free-space-cache.c b/free-space-cache.c index 55d7318..bddde24 100644 --- a/free-sp

[PATCH 3/3] xfstests/btrfs: add stress test for btrfs quota operations

2014-02-12 Thread Wang Shilong
So this is a stress test for btrfs quota operations. it can also detect the following commit fixed problem: 4082bd3d73(Btrfs: fix oops when writting dirty qgroups to disk) Signed-off-by: Wang Shilong --- tests/btrfs/040 | 75 + tests/btrfs

[PATCH 1/3] xfstests/btrfs: add qgroup rescan stress test

2014-02-12 Thread Wang Shilong
Test flow is to run fsstress after triggering quota rescan. the ruler is simple, we just remove all files and directories, sync filesystem and see if qgroup's ref and excl are nodesize. Signed-off-by: Wang Shilong --- tests/btrfs/038 | 75 +

[PATCH 4/4] btrfs-progs: fix fsck leaks on error returns

2014-02-12 Thread Gui Hecheng
Add close_ctree()s before the "returns" on errors after open_ctree() Signed-off-by: Gui Hecheng --- cmds-check.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cmds-check.c b/cmds-check.c index 2911af0..81f65a3 100644 --- a/cmds-check.c +++ b/cmds-check.c @@ -6460,6 +

Re: What to do about df and btrfs fi df

2014-02-12 Thread Goffredo Baroncelli
Hi Kostia, On 02/12/2014 04:09 AM, Kostia Khlebopros wrote: > Any plans on having "brtfs fi df" report more precise values rather > then rounded off to the nearest hundredth of a unit. full > kilobytes(1024 bytes =1Kib) or in bytes would be nice> > Current output: > > # btrfs fi df /data > Data,

Re: What to do about df and btrfs fi df

2014-02-12 Thread Goffredo Baroncelli
Hi Hugo, On 02/11/2014 07:56 PM, Hugo Mills wrote: >> $ sudo btrfs filesystem df /mnt/btrfs1/ >> Disk size:400.00GB >> Disk unallocated: 391.97GB >> Disk allocation: >> AllocatedUsed >>Data, single: 2.01GB, 1.00GB >>System, DUP

Re: BTRFS partitioning scheme (was BTRFS with RAID1 cannot boot when removing drive)

2014-02-12 Thread Chris Murphy
On Feb 12, 2014, at 10:13 AM, Saint Germain wrote: > On 11 February 2014 19:15, Chris Murphy wrote: >>> >>> To summarize, I think I have 3 options for partitioning (I am not >>> considering UEFI secure boot or swap): >>> 1) grub, BTRFS partition (i.e. full disk in BTRFS), /boot inside BTRFS >

Re: BTRFS with RAID1 cannot boot when removing drive

2014-02-12 Thread Saint Germain
On 11 February 2014 21:35, Duncan <1i5t5.dun...@cox.net> wrote: > Saint Germain posted on Tue, 11 Feb 2014 11:04:57 +0100 as excerpted: > >> The big problem I currently have is that based on your input, I hesitate >> a lot on my partitioning scheme: should I use a dedicated /boot >> partition or sh

Re: BTRFS partitioning scheme (was BTRFS with RAID1 cannot boot when removing drive)

2014-02-12 Thread Saint Germain
On 11 February 2014 19:15, Chris Murphy wrote: >> >> To summarize, I think I have 3 options for partitioning (I am not >> considering UEFI secure boot or swap): >> 1) grub, BTRFS partition (i.e. full disk in BTRFS), /boot inside BTRFS >> subvolume > > This doesn't seem like a good idea for a boot

Re: [PATCH] btrfs: introduce BTRFS_IOC_GET_DEVS

2014-02-12 Thread Hugo Mills
On Wed, Feb 12, 2014 at 05:01:23PM +0100, David Sterba wrote: > On Fri, Feb 07, 2014 at 10:20:10AM +, Hugo Mills wrote: > > On Fri, Feb 07, 2014 at 06:08:56PM +0800, Anand Jain wrote: > > > mainly here sysfs way defeats the purpose - debug as > > > mentioned. Sysfs would/should show only moun

Re: [PATCH] btrfs: introduce BTRFS_IOC_GET_DEVS

2014-02-12 Thread David Sterba
On Fri, Feb 07, 2014 at 10:20:10AM +, Hugo Mills wrote: > On Fri, Feb 07, 2014 at 06:08:56PM +0800, Anand Jain wrote: > > mainly here sysfs way defeats the purpose - debug as > > mentioned. Sysfs would/should show only mounted disks, > >So let's find a way of showing the "known-about" da

[PATCH 2/2] Btrfs: cleanup delayed-ref.c:find_ref_head()

2014-02-12 Thread Filipe David Borba Manana
The argument last wasn't used, all callers supplied a NULL value for it. Also removed unnecessary intermediate storage of the result of key comparisons. Signed-off-by: Filipe David Borba Manana --- fs/btrfs/delayed-ref.c | 24 ++-- 1 file changed, 6 insertions(+), 18 deleti

[PATCH 1/2] Btrfs: remove unnecessary ref heads rb tree search

2014-02-12 Thread Filipe David Borba Manana
When we didn't find the exact ref head we were looking for, if return_bigger != 0 we set a new search key to match either the next node after the last one we found or the first one in the ref heads rb tree, and then did another full tree search. For both cases this ended up being pointless as we wo

[PATCH] Btrfs: more efficient split extent state insertion

2014-02-12 Thread Filipe David Borba Manana
When we split an extent state there's no need to start the rbtree search from the root node - we can start it from the original extent state node, since we would end up in its subtree if we do the search starting at the root node anyway. Signed-off-by: Filipe David Borba Manana --- fs/btrfs/exte

Re: Error: could not do orphan cleanup -22

2014-02-12 Thread Pavel Volkov
On Wednesday 12 February 2014 11:32:30 Pavel Volkov wrote: > On Monday 10 February 2014 16:13:40 Josef Bacik wrote: > > Build a kernel with this patch applied > > > > http://ur1.ca/glslj > > > > and re-run the mount and when it fails attach dmesg to this email. > > Thanks, > > > > Josef > > No

Re: Bedup bug report

2014-02-12 Thread David Sterba
On Wed, Feb 12, 2014 at 05:46:02AM -0800, Marc MERLIN wrote: > Does anyone know who the maintainer to send bug reports to, is? g2p.c...@gmail.com https://github.com/g2p/bedup -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel

Re: [PATCH 0/3] make 'btrfs fi show /mnt/point/' works with ending '/' character

2014-02-12 Thread David Sterba
On Wed, Feb 12, 2014 at 10:18:26AM +0800, Qu Wenruo wrote: > Please ignore this patchset since adding a new option to > find_mount_root is not the best method to solve the problem. I'll merge the first patch, it's moving a utility finction to a file where it IMO belongs. -- To unsubscribe from thi

How to recover from failing btrffs send | btrfs receive?

2014-02-12 Thread Marc MERLIN
So, I've veen running this for a few weeks, and soon should have something half decent to share for others to use. Unfortunately, one of my backups is now failing like so: btrfs send -p "$src_snap" "$src_newsnap" | btrfs receive "$dest_pool/" + btrfs send -p /mnt/btrfs_pool1/home_ro.20140209_12:0

Re: Bedup bug report

2014-02-12 Thread Marc MERLIN
Does anyone know who the maintainer to send bug reports to, is? On Sat, Feb 08, 2014 at 09:19:36PM -0800, Marc MERLIN wrote: > kernel 3.12.7, python 2.7.6-5, debian testing/unstable, bedup installed as per > pip install --user bedup > > I tried installing the git version, but the error is the sam

Re: btrfs multiple mounts stacked on the same mount point

2014-02-12 Thread Duncan
Anand Jain posted on Wed, 12 Feb 2014 15:36:48 +0800 as excerpted: >> BTW, another (general) reason over-mounts are sometimes used is to >> deliberately obscure what's underneath. It's worth noting that >> anything with a file already open on the underlying filesystem still >> has access to that

Re: No space left on device

2014-02-12 Thread Hugo Mills
On Wed, Feb 12, 2014 at 11:45:34AM +0100, Jakob Truelsen wrote: > Hi and thanks for the quick reply. Have remounted the filesystem with > enospc_debug, and run the rebalance you suggested, with the trance > below. So perhaps the next step is for me to figure out how to take a > metadata image and s

Re: No space left on device

2014-02-12 Thread Jakob Truelsen
Hi and thanks for the quick reply. Have remounted the filesystem with enospc_debug, and run the rebalance you suggested, with the trance below. So perhaps the next step is for me to figure out how to take a metadata image and send it to josef (perhaps with a box of tissues) /Jakob [jakobt@soda ~

Re: No space left on device

2014-02-12 Thread Leonidas Spyropoulos
On 12/02/2014 09:51, Jakob Truelsen wrote: Hello. I am experiencing "No space left on device" with a btrfs file system, yet I cannot seem to find any exhausted resource. Could some resource I do not know about be exhausted, or is this caused by something else. Below is a trace of information that

Re: No space left on device

2014-02-12 Thread Hugo Mills
On Wed, Feb 12, 2014 at 10:51:12AM +0100, Jakob Truelsen wrote: > Hello. I am experiencing "No space left on device" with a btrfs file > system, yet I cannot seem to find any exhausted resource. Could some > resource I do not know about be exhausted, or is this caused by > something else. Below is

No space left on device

2014-02-12 Thread Jakob Truelsen
Hello. I am experiencing "No space left on device" with a btrfs file system, yet I cannot seem to find any exhausted resource. Could some resource I do not know about be exhausted, or is this caused by something else. Below is a trace of information that might be usefull, please let me know if ther