Re: warn at fs/btrfs/extent-tree.c:5748 __btrfs_free_extent+0x9ce/0xa20

2014-03-12 Thread Duncan
Sage Weil posted on Tue, 11 Mar 2014 16:44:40 -0700 as excerpted: Is this something you guys have seen before? This is from v3.13-rc2. [49432.777445] CPU: 3 PID: 26411 Comm: ceph-osd Tainted: GF I 3.14.0-rc5-ceph-00016-gf31a96a # v3.13-rc2? 1) That's a bit old as there's actually

Re: [PATCH v2] Btrfs: return EPERM when deleting a default subvolume

2014-03-12 Thread Duncan
Guangyu Sun posted on Tue, 11 Mar 2014 11:24:18 -0700 as excerpted: The error message does not make sense to me: [snip] The subject says v2, which explains why I was getting deja vu reading the description, but there's no listing of what changed from v1, as is customary when a revision is

[PATCH] btrfs: Add trace for btrfs_workqueue alloc/destroy

2014-03-12 Thread quwen...@cn.fujitsu.com
Since most of the btrfs_workqueue is printed as pointer address, for easier analysis, add trace for btrfs_workqueue alloc/destroy. So it is possible to determine the workqueue that a given work belongs to(by comparing the wq pointer address with alloc trace event). Signed-off-by: Qu Wenruo

Re: Kernel BUG: btrfs send - Incremental backup

2014-03-12 Thread Swâmi Petaramesh
Hi Josef, I'm afraid I will not have the time to perform the kernel compilations and tests you request in the coming days. I'm sorry but I will really be 120% overloaded already... Kind regards. Le mardi 11 mars 2014 13:12:57 Josef Bacik a écrit : Well that's odd, I can't think of how this

xfstests btrfs/035 (was Re: Testing BTRFS)

2014-03-12 Thread David Disseldorp
Hi Eric, On Tue, 11 Mar 2014 14:08:02 -0500, Eric Sandeen wrote: Indeed, testing 3.8.13-26.2.1.el6uek.x86_64 (which is, I believe, the kernel which Avi referred to) via xfstests, I saw failures on btrfs/009 and btrfs/022; then the box deadlocked on btrfs/024. I rebooted resumed, then

Re: [PATCH v2] Btrfs: return EPERM when deleting a default subvolume

2014-03-12 Thread David Sterba
On Tue, Mar 11, 2014 at 11:24:18AM -0700, Guangyu Sun wrote: The error message is confusing: # btrfs sub delete /mnt/mysub/ Delete subvolume '/mnt/mysub' ERROR: cannot delete '/mnt/mysub' - Directory not empty The error message does not make sense to me: It's not about deleting a

Re: [PATCH] Btrfs: fix deadlock with nested trans handles

2014-03-12 Thread Rich Freeman
On Thu, Mar 6, 2014 at 7:25 PM, Zach Brown z...@redhat.com wrote: On Thu, Mar 06, 2014 at 07:01:07PM -0500, Josef Bacik wrote: Zach found this deadlock that would happen like this And this fixes it. It's run through a few times successfully. I'm not sure if my issue is related to this or

[PATCH] Btrfs-progs: mkfs: let user known when forcing mixed metadata/data groups

2014-03-12 Thread Rakesh Pandit
While formatting multiple devics (and user doesn't specify -M) if one of them has block count or size less then 1 GiB, mkfs doesn't tell user, on which one mixed metadata/data was forced. This patch updates message to print device name. Signed-off-by: Rakesh Pandit rak...@tuxera.com --- mkfs.c

[PATCH 0/6 EARLY RFC] Btrfs: Get rid of whole page I/O.

2014-03-12 Thread Chandan Rajendra
This patchset describes a possible solution to solve whole page I/O issue present in Btrfs. Currently whole page I/O is being performed because bio_vec-[bv_len, bv_offset] can be modified by the Block I/O layer and hence cannot be used by Btrfs's endio functions to operate on the original file

[PATCH 4/6] Btrfs: subpagesize-blocksize: Define extent_buffer_head

2014-03-12 Thread Chandan Rajendra
From: Chandra Seetharaman sekha...@us.ibm.com In order to handle multiple extent buffers per page, first we need to create a way to handle all the extent buffers that are attached to a page. This patch creates a new data structure eb_head, and moves fields that are common to all extent buffers

[PATCH 3/6] Btrfs: subpagesize-blocksize: Work with extents aligned to blocksize.

2014-03-12 Thread Chandan Rajendra
This is a small part of a bigger set of fixes needed to get subpagesize-blocksize to function properly. This patch is required to get 2k blocksize writes to work correctly. Without this patch, In lock_and_cleanup_extent_if_need() two consecutive 2k block writes that map to first and second 2k

[PATCH 5/6] Btrfs: subpagesize-blocksize: Hardcode MAX_EXTENT_BUFFERS_PER_PAGE to 2.

2014-03-12 Thread Chandan Rajendra
With 2k blocksize the maximum number extent buffers per page will be 2. We should be computing this value at runtime. For now, Let's work with the hardcoded value. Signed-off-by: Chandan Rajendra chan...@linux.vnet.ibm.com --- fs/btrfs/extent_io.h | 7 ++- 1 file changed, 6 insertions(+), 1

[PATCH 6/6] Btrfs: subpagesize-blocksize: Allow mounting filesystems where sectorsize != PAGE_SIZE

2014-03-12 Thread Chandan Rajendra
From: Chandra Seetharaman sekha...@us.ibm.com This patch allows mounting filesystems with blocksize smaller than the PAGE_SIZE. Signed-off-by: Chandra Seetharaman sekha...@us.ibm.com Signed-off-by: Chandan Rajendra chan...@linux.vnet.ibm.com --- fs/btrfs/disk-io.c | 6 -- 1 file changed, 6

[PATCH 2/6] Btrfs: subpagesize-blocksize: Get rid of whole page writes.

2014-03-12 Thread Chandan Rajendra
This commit brings back functions that set/clear EXTENT_WRITEBACK bits. These are required to reliably clear PG_writeback page flag. Signed-off-by: Chandan Rajendra chan...@linux.vnet.ibm.com --- fs/btrfs/extent_io.c | 74 +--- 1 file changed, 71

[PATCH 1/6] Btrfs: subpagesize-blocksize: Get rid of whole page reads.

2014-03-12 Thread Chandan Rajendra
bio_vec-{bv_offset, bv_len} cannot be relied upon by the end bio functions to track the file offset range operated on by the bio. Hence this patch adds two new members to 'struct btrfs_io_bio' to track the file offset range. This patch also brings back check_page_locked() to reliably unlock pages

3.14.0-rc3: btrfs send/receive blocks btrfs IO on other devices (near deadlocks)

2014-03-12 Thread Marc MERLIN
.15 rsync --password-file (...) 1455907:14:49 wait_current_trans.isra.15 cp -i -al current 20140312-feisty This is all stuck in btrfs kernel code. If someeone wants sysrq-w, there it is. http://marc.merlins.org/tmp/btrfs_full.txt A quick summary: SysRq : Show Blocked State task

Re: [PATCH] Btrfs: fix deadlock with nested trans handles

2014-03-12 Thread Josef Bacik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/12/2014 08:56 AM, Rich Freeman wrote: On Thu, Mar 6, 2014 at 7:25 PM, Zach Brown z...@redhat.com wrote: On Thu, Mar 06, 2014 at 07:01:07PM -0500, Josef Bacik wrote: Zach found this deadlock that would happen like this And this fixes it.

Re: [PATCH 2/2] Btrfs-progs: mkfs: make sure we can deal with hard links with -r option

2014-03-12 Thread David Sterba
On Tue, Mar 11, 2014 at 06:29:09PM +0800, Wang Shilong wrote: @@ -840,6 +833,10 @@ static int traverse_directory(struct btrfs_trans_handle *trans, cur_file-d_name, cur_inum, parent_inum, dir_index_cnt,

Re: [PATCH] Btrfs: fix deadlock with nested trans handles

2014-03-12 Thread Rich Freeman
On Wed, Mar 12, 2014 at 11:24 AM, Josef Bacik jba...@fb.com wrote: On 03/12/2014 08:56 AM, Rich Freeman wrote: After a number of reboots the system became stable, presumably whatever race condition btrfs was hitting followed a favorable path. I do have a 2GB btrfs-image pre-dating my

Re: [PATCH] Btrfs-progs: mkfs: let user known when forcing mixed metadata/data groups

2014-03-12 Thread David Sterba
On Wed, Mar 12, 2014 at 03:43:24PM +0200, Rakesh Pandit wrote: While formatting multiple devics (and user doesn't specify -M) if one of them has block count or size less then 1 GiB, mkfs doesn't tell user, on which one mixed metadata/data was forced. This patch updates message to print device

Re: [PATCH] Btrfs-progs: mkfs: let user known when forcing mixed metadata/data groups

2014-03-12 Thread Rakesh Pandit
On Wed, Mar 12, 2014 at 05:36:14PM +0100, David Sterba wrote: On Wed, Mar 12, 2014 at 03:43:24PM +0200, Rakesh Pandit wrote: While formatting multiple devics (and user doesn't specify -M) if one of them has block count or size less then 1 GiB, mkfs doesn't tell user, on which one mixed

Re: Kernel BUG: btrfs send - Incremental backup

2014-03-12 Thread Josef Bacik
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/12/2014 04:20 AM, Swâmi Petaramesh wrote: Hi Josef, I'm afraid I will not have the time to perform the kernel compilations and tests you request in the coming days. I'm sorry but I will really be 120% overloaded already... That's

Re: [systemd-devel] [HEADS-UP] Discoverable Partitions Spec

2014-03-12 Thread Chris Mason
On 03/10/2014 07:45 PM, Lennart Poettering wrote: On Mon, 10.03.14 23:39, Goffredo Baroncelli (kreij...@libero.it) wrote: Well, the name is property of the admin really. There needs to be a way how the admin can label his subvolumes, with a potentially localized name. This makes it

Re: [systemd-devel] [HEADS-UP] Discoverable Partitions Spec

2014-03-12 Thread Goffredo Baroncelli
On 03/12/2014 06:24 PM, Chris Mason wrote: On 03/10/2014 07:45 PM, Lennart Poettering wrote: On Mon, 10.03.14 23:39, Goffredo Baroncelli (kreij...@libero.it) wrote: Well, the name is property of the admin really. There needs to be a way how the admin can label his subvolumes, with a

Re: [systemd-devel] [HEADS-UP] Discoverable Partitions Spec

2014-03-12 Thread Chris Murphy
On Mar 12, 2014, at 1:12 PM, Goffredo Baroncelli kreij...@inwind.it wrote: On 03/12/2014 06:24 PM, Chris Mason wrote: On 03/10/2014 07:45 PM, Lennart Poettering wrote: On Mon, 10.03.14 23:39, Goffredo Baroncelli (kreij...@libero.it) wrote: Well, the name is property of the admin

Re: [systemd-devel] [HEADS-UP] Discoverable Partitions Spec

2014-03-12 Thread Goffredo Baroncelli
On 03/12/2014 08:31 PM, Chris Murphy wrote: On Mar 12, 2014, at 1:12 PM, Goffredo Baroncelli kreij...@inwind.it wrote: [...] I am working to prototype something like that. A mount.btrfs command which 1) handles the rollback (i.e. the user make a snapshot which is a rollback; if something

Re: [systemd-devel] [HEADS-UP] Discoverable Partitions Spec

2014-03-12 Thread Goffredo Baroncelli
On 03/12/2014 08:12 PM, Goffredo Baroncelli wrote: [...] I am working to prototype something like that. A mount.btrfs command which 1) handles the rollback (i.e. the user make a snapshot which is a rollback; if something goes wrong and the machine reboot before ending the process, during the

Re: [systemd-devel] [HEADS-UP] Discoverable Partitions Spec

2014-03-12 Thread Brendan Hide
On 2014/03/12 09:31 PM, Chris Murphy wrote: On Mar 12, 2014, at 1:12 PM, Goffredo Baroncelli kreij...@inwind.it wrote: On 03/12/2014 06:24 PM, Chris Mason wrote: Your suggestion also sounds like it places snapshots outside of their parent subvolume? If so it mitigates a possible security

Re: [PATCH v2 3/3] xfstests/btrfs: add stress test for btrfs quota operations

2014-03-12 Thread Dave Chinner
On Mon, Mar 10, 2014 at 03:48:43PM -0400, Josef Bacik wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/09/2014 11:44 PM, Wang Shilong wrote: So this is a stress test for btrfs quota operations. it can also detect the following commit fixed problem: 4082bd3d73(Btrfs: fix

[PATCH] btrfs-progs: skip erroneous free before initialization

2014-03-12 Thread Gui Hecheng
If the list is not initialized, don't try to free it. Otherwise it will cause segmentfault. Signed-off-by: Gui Hecheng guihc.f...@cn.fujitsu.com --- mkfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mkfs.c b/mkfs.c index d7049c9..df22c3a 100644 --- a/mkfs.c +++

[PATCH v2] btrfs-progs: fix bug on mkfs with relative path specified

2014-03-12 Thread Gui Hecheng
The bug accurs when exec: # mkfs.btrfs -r a relative path device (note: the path should be 'valid' correspond to your `pwd`) error msg: $ scandir for a relative path failed: No such file... o Replace strdup() with realpath() to get the correct scan path. o fix memory leaks

[PATCH] Btrfs: fix joining same transaction handle more than twice

2014-03-12 Thread Wang Shilong
We hit something like the following function call flows: |-run_delalloc_range() |-btrfs_join_transaction() |-cow_file_range() |-btrfs_join_transaction() |-find_free_extent() |-btrfs_join_transaction() Trace infomation can be seen as: [ 7411.127040] [ cut

[ANNOUNCE] xfstests: master branch updated to 3948694

2014-03-12 Thread Dave Chinner
Hi folks, The xfstests repository at git://oss.sgi.com/xfs/cmds/xfstests has just been updated. Patches often get missed, so please check if your outstanding patches were in this update. If they have not been in this update, please resubmit them to x...@oss.sgi.com so they can be picked up in the