[PATCH] btrfs: remove a FIXME in btrfs_get_acl()

2014-05-19 Thread Zhang Zhen
There is no function returns a value of -ENOENT, so the check is useless. Remove it, and the redundant braces. Signed-off-by: Zhang Zhen zhenzhang.zh...@huawei.com --- fs/btrfs/acl.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c index

Convert btrfs software code to ASIC

2014-05-19 Thread Le Nguyen Tran
Hi, I am Nguyen. I am not a software development engineer but an IC (chip) development engineer. I have a plan to develop an IC controller for Network Attached Storage (NAS). The main idea is converting software code into hardware implementation. Because the chip is customized for NAS, its

3.14.2 Debian kernel BTRFS corruption after balance

2014-05-19 Thread Russell Coker
Last night my cron job that runs /sbin/btrfs fi balance start -dusage=30 - musage=30 / failed with no space for balancing. Then I manually ran it to free space for further balancing and ended up running -musage=0 -dusage=60 (dusage=40 resulted in nothing being done).

Re: Convert btrfs software code to ASIC

2014-05-19 Thread Fajar A. Nugraha
On Mon, May 19, 2014 at 3:40 PM, Le Nguyen Tran lntran...@gmail.com wrote: Hi, I am Nguyen. I am not a software development engineer but an IC (chip) development engineer. I have a plan to develop an IC controller for Network Attached Storage (NAS). The main idea is converting software code

RE: Convert btrfs software code to ASIC

2014-05-19 Thread Paul Jones
Hi Nguyen, Perhaps a better idea would be to use a low-cost low-power som module to run Linux and btrfs code, and use an FPGA/ASIC to offload compression/encryption/checksums and to possibly act as a raid controller. Since btrfs will be under heavy development for the foreseeable future I

Re: 3.15-rc5 btrfs send/receive corruption errors? Does scrub warn of silent corruption?

2014-05-19 Thread Filipe David Manana
On Sat, May 17, 2014 at 11:23 PM, Marc MERLIN m...@merlins.org wrote: Before I delete this and start over, anything else you'd like from it? Can you create an image of the fs with btrfs-image (https://btrfs.wiki.kernel.org/index.php/Btrfs-image) and uploaded it somewhere (or send it to me

Re: send/receive and bedup

2014-05-19 Thread Scott Middleton
On 19 May 2014 09:07, Marc MERLIN m...@merlins.org wrote: On Wed, May 14, 2014 at 11:36:03PM +0800, Scott Middleton wrote: I read so much about BtrFS that I mistaked Bedup with Duperemove. Duperemove is actually what I am testing. I'm currently using programs that find files that are the

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-19 Thread Chris Mason
On 05/17/2014 01:43 PM, Hugo Mills wrote: On Wed, Apr 16, 2014 at 07:12:19PM +0200, David Sterba wrote: On Wed, Apr 02, 2014 at 04:29:11PM +0800, Qu Wenruo wrote: Convert the old btrfs man pages to new asciidoc and split the huge btrfs man page into subcommand man page. I'm merging this

Re: Convert btrfs software code to ASIC

2014-05-19 Thread Duncan
Paul Jones posted on Mon, 19 May 2014 12:24:53 + as excerpted: On Mon, May 19, 2014 at 3:40 PM, Le Nguyen Tran lntran...@gmail.com wrote: I have a plan to develop an IC controller for Network Attached Storage (NAS). The main idea is converting software code into hardware implementation.

Re: Convert btrfs software code to ASIC

2014-05-19 Thread Le Nguyen Tran
Hi Paul, Thank you for your advice. Actually, I currently have ideas to implement database management (like list, tree), and dynamic memory allocation in hardware to accelerate the file system operations. I still do not have a clear picture about which part is implemented by processor (as your

3.15-rc5 deadlocked a 2nd time after I was copying photos from an sdcard + common code path that deadlocks all btrfs filesystems

2014-05-19 Thread Marc MERLIN
Ok, that's 2 out of 2. I was copying pictures from an sdcard (through mmcblk0), and the filesystem deadlocked. Unfortunately, when this happens, I copied my pictures (which were still in RAM) to my 2nd drive which was also btrfs. I had to reboot, and of course the last pictures didn't get

Re: Convert btrfs software code to ASIC

2014-05-19 Thread Fajar A. Nugraha
On Mon, May 19, 2014 at 8:09 PM, Le Nguyen Tran lntran...@gmail.com wrote: I now need to understand the operation of btrfs source code to determine. I hope that one of you can help me Have you read the wiki link? -- Fajar -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-19 Thread David Sterba
On Sat, May 17, 2014 at 06:43:15PM +0100, Hugo Mills wrote: I've just been poking around in the docs for a completely different reason, and I think there's a fairly serious problem (well, as serious as problems get with documentation). Take, for example, the format for btrfs fi resize:

Re: Hang while deleting file

2014-05-19 Thread Joshua McKinney
No luck of catching it in the act unfortunately, but I'll bear that tip in mind for any future issues. On Mon, May 19, 2014 at 4:00 AM, Chris Murphy li...@colorremedies.com wrote: On May 18, 2014, at 10:36 AM, Joshua McKinney jos...@joshka.net wrote:

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-19 Thread David Sterba
On Mon, May 19, 2014 at 04:01:23PM +0200, David Sterba wrote: On Sat, May 17, 2014 at 06:43:15PM +0100, Hugo Mills wrote: I've just been poking around in the docs for a completely different reason, and I think there's a fairly serious problem (well, as serious as problems get with

Re: [ANNOUNCE] xfstests: new mailing list

2014-05-19 Thread Christoph Hellwig
On Sat, May 17, 2014 at 08:19:30AM +1000, Dave Chinner wrote: Renaming the test suite take a lot more work - .e.g renaming/moving source trees and a fixing all the documentation that points to it... In that case please call the list xfstests - a name different by a single character is utterly

Re: send/receive and bedup

2014-05-19 Thread Brendan Hide
On 19/05/14 15:00, Scott Middleton wrote: On 19 May 2014 09:07, Marc MERLIN m...@merlins.org wrote: On Wed, May 14, 2014 at 11:36:03PM +0800, Scott Middleton wrote: I read so much about BtrFS that I mistaked Bedup with Duperemove. Duperemove is actually what I am testing. I'm currently using

[PATCH 0/5] Documentation updates

2014-05-19 Thread David Sterba
Formatting changes inspired by Hugo's mail and some fixes that I found along the way. The update in Availability section removes the heavy development not usable text. David Sterba (5): btrfs-progs: doc: fix argument notation and typos btrfs-progs: doc: remove text for unmerged features

[PATCH 1/5] btrfs-progs: doc: fix argument notation and typos

2014-05-19 Thread David Sterba
All user-supplied values should be enclosed in ... to distinguish them from verbatim strings. Signed-off-by: David Sterba dste...@suse.cz --- Documentation/btrfs-balance.txt | 6 +++--- Documentation/btrfs-check.txt| 2 +- Documentation/btrfs-filesystem.txt | 10

[PATCH 5/5] btrfs-progs: doc: update the Availability section

2014-05-19 Thread David Sterba
Does not reflect the current state. The wiki contains more details on the first page. Signed-off-by: David Sterba dste...@suse.cz --- Documentation/btrfs-balance.txt | 4 +--- Documentation/btrfs-check.txt| 4 +--- Documentation/btrfs-device.txt | 4 +---

[PATCH 2/5] btrfs-progs: doc: remove text for unmerged features

2014-05-19 Thread David Sterba
The asciidoc conversion was done on a development branch and there are portions of text that do not reflect the code. Signed-off-by: David Sterba dste...@suse.cz --- Documentation/btrfs-device.txt | 5 - Documentation/btrfs-filesystem.txt | 46 +- 2

[PATCH 4/5] btrfs-progs: doc: make all commands and subcommands bold

2014-05-19 Thread David Sterba
Italic format is used for parameters and values, bold makes the text visually separated. Signed-off-by: David Sterba dste...@suse.cz --- Documentation/btrfs-balance.txt | 22 +++ Documentation/btrfs-check.txt| 14 +- Documentation/btrfs-convert.txt

[PATCH 1/4 RESEND] Btrfs: all super blocks of the replaced disk must be scratched

2014-05-19 Thread Anand Jain
From: Anand Jain anand.j...@oracle.com In a normal scenario when sys-admin replaces a disk, the expeted is btrfs will release the disk completely. However the below test case gives a wrong impression that replaced disk is still is in use. $ btrfs rep start /dev/sde /dev/sdg4 /btrfs $ mkfs.btrfs

[PATCH 2/4 RESEND] btrfs: btrfs_rm_device() should zero mirror SB as well

2014-05-19 Thread Anand Jain
This fix will ensure all SB copies on the disk is zeroed when the disk is intentionally removed. This helps to better manage disks in the user land. This version of patch also merges the Zach patch as below. btrfs: don't double brelse on device rm Signed-off-by: Anand Jain

[PATCH 3/4 RESEND] btrfs: add framework to read fs info from btrfs-control

2014-05-19 Thread Anand Jain
This adds ioctl BTRFS_IOC_GET_FSIDS which reads the fs info through the btrfs-control, needed to optimize heavily used btrfs-progs function check_mounted() plus few other minor uses. Signed-off-by: Anand Jain anand.j...@oracle.com --- fs/btrfs/super.c | 66

[PATCH 2/2] btrfs: usage error should not be logged into system log

2014-05-19 Thread Anand Jain
From: Anand Jain anand.j...@oracle.com I have an opinion that system logs /var/log/messages are valuable info to investigate the real system issues at the data center. People handling data center issues do spend a lot time and efforts analyzing messages files. Having usage error logged into

[PATCH 4/4 RESEND] btrfs: scrub maintenance event should be recorded in the messages

2014-05-19 Thread Anand Jain
so to help problem understanding and solving Signed-off-by: Anand Jain anand.j...@oracle.com --- fs/btrfs/ioctl.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index e174770..ff27c08 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -3702,10

[PATCH 1/2] btrfs: label should not contain return char

2014-05-19 Thread Anand Jain
From: Anand Jain anand.j...@oracle.com generally if you use echo test /sys/fs/btrfs/fsid/label it would introduce return char at the end and it can not be part of the label. The correct command is echo -n test /sys/fs/btrfs/fsid/label This patch will check for this user error

[PATCH RFC] btrfs: revamp /sys/fs/btrfs/fsid/devices

2014-05-19 Thread Anand Jain
As of now with out this patch the content under the dir /sys/fs/btrfs/fsid/devices is just links to the block devs. Moving forward we would need the above btrfs sysfs path to contain more info about the btrfs devices. This patch provide a framework and as of now a fault notification interface,

Re: send/receive and bedup

2014-05-19 Thread Konstantinos Skarlatos
On 19/5/2014 7:01 μμ, Brendan Hide wrote: On 19/05/14 15:00, Scott Middleton wrote: On 19 May 2014 09:07, Marc MERLIN m...@merlins.org wrote: On Wed, May 14, 2014 at 11:36:03PM +0800, Scott Middleton wrote: I read so much about BtrFS that I mistaked Bedup with Duperemove. Duperemove is

Re: [PATCH 1/2] btrfs: label should not contain return char

2014-05-19 Thread Eric Sandeen
On 5/19/14, 12:04 PM, Anand Jain wrote: From: Anand Jain anand.j...@oracle.com generally if you use echo test /sys/fs/btrfs/fsid/label it would introduce return char at the end and it can not be part of the label. The correct command is echo -n test /sys/fs/btrfs/fsid/label This

Re: [PATCH 1/2] btrfs: label should not contain return char

2014-05-19 Thread Roman Mamedov
On Tue, 20 May 2014 01:04:30 +0800 Anand Jain anand.j...@oracle.com wrote: From: Anand Jain anand.j...@oracle.com generally if you use echo test /sys/fs/btrfs/fsid/label it would introduce return char at the end and it can not be part of the label. The correct command is echo -n test

Re: send/receive and bedup

2014-05-19 Thread Mark Fasheh
On Mon, May 19, 2014 at 06:01:25PM +0200, Brendan Hide wrote: On 19/05/14 15:00, Scott Middleton wrote: On 19 May 2014 09:07, Marc MERLIN m...@merlins.org wrote: Thanks for that. I may be completely wrong in my approach. I am not looking for a file level comparison. Bedup worked fine for

Re: send/receive and bedup

2014-05-19 Thread Mark Fasheh
On Mon, May 19, 2014 at 08:12:03PM +0300, Konstantinos Skarlatos wrote: On 19/5/2014 7:01 μμ, Brendan Hide wrote: On 19/05/14 15:00, Scott Middleton wrote: Duperemove does look exactly like what you are looking for. The last traffic on the mailing list regarding that was in August last year.

Re: send/receive and bedup

2014-05-19 Thread Austin S Hemmelgarn
On 2014-05-19 13:12, Konstantinos Skarlatos wrote: On 19/5/2014 7:01 μμ, Brendan Hide wrote: On 19/05/14 15:00, Scott Middleton wrote: On 19 May 2014 09:07, Marc MERLIN m...@merlins.org wrote: On Wed, May 14, 2014 at 11:36:03PM +0800, Scott Middleton wrote: I read so much about BtrFS that I

[PATCH v2] Btrfs: ensure readers see new data after a clone operation

2014-05-19 Thread Filipe David Borba Manana
We were cleaning the clone target file range from the page cache before we did replace the file extent items in the fs tree. This was racy, as right after cleaning the relevant range from the page cache and before replacing the file extent items, a read against that range could be performed by

Re: send/receive and bedup

2014-05-19 Thread Mark Fasheh
On Mon, May 19, 2014 at 01:59:01PM -0400, Austin S Hemmelgarn wrote: On 2014-05-19 13:12, Konstantinos Skarlatos wrote: I have been testing duperemove and it seems to work just fine, in contrast with bedup that i have been unable to install/compile/sort out the mess with python versions. I

Re: ditto blocks on ZFS

2014-05-19 Thread Martin
On 18/05/14 17:09, Russell Coker wrote: On Sat, 17 May 2014 13:50:52 Martin wrote: [...] Do you see or measure any real advantage? Imagine that you have a RAID-1 array where both disks get ~14,000 read errors. This could happen due to a design defect common to drives of a particular

Re: [ANNOUNCE] xfstests: new mailing list

2014-05-19 Thread Dave Chinner
On Mon, May 19, 2014 at 07:55:41AM -0700, Christoph Hellwig wrote: On Sat, May 17, 2014 at 08:19:30AM +1000, Dave Chinner wrote: Renaming the test suite take a lot more work - .e.g renaming/moving source trees and a fixing all the documentation that points to it... In that case please call

Re: ditto blocks on ZFS

2014-05-19 Thread Brendan Hide
On 2014/05/19 10:36 PM, Martin wrote: On 18/05/14 17:09, Russell Coker wrote: On Sat, 17 May 2014 13:50:52 Martin wrote: [...] Do you see or measure any real advantage? [snip] This is extremely difficult to measure objectively. Subjectively ... see below. [snip] *What other failure modes*

Re: send/receive and bedup

2014-05-19 Thread Konstantinos Skarlatos
On 19/5/2014 8:38 μμ, Mark Fasheh wrote: On Mon, May 19, 2014 at 06:01:25PM +0200, Brendan Hide wrote: On 19/05/14 15:00, Scott Middleton wrote: On 19 May 2014 09:07, Marc MERLIN m...@merlins.org wrote: Thanks for that. I may be completely wrong in my approach. I am not looking for a file

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-19 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand. From: David Sterba dste...@suse.cz To: Hugo Mills h...@carfax.org.uk, Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org, c...@fb.com Date:

btrfs diff between snapshosts

2014-05-19 Thread Marc MERLIN
As a followup on the discussion we had on how to do a live data switch on a partition without unmounting it since it's busy, it came back to how do you know what changed between 2 snapshots. btrfs send giving a file list of what was added/modified/removed is the long term answer, and Filipe is

Re: ditto blocks on ZFS

2014-05-19 Thread Russell Coker
On Mon, 19 May 2014 23:47:37 Brendan Hide wrote: This is extremely difficult to measure objectively. Subjectively ... see below. [snip] *What other failure modes* should we guard against? I know I'd sleep a /little/ better at night knowing that a double disk failure on a raid5/1/10