[PATCH 1/1] btrfs-progs: fix build, manpage compression command

2014-06-03 Thread Christian Hesse
man pages for btrfs-progs are compressed by gzip by default. In Makefile the variable GZIP is use, this evaluates to 'gzip gzip' on my system. From man gzip: The environment variable GZIP can hold a set of default options for gzip. These options are interpreted first and can be overwritten by

[PATCH] btrfs-progs: Documentation: Add filter section for btrfs-balance.

2014-06-03 Thread Qu Wenruo
Man page for 'btrfs-balance' mentioned filters but does not explain them, which make end users hard to use '-d', '-m' or '-s options. This patch will use the explanations from https://btrfs.wiki.kernel.org/index.php/Balance_Filters to enrich the man page. Signed-off-by: Qu Wenruo

Re: Should btrfs reuse the src_dev's dev UUID when doing dev replacing?

2014-06-03 Thread Qu Wenruo
Original Message Subject: Re: Should btrfs reuse the src_dev's dev UUID when doing dev replacing? From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs linux-btrfs@vger.kernel.org Date: 2014年05月22日 11:09 Thanks Qu for bringing up this

Re: [PATCH 1/1] btrfs-progs: fix build, manpage compression command

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 08:09:25AM +0200, Christian Hesse wrote: man pages for btrfs-progs are compressed by gzip by default. In Makefile the variable GZIP is use, this evaluates to 'gzip gzip' on my system. From man gzip: The environment variable GZIP can hold a set of default options for

Re: [PATCH] btrfs-progs: doc: link btrfsck to btrfs-check

2014-06-03 Thread WorMzy Tykashi
On 12 May 2014 15:09, David Sterba dste...@suse.cz wrote: Thanks, it was reported fixed a few days ago, though it's not in the integration branch, lag is on my side. https://patchwork.kernel.org/patch/4115501/ Hi David, I noticed this in another thread: On 3 June 2014 10:14, David Sterba

[PATCH] Btrfs: update commit root on snapshot creation after orphan cleanup

2014-06-03 Thread Filipe David Borba Manana
On snapshot creation (either writable or read-only), we do orphan cleanup against the root of the snapshot. If the cleanup did remove any orphans, then the current root node will be different from the commit root node until the next transaction commit happens. A send operation always uses the

[PATCH 1/1] btrfs-progs: fix compiler warning

2014-06-03 Thread Christian Hesse
gcc 4.9.0 gives a warning: format ‘%d’ expects argument of type ‘int’, but argument 2 has type ‘u64’ Using %llu and casting to unsigned long long (same as bytenr) fixes this. Signed-off-by: Christian Hesse m...@eworm.de --- btrfs-select-super.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH 1/1] btrfs-progs: fix build, manpage compression command

2014-06-03 Thread Christian Hesse
David Sterba dste...@suse.cz on Tue, 2014/06/03 11:14: On Tue, Jun 03, 2014 at 08:09:25AM +0200, Christian Hesse wrote: man pages for btrfs-progs are compressed by gzip by default. In Makefile the variable GZIP is use, this evaluates to 'gzip gzip' on my system. From man gzip: The

Re: [PATCH] btrfs-progs: doc: link btrfsck to btrfs-check

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 10:38:16AM +0100, WorMzy Tykashi wrote: I noticed this in another thread: On 3 June 2014 10:14, David Sterba dste...@suse.cz wrote: I've assembled a branch containing doc-only fixes, including this one, and asked Chris do do a 3.14.3 release. Does this branch

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Arnd Bergmann
On Saturday 31 May 2014 18:30:49 Vyacheslav Dubeyko wrote: By the way, what about NILFS2? Is NILFS2 ready for suggested approach without any changes? nilfs2 and a lot of other file systems don't need any changes for this, because they don't assign the inode time stamp fields to a 'struct

Re: [PATCH v2] xfstests: add test for btrfs cloning with file holes

2014-06-03 Thread Lukáš Czerner
On Sat, 31 May 2014, Filipe David Borba Manana wrote: Date: Sat, 31 May 2014 15:12:45 +0100 From: Filipe David Borba Manana fdman...@gmail.com To: fste...@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe David Borba Manana fdman...@gmail.com Subject: [PATCH v2] xfstests: add test

Re: [PATCH v4] xfstests: add test for btrfs cloning with file holes

2014-06-03 Thread Lukáš Czerner
On Sun, 1 Jun 2014, Filipe David Borba Manana wrote: Date: Sun, 1 Jun 2014 14:06:06 +0100 From: Filipe David Borba Manana fdman...@gmail.com To: fste...@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe David Borba Manana fdman...@gmail.com Subject: [PATCH v4] xfstests: add test

Re: [PATCH 2/6 v2] btrfs: dev delete should remove sysfs entry

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 11:36:00AM +0800, Anand Jain wrote: when we delete the device from the mounted btrfs, we would need its corresponding sysfs enty to be removed as well. Signed-off-by: Anand Jain anand.j...@oracle.com Reviewed-by: David Sterba dste...@suse.cz -- To unsubscribe from

Re: [PATCH 3/6 v2] btrfs: dev add should add its sysfs entry

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 11:36:01AM +0800, Anand Jain wrote: we would need the device links to be created, when device is added. Signed-off-by: Anand Jain anand.j...@oracle.com Reviewed-by: David Sterba dste...@suse.cz -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in

Re: [PATCH 1/6 v2] btrfs: rename add_device_membership to btrfs_kobj_add_device

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 11:35:59AM +0800, Anand Jain wrote: From: Anand Jain anand.j...@oracle.com Signed-off-by: Anand Jain anand.j...@oracle.com Reviewed-by: David Sterba dste...@suse.cz Thanks. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a

Re: [PATCH v4] xfstests: add test for btrfs cloning with file holes

2014-06-03 Thread Filipe David Manana
On Tue, Jun 3, 2014 at 1:46 PM, Lukáš Czerner lczer...@redhat.com wrote: On Sun, 1 Jun 2014, Filipe David Borba Manana wrote: Date: Sun, 1 Jun 2014 14:06:06 +0100 From: Filipe David Borba Manana fdman...@gmail.com To: fste...@vger.kernel.org Cc: linux-btrfs@vger.kernel.org, Filipe

[PATCH v5] xfstests: add test for btrfs cloning with file holes

2014-06-03 Thread Filipe David Borba Manana
Regression test for the btrfs ioctl clone operation when the source range contains hole(s) and the FS has the NO_HOLES feature enabled (file holes don't need file extent items in the btree to represent them). This issue is fixed by the following linux kernel btrfs patch: Btrfs: fix clone to

Re: [PATCH 4/6 v2] btrfs: dev replace should replace the sysfs entry

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 11:36:02AM +0800, Anand Jain wrote: when we replace the device its corresponding sysfs entry has to be replaced as well Signed-off-by: Anand Jain anand.j...@oracle.com Reviewed-by: David Sterba dste...@suse.cz -- To unsubscribe from this list: send the line

Re: [PATCH 3/4] btrfs: dev replace should replace the sysfs entry

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 11:47:42AM +0800, Anand Jain wrote: +/* replace the sysfs entry */ +rm_device_membership(fs_info, src_device); +add_device_membership(fs_info, tgt_device); + btrfs_rm_dev_replace_blocked(fs_info); btrfs_rm_dev_replace_srcdev(fs_info,

Re: [PATCH 5/6 v2] btrfs: create sprout should rename fsid on the sysfs as well

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 11:36:03AM +0800, Anand Jain wrote: Creating sprout will change the fsid of the mounted root. do the same on the sysfs as well. reproducer: mount /dev/sdb /btrfs (seed disk) btrfs dev add /dev/sdc /btrfs mount -o rw,remount /btrfs btrfs dev del /dev/sdb /btrfs

Re: [PATCH 6/6 RFC v2] btrfs: revamp /sys/fs/btrfs/fsid/devices

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 11:36:04AM +0800, Anand Jain wrote: From: Anand Jain anand.j...@oracle.com As of now with out this patch the sysfs interface under dir /sys/fs/btrfs/fsid/devices is just link to the block devs. At this point it's part of the sysfs ABI and should not be changed.

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Joseph S. Myers
On Tue, 3 Jun 2014, Arnd Bergmann wrote: I think John Stultz and Thomas Gleixner have already started looking at how the timekeeping code can be updated. Once that is done, we should be able to add a functional 64-bit gettimeofday/settimeofday syscall pair. While I definitely agree this is

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Arnd Bergmann
On Tuesday 03 June 2014 14:33:10 Joseph S. Myers wrote: On Tue, 3 Jun 2014, Arnd Bergmann wrote: I think John Stultz and Thomas Gleixner have already started looking at how the timekeeping code can be updated. Once that is done, we should be able to add a functional 64-bit

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Arnd Bergmann
On Monday 02 June 2014 14:57:26 H. Peter Anvin wrote: On 06/02/2014 12:55 PM, Arnd Bergmann wrote: The bit that is really going to hurt is every single ioctl that uses a timespec. Honestly, though, I really don't understand the point with struct inode_time. It seems like the

Re: [PATCH 0/8] Add support for LZ4 compression

2014-06-03 Thread David Sterba
On Sat, May 31, 2014 at 11:48:28PM +, Philip Worrall wrote: LZ4 is a lossless data compression algorithm that is focused on compression and decompression speed. LZ4 gives a slightly worse compression ratio compared with LZO (and much worse than Zlib) but compression speeds are *generally*

Re: [PATCH v2 3/4] Btrfs-progs: fsck: deal with corrupted csum root

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 11:25:49AM +0800, Wang Shilong wrote: On 06/03/2014 01:27 AM, David Sterba wrote: On Thu, May 29, 2014 at 05:59:57PM +0800, Wang Shilong wrote: If checksum root is corrupted, fsck will get segmentation. This is because if we fail to load checksum root, root's node is

Re: [PATCH 1/1] btrfs-progs: fix compiler warning

2014-06-03 Thread David Sterba
On Tue, Jun 03, 2014 at 01:29:19PM +0200, Christian Hesse wrote: gcc 4.9.0 gives a warning: array subscript is above array bounds Checking for greater or equal instead of just equal fixes this. That fixes the warning, but I don't see the code path that leads to level = BTRFS_MAX_LEVEL On

[PATCH] btrfs-progs: fsck: report each critical root corruption separately

2014-06-03 Thread David Sterba
Explicitly say which critical root is corrupted. It is possible to repair or reset some of the roots with a special option. CC: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: David Sterba dste...@suse.cz --- Patch based on the fsck branch from integration with other fsck fixes, namely

Re: some project ideas: NFS4 ACLs, resilience on the same device, allowing to specify which devices are distinct in a RAID

2014-06-03 Thread Goffredo Baroncelli
On 06/02/2014 07:44 PM, Christoph Anton Mitterer wrote: Hi. Christian Kujau suggested in the wiki[] to post project ideas to the list to give them some possible wider discussion. So far I've had these ideas: 1) NFS 4 ACLs[1] Not sure whether it has been proposed and/or rejected

Re: [PATCH 1/1] btrfs-progs: fix compiler warning

2014-06-03 Thread Christian Hesse
David Sterba dste...@suse.cz on Tue, 2014/06/03 18:52: On Tue, Jun 03, 2014 at 01:29:19PM +0200, Christian Hesse wrote: gcc 4.9.0 gives a warning: array subscript is above array bounds Checking for greater or equal instead of just equal fixes this. That fixes the warning, but I don't

Re: [RFC 00/32] making inode time stamps y2038 ready

2014-06-03 Thread Dave Chinner
On Tue, Jun 03, 2014 at 04:22:19PM +0200, Arnd Bergmann wrote: On Monday 02 June 2014 14:57:26 H. Peter Anvin wrote: On 06/02/2014 12:55 PM, Arnd Bergmann wrote: The possible uses I can see for non-ktime_t types in the kernel are: * inodes need 96 bit timestamps to represent the full range of

Re: All free space eaten during defragmenting (3.14)

2014-06-03 Thread Peter Chant
On 06/03/2014 05:46 AM, Duncan wrote: Interesting. I have set autodefrag in fstab. I _may_ have previously tried to defrag the top-level subvolume - faint memory, that is pointless, as if a file exists in more than one subvolume and it is changed in one or more it cannot be optimally

Re: What to do about snapshot-aware defrag

2014-06-03 Thread Martin
On 02/06/14 14:22, Josef Bacik wrote: On 05/30/2014 06:00 PM, Martin wrote: OK... I'll jump in... On 30/05/14 21:43, Josef Bacik wrote: Hello, TL;DR: I want to only do snapshot-aware defrag on inodes in snapshots that haven't changed since the snapshot was taken. Yay or nay (with a

Re: [PATCH] btrfs-progs: fsck: report each critical root corruption separately

2014-06-03 Thread Wang Shilong
On 06/04/2014 12:37 AM, David Sterba wrote: Explicitly say which critical root is corrupted. It is possible to repair or reset some of the roots with a special option. David, thanks for doing this:-) CC: Wang Shilong wangsl.f...@cn.fujitsu.com Signed-off-by: David Sterba dste...@suse.cz ---

Re: [PATCH v2 3/4] Btrfs-progs: fsck: deal with corrupted csum root

2014-06-03 Thread Wang Shilong
On 06/04/2014 12:21 AM, David Sterba wrote: On Tue, Jun 03, 2014 at 11:25:49AM +0800, Wang Shilong wrote: On 06/03/2014 01:27 AM, David Sterba wrote: On Thu, May 29, 2014 at 05:59:57PM +0800, Wang Shilong wrote: If checksum root is corrupted, fsck will get segmentation. This is because if we

Re: Should btrfs reuse the src_dev's dev UUID when doing dev replacing?

2014-06-03 Thread Anand Jain
Hi Qu, in-line below. On 03/06/14 14:28, Qu Wenruo wrote: Original Message Subject: Re: Should btrfs reuse the src_dev's dev UUID when doing dev replacing? From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs linux-btrfs@vger.kernel.org

Re: [PATCH 6/6 RFC v2] btrfs: revamp /sys/fs/btrfs/fsid/devices

2014-06-03 Thread Anand Jain
David, Thanks for the comments As of now with out this patch the sysfs interface under dir /sys/fs/btrfs/fsid/devices is just link to the block devs. At this point it's part of the sysfs ABI and should not be changed. can't we lean on the experimental clause to change it either ?

Re: [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove.

2014-06-03 Thread Qu Wenruo
Original Message Subject: Re: [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove. From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年05月29日 20:43 On Wed, Apr 16, 2014 at 05:02:32PM +0800, Qu Wenruo wrote: @@ -1704,10