Re: btrfs loopback problems

2014-07-07 Thread Chris Samuel
On Mon, 7 Jul 2014 11:20:30 AM Qu Wenruo wrote: As Chris Mason mentioned, fixed in the following patch: https://patchwork.kernel.org/patch/4143821/ That should probably go to -stable (if it hasn't already), especially as 3.14 is a new LTS kernel. cheers, Chris -- Chris Samuel :

Re: [PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-07-07 Thread Anand Jain
It's a pity that the patch has been merged into the upstream kernel. Let's correct our miss before the next merge. What I found were new-bugs, those are not related to this patch. BTW, I sent some patches to fix the problems about seed device(including the updated patch of this one),

Re: [PATCH 1/2] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-07-07 Thread Anand Jain
It's a pity that the patch has been merged into the upstream kernel. Let's correct our miss before the next merge. What I found were new-bugs, those are not related to this patch. BTW, I sent some patches to fix the problems about seed device(including the updated patch of this one),

Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-07 Thread Vikram Goyal
On Fri, Jul 04, 2014 at 03:52:26PM +0200, David Sterba wrote: On Fri, Jul 04, 2014 at 04:38:49PM +0800, Qu Wenruo wrote: 'btrfs fi df' command is currently able to be executed on any file/dir inside btrfs since it uses btrfs ioctl to get disk usage info. However it is somewhat confusing for

Re: [PATCH V2 7/9] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-07-07 Thread Anand Jain
On 07/07/2014 12:22, Miao Xie wrote: On Mon, 7 Jul 2014 12:04:09 +0800, Anand Jain wrote: when one of the device path is missing btrfs_device name is null. So this patch will check for that. stack: BUG: unable to handle kernel NULL pointer dereference at 0010 IP:

[PATCH] Btrfs: set error return value in btrfs_get_blocks_direct

2014-07-07 Thread Filipe Manana
We were returning with 0 (success) because we weren't extracting the error code from em (PTR_ERR(em)). Fix it. Signed-off-by: Filipe Manana fdman...@suse.com --- fs/btrfs/inode.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c index

Re: qgroup destroy / assign

2014-07-07 Thread Kevin Brandstatter
Wang, Yes that certainly helps me make more sense of it. I was able to get the qgroup assigning to work properly. I guess the next question would be if it would be a valid feature to implement automatic qgroup deletion when a subvolume is destroyed. I suppose in order to help alleviate issues

mount time of multi-disk arrays

2014-07-07 Thread André-Sebastian Liebe
Hello List, can anyone tell me how much time is acceptable and assumable for a multi-disk btrfs array with classical hard disk drives to mount? I'm having a bit of trouble with my current systemd setup, because it couldn't mount my btrfs raid anymore after adding the 5th drive. With the 4 drive

Re: mount time of multi-disk arrays

2014-07-07 Thread Konstantinos Skarlatos
On 7/7/2014 4:38 μμ, André-Sebastian Liebe wrote: Hello List, can anyone tell me how much time is acceptable and assumable for a multi-disk btrfs array with classical hard disk drives to mount? I'm having a bit of trouble with my current systemd setup, because it couldn't mount my btrfs raid

Re: mount time of multi-disk arrays

2014-07-07 Thread Austin S Hemmelgarn
On 2014-07-07 09:54, Konstantinos Skarlatos wrote: On 7/7/2014 4:38 μμ, André-Sebastian Liebe wrote: Hello List, can anyone tell me how much time is acceptable and assumable for a multi-disk btrfs array with classical hard disk drives to mount? I'm having a bit of trouble with my current

Re: mount time of multi-disk arrays

2014-07-07 Thread André-Sebastian Liebe
On 07/07/2014 03:54 PM, Konstantinos Skarlatos wrote: On 7/7/2014 4:38 μμ, André-Sebastian Liebe wrote: Hello List, can anyone tell me how much time is acceptable and assumable for a multi-disk btrfs array with classical hard disk drives to mount? I'm having a bit of trouble with my current

Re: [PATCH] btrfs compression: merge inflate and deflate z_streams

2014-07-07 Thread Sergey Senozhatsky
against linux-next rc4-20140707 due to 130d5b415a091e. unhappy hunk is: + if (workspace-strm.total_in 8192 + workspace-strm.total_in + workspace-strm.total_out) { ret = -EIO; now it should be: + if (workspace

[PATCH] Btrfs-progs: fix Segmentation fault of btrfs-convert

2014-07-07 Thread Liu Bo
Recently we merge a memory leak fix, which fails xfstests/btrfs/012, the cause is that it only frees @fs_devices but leaves it on the global fs_uuid list, which cause a 'Segmentation fault' over running command btrfs-convert. This fixes the problem. Signed-off-by: Liu Bo bo.li@oracle.com ---

[PATCHv2] btrfs compression: merge inflate and deflate z_streams

2014-07-07 Thread Sergey Senozhatsky
`struct workspace' used for zlib compression contains two zlib z_stream-s: `def_strm' used in zlib_compress_pages(), and `inf_strm' used in zlib_decompress/zlib_decompress_biovec(). None of these functions use `inf_strm' and `def_strm' simultaniously, meaning that for every compress/decompress

[PATCHv2] btrfs compression: merge inflate and deflate z_streams

2014-07-07 Thread Sergey Senozhatsky
Hello, This patch reduces zlib compression memory usage by `merging' inflate and deflate streams into a single stream. -- v2: rebased-on linux-next rc4 20140707 Sergey Senozhatsky (1): btrfs compression: merge inflate and deflate z_streams fs/btrfs/zlib.c | 138

Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-07 Thread Eric Sandeen
On 7/4/14, 8:52 AM, David Sterba wrote: On Fri, Jul 04, 2014 at 04:38:49PM +0800, Qu Wenruo wrote: 'btrfs fi df' command is currently able to be executed on any file/dir inside btrfs since it uses btrfs ioctl to get disk usage info. However it is somewhat confusing for some end users since

Re: mount time of multi-disk arrays

2014-07-07 Thread Duncan
Konstantinos Skarlatos posted on Mon, 07 Jul 2014 16:54:05 +0300 as excerpted: On 7/7/2014 4:38 μμ, André-Sebastian Liebe wrote: can anyone tell me how much time is acceptable and assumable for a multi-disk btrfs array with classical hard disk drives to mount? I'm having a bit of trouble

Re: mount time of multi-disk arrays

2014-07-07 Thread Benjamin O'Connor
As a point of reference, my BTRFS filesystem with 11 x 21TB devices in RAID0 with space cache enabled takes about 4 minutes to mount after a clean unmount. There is a decent amount of variation in the amount of time (has been as low as 3 minutes or taken 5 minutes or longer). These devices

Re: mount time of multi-disk arrays

2014-07-07 Thread André-Sebastian Liebe
On 07/07/2014 04:14 PM, Austin S Hemmelgarn wrote: On 2014-07-07 09:54, Konstantinos Skarlatos wrote: On 7/7/2014 4:38 μμ, André-Sebastian Liebe wrote: Hello List, can anyone tell me how much time is acceptable and assumable for a multi-disk btrfs array with classical hard disk drives to

Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options

2014-07-07 Thread Goffredo Baroncelli
On 07/07/2014 03:46 AM, Qu Wenruo wrote: [... cut ...] So to me it seems reasonable to have different rw/ro status between btrfs root and btrfs subvolume. As use case think a system which hosts several guests in container. Each guest has its own subvolume as root filesystem. An user would

[PATCH] btrfs: test for valid bdev before kobj removal in btrfs_rm_device

2014-07-07 Thread Eric Sandeen
commit 4cd btrfs: dev delete should remove sysfs entry added a btrfs_kobj_rm_device, which dereferences device-bdev... right after we check whether device-bdev might be NULL. I don't honestly know if it's possible to have a NULL device-bdev here, but assuming that it is (given the test), we

[PATCH RFC] btrfs: code optimize use btrfs_get_bdev_and_sb() at btrfs_scan_one_device

2014-07-07 Thread Anand Jain
(for review comments pls). btrfs_scan_one_device() needs SB, instead of doing it from scratch could use btrfs_get_bdev_and_sb() Signed-off-by: Anand Jain anand.j...@oracle.com --- fs/btrfs/volumes.c | 51 ++- 1 file changed, 6 insertions(+), 45

[PATCH 1/2] btrfs: syslog when quota is enabled

2014-07-07 Thread Anand Jain
must syslog when btrfs working config changes so is to support offline investigation of the issues. --- fs/btrfs/ioctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 016a5eb..bb4a498 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -4216,6

[PATCH 2/2] btrfs: syslog when quota is disabled

2014-07-07 Thread Anand Jain
Offline investigations of the issues would need to know when quota is disabled. Signed-off-by: Anand Jain anand.j...@oracle.com --- fs/btrfs/ioctl.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index bb4a498..fd29978 100644 --- a/fs/btrfs/ioctl.c +++

btrfs: add trace for qgroup accounting

2014-07-07 Thread Mark Fasheh
We want this to debug qgroup changes on live systems. Signed-off-by: Mark Fasheh mfas...@suse.de Reviewed-by: Josef Bacik jba...@fb.com --- fs/btrfs/qgroup.c| 3 +++ fs/btrfs/super.c | 1 + include/trace/events/btrfs.h | 56

[PATCH 0/3] btrfs: qgroup fixes for btrfs_drop_snapshot V3

2014-07-07 Thread Mark Fasheh
Hi, the following patches try to fix a long outstanding issue with qgroups and snapshot deletion. The core problem is that btrfs_drop_snapshot will skip shared extents during it's tree walk. This results in an inconsistent qgroup state once the drop is processed. The first patch adds some tracing

btrfs: qgroup: account shared subtrees during snapshot delete

2014-07-07 Thread Mark Fasheh
During its tree walk, btrfs_drop_snapshot() will skip any shared subtrees it encounters. This is incorrect when we have qgroups turned on as those subtrees need to have their contents accounted. In particular, the case we're concerned with is when removing our snapshot root leaves the subtree with

[PATCH] Btrfs: __btrfs_mod_ref should always use no_quota

2014-07-07 Thread Mark Fasheh
From: Josef Bacik jba...@fb.com Before I extended the no_quota arg to btrfs_dec/inc_ref because I didn't understand how snapshot delete was using it and assumed that we needed the quota operations there. With Mark's work this has turned out to be not the case, we _always_ need to use no_quota

Re: [v3.10.y][v3.11.y][v3.12.y][v3.13.y][v3.14.y][PATCH 1/1][V2] ALSA: usb-audio: Prevent printk ratelimiting from spamming kernel log while DEBUG not defined

2014-07-07 Thread Greg KH
On Sat, Jun 21, 2014 at 12:48:27PM -0700, Greg KH wrote: On Sat, Jun 21, 2014 at 01:05:53PM +0100, Ben Hutchings wrote: On Fri, 2014-06-20 at 14:21 -0400, Joseph Salisbury wrote: [...] I looked at this some more. It seems like my v2 backport may be the most suitable for the releases

Re: mount time of multi-disk arrays

2014-07-07 Thread Konstantinos Skarlatos
On 7/7/2014 6:48 μμ, Duncan wrote: Konstantinos Skarlatos posted on Mon, 07 Jul 2014 16:54:05 +0300 as excerpted: On 7/7/2014 4:38 μμ, André-Sebastian Liebe wrote: can anyone tell me how much time is acceptable and assumable for a multi-disk btrfs array with classical hard disk drives to

Re: mount time of multi-disk arrays

2014-07-07 Thread Konstantinos Skarlatos
On 7/7/2014 5:24 μμ, André-Sebastian Liebe wrote: On 07/07/2014 03:54 PM, Konstantinos Skarlatos wrote: On 7/7/2014 4:38 μμ, André-Sebastian Liebe wrote: Hello List, can anyone tell me how much time is acceptable and assumable for a multi-disk btrfs array with classical hard disk drives to

Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-07 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command From: Vikram Goyal vikigo...@gmail.com To: linux-btrfs@vger.kernel.org Date: 2014年07月07日 17:51 On Fri, Jul 04, 2014 at 03:52:26PM +0200, David Sterba wrote: On Fri, Jul

Re: [PATCH V2 7/9] btrfs: fix null pointer dereference in clone_fs_devices when name is null

2014-07-07 Thread Miao Xie
On Mon, 7 Jul 2014 17:56:13 +0800, Anand Jain wrote: On 07/07/2014 12:22, Miao Xie wrote: On Mon, 7 Jul 2014 12:04:09 +0800, Anand Jain wrote: when one of the device path is missing btrfs_device name is null. So this patch will check for that. stack: BUG: unable to handle kernel NULL

Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options

2014-07-07 Thread Duncan
Goffredo Baroncelli posted on Mon, 07 Jul 2014 19:37:53 +0200 as excerpted: For mounted RO I mean the VFS flag, the one passed via the mount command. I say one as 1, because I am convinced that it has to act globally, e.g. on the whole filesystem; the flag should be set at the first mount,

Re: [PATCH RFC] btrfs: code optimize use btrfs_get_bdev_and_sb() at btrfs_scan_one_device

2014-07-07 Thread Miao Xie
On Tue, 8 Jul 2014 02:38:37 +0800, Anand Jain wrote: (for review comments pls). btrfs_scan_one_device() needs SB, instead of doing it from scratch could use btrfs_get_bdev_and_sb() Signed-off-by: Anand Jain anand.j...@oracle.com --- fs/btrfs/volumes.c | 51

Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options

2014-07-07 Thread Goffredo Baroncelli
On 07/08/2014 04:43 AM, Duncan wrote: The remaining problem to deal with is that if say the root subvol (id=5) is mounted rw,subvolmode=rw, while a subvolume below it is mounted subvolmode=ro, then what happens if someone tries to make an edit in the portion of the filesystem visible in the

Re: [PATCH RFC] btrfs: code optimize use btrfs_get_bdev_and_sb() at btrfs_scan_one_device

2014-07-07 Thread Liu Bo
On Tue, Jul 08, 2014 at 02:38:37AM +0800, Anand Jain wrote: (for review comments pls). btrfs_scan_one_device() needs SB, instead of doing it from scratch could use btrfs_get_bdev_and_sb() Signed-off-by: Anand Jain anand.j...@oracle.com --- fs/btrfs/volumes.c | 51

Re: [PATCH RFC] btrfs: code optimize use btrfs_get_bdev_and_sb() at btrfs_scan_one_device

2014-07-07 Thread Miao Xie
On Tue, 8 Jul 2014 12:08:19 +0800, Liu Bo wrote: On Tue, Jul 08, 2014 at 02:38:37AM +0800, Anand Jain wrote: (for review comments pls). btrfs_scan_one_device() needs SB, instead of doing it from scratch could use btrfs_get_bdev_and_sb() Signed-off-by: Anand Jain anand.j...@oracle.com ---