Re: [PATCH 2/2] btrfs: fix false enospc for compression

2016-10-05 Thread Wang Xiaoguang
Hi, On 10/06/2016 10:51 AM, Wang Xiaoguang wrote: When testing btrfs compression, sometimes we got ENOSPC error, though fs still has much free space, xfstests generic/171, generic/172, generic/173, generic/174, generic/175 can reveal this bug in my test environment when compression is enabled.

Re: BTRFS: space_info 4 has 18446742286429913088 free, is not full

2016-10-05 Thread Wang Xiaoguang
Hi, On 09/29/2016 03:27 PM, Stefan Priebe - Profihost AG wrote: Am 29.09.2016 um 09:13 schrieb Wang Xiaoguang: I found that compress sometime report ENOSPC error even in 4.8-rc8, currently I cannot confirm that as i do not have anough space to test this without compression ;-( But yes i've

[PATCH 2/2] btrfs: fix false enospc for compression

2016-10-05 Thread Wang Xiaoguang
When testing btrfs compression, sometimes we got ENOSPC error, though fs still has much free space, xfstests generic/171, generic/172, generic/173, generic/174, generic/175 can reveal this bug in my test environment when compression is enabled. After some debuging work, we found that it's

[PATCH 1/2] btrfs: improve inode's outstanding_extents computation

2016-10-05 Thread Wang Xiaoguang
This issue was revealed by modifying BTRFS_MAX_EXTENT_SIZE(128MB) to 64KB, When modifying BTRFS_MAX_EXTENT_SIZE(128MB) to 64KB, fsstress test often gets these warnings from btrfs_destroy_inode(): WARN_ON(BTRFS_I(inode)->outstanding_extents);

Re: Btrfs progs release 4.8 (32bit builds broken)

2016-10-05 Thread Justin Maggard
Oops, I mistook the intent of that check. Please disregard. On Wed, Oct 5, 2016 at 3:25 PM, Justin Maggard wrote: > I saw a 32-bit build failure, but it looked like a legitimate bug, > unrelated to the compiler version. Here's the trivial fix: > > diff --git a/ioctl.h

Re: Btrfs progs release 4.8 (32bit builds broken)

2016-10-05 Thread Justin Maggard
I saw a 32-bit build failure, but it looked like a legitimate bug, unrelated to the compiler version. Here's the trivial fix: diff --git a/ioctl.h b/ioctl.h index a7235c0..26a3a5a 100644 --- a/ioctl.h +++ b/ioctl.h @@ -606,7 +606,7 @@ struct btrfs_ioctl_send_args { * Size of structure depends

Re: [PATCH] btrfs: opencode chunk locking, remove helpers

2016-10-05 Thread Jeff Mahoney
On 10/5/16 8:23 AM, David Sterba wrote: > The helpers are trivial and we don't use them consistently. This one is going to conflict with the root->fs_info removal patchset in every chunk since the helper does nothing with the root. Otherwise, the idea is sound. -Jeff > Signed-off-by: David

Re: Btrfs progs release 4.8 (32bit builds broken)

2016-10-05 Thread David Sterba
I got a report that the 32bit builds are broken. This seems to be caused by padding inserted (or not) into the structures and depends on a compiler version. The error messages may look cryptic, but if you see something like ioctl.h:570:1: note: in expansion of macro 'BUILD_ASSERT'

[PATCH] Btrfs-progs: subvol_uuid_search: Return error code on memory allocation failure

2016-10-05 Thread Prasanth K S R
From: Prasanth K S R This commit fixes coverity defect CID 1328695. Signed-off-by: Prasanth K S R --- send-utils.c | 5 + 1 file changed, 5 insertions(+) diff --git a/send-utils.c b/send-utils.c index a85fa08..6f80b6f 100644 ---

[PATCH] btrfs: opencode chunk locking, remove helpers

2016-10-05 Thread David Sterba
The helpers are trivial and we don't use them consistently. Signed-off-by: David Sterba --- fs/btrfs/disk-io.c | 4 +-- fs/btrfs/extent-tree.c | 8 +++--- fs/btrfs/free-space-cache.c | 4 +-- fs/btrfs/volumes.c | 70

[PATCH] btrfs: remove stale comment from btrfs_statfs

2016-10-05 Thread David Sterba
Signed-off-by: David Sterba --- fs/btrfs/super.c | 4 1 file changed, 4 deletions(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 4071fe2bd098..2b852ca4fea5 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -2076,10 +2076,6 @@ static int

[PATCH] btrfs: remove unused headers, statfs.h

2016-10-05 Thread David Sterba
Signed-off-by: David Sterba --- fs/btrfs/file.c | 1 - fs/btrfs/inode.c | 1 - fs/btrfs/ioctl.c | 1 - 3 files changed, 3 deletions(-) diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index fea31a4a6e36..887ed6ac016e 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -27,7

Btrfs progs release 4.8

2016-10-05 Thread David Sterba
Hi, btrfs-progs 4.8 have been released. Though it's a major version release, there are no shiny new features. The theme was error handling improvements and addressing some fuzzer bugz. There are several fuzzer bugs open and some tests might report errors with ASAN or UBSAN enabled. Fixing needs

[PATCH] btrfs-progs: image: fix compiler warning

2016-10-05 Thread Tsutomu Itoh
In v4.8-rc1, gcc 5.3.1 gives following warning. Fixed it. [CC] btrfs-image.o btrfs-image.c: In function 'flush_pending': btrfs-image.c:708:17: warning: 'start' may be used uninitialized in this function [-Wmaybe-uninitialized] header->bytenr = cpu_to_le64(start); ^