Re: [PATCH] btrfs: add framework to handle device flush error as a volume

2017-04-26 Thread Anand Jain
Hi David, This patch adds comments explaining the original design, and also adds a cleanup so that a volume level error-handles for the flush failures can be implemented. I wonder if you have any comments.? (Also just a note, a bio prealloc (for flush) will make below ENOMEM to go away, h

[PATCH] fstests: regression test for nocsum buffered read's repair

2017-04-26 Thread Liu Bo
This is to test whether buffered read retry-repair code is able to work in raid1 case as expected. Please note that without checksum, btrfs doesn't know if the data used to repair is correct, so repair is more of resync which makes sure that both of the copy has the same content. Commit 20a7db8ab

[PATCH] fstests: regression test for nocsum dio read's repair

2017-04-26 Thread Liu Bo
Commit 2dabb3248453 ("Btrfs: Direct I/O read: Work on sectorsized blocks") introduced this regression. It'd cause 'Segmentation fault' error. The upstream fix is Btrfs: fix segment fault when doing dio read Signed-off-by: Liu Bo --- tests/btrfs/142 | 189 +++

Re: [PATCH] Tidy while loop in end_compressed_writeback

2017-04-26 Thread Sahil Kang
Hi Chris, Would you merge my patch below? It's a minor update to improve the loop's readability. Thanks, Sahil On 04/19/2017 05:43 AM, Sahil Kang wrote: Hi, This is my first patch so it's a minor code change. I think removing the early continue from the loop makes the function a little easie

[PATCH v2] fstests: regression test for btrfs buffered read's repair

2017-04-26 Thread Liu Bo
This case tests whether buffered read can repair the bad copy if we have a good copy. Commit 20a7db8ab3f2 ("btrfs: add dummy callback for readpage_io_failed and drop checks") introduced the regression. The upstream fix is Btrfs: bring back repair during read Signed-off-by: Liu Bo --- v2

[PATCH v2] fstests: regression test for btrfs dio read repair

2017-04-26 Thread Liu Bo
This case tests whether dio read can repair the bad copy if we have a good copy. Commit 2dabb3248453 ("Btrfs: Direct I/O read: Work on sectorsized blocks") introduced the regression. The upstream fix is Btrfs: fix invalid dereference in btrfs_retry_endio Signed-off-by: Liu Bo --- v2: -

Re: [GIT PULL] Btrfs bug fixes for 4.12

2017-04-26 Thread Chris Mason
On 04/26/2017 01:52 PM, fdman...@kernel.org wrote: From: Filipe Manana Hi Chris, Please consider the following changes for the 4.12 merge window. These are all bug fixes and nothing particularly outstanding compared to changes for past merge windows. Thanks. The following changes since commi

[GIT PULL] Btrfs bug fixes for 4.12

2017-04-26 Thread fdmanana
From: Filipe Manana Hi Chris, Please consider the following changes for the 4.12 merge window. These are all bug fixes and nothing particularly outstanding compared to changes for past merge windows. Thanks. The following changes since commit a967efb30b3afa3d858edd6a17f544f9e9e46eea: Btrfs:

Re: [PULL] Btrfs, updates for 4.12

2017-04-26 Thread Chris Mason
On 04/26/2017 11:06 AM, Filipe Manana wrote: > Hi, > > Did you actually ran xfstests with those readahead patches to > preallocate radix tree nodes? > > With those 2 patches applied (Chris' for-linus.4,12 branch) this > breaks things and many btrfs specific tests (at least, since I can't > get

Re: Problem with file system

2017-04-26 Thread Fred Van Andel
Yes I was running qgroups. Yes the filesystem is highly fragmented. Yes I have way too many snapshots. I think it's clear that the problem is on my end. I simply placed too many demands on the filesystem without fully understanding the implications. Now I have to deal with the consequences. It w

Re: [PULL] Btrfs, updates for 4.12

2017-04-26 Thread David Sterba
On Wed, Apr 26, 2017 at 04:06:29PM +0100, Filipe Manana wrote: > On Wed, Apr 19, 2017 at 12:35 PM, David Sterba wrote: > > Adam Borowski (1): > > btrfs: fix a bogus warning when converting only data or metadata > > > > Anand Jain (3): > > btrfs: use q which is already obtained from bde

Re: [PULL] Btrfs, updates for 4.12

2017-04-26 Thread Filipe Manana
On Wed, Apr 19, 2017 at 12:35 PM, David Sterba wrote: > Hi, > > this is the main part of my 4.12 pull, condensed changelog below. I might send > another pull with low-risk patches, mostly cleanups, but so far I'm done with > base testing now. We had a high-churn cycle last time, so this could be s

Re: [PULL] Btrfs, updates for 4.12

2017-04-26 Thread Chris Mason
On 04/26/2017 11:06 AM, Filipe Manana wrote: Hi, Did you actually ran xfstests with those readahead patches to preallocate radix tree nodes? With those 2 patches applied (Chris' for-linus.4,12 branch) this breaks things and many btrfs specific tests (at least, since I can't get pass them) re