Re: [PATCH] btrfs: Add qgroup_auto_cleanup mount flag to automatically cleanup qgroups

Hi Sargun, [auto build test ERROR on v4.12-rc7] [also build test ERROR on next-20170630] [cannot apply to btrfs/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sargun-Dhillon/btrfs-Add

Re: [PATCH v2 3/4] btrfs: Add zstd support

>> If we're going to make that configurable, there are some things to >> consider: >> >> * the underlying compressed format -- does not change for different >>levels This is true for zlib and zstd. lzo in the kernel only supports one compression level. >> * the configuration interface --

Re: [PATCH v2 0/4] Add xxhash and zstd modules

> If i understood all correctly, > zstd can compress (decompress) data in way compatible with gzip (zlib) > Do that also true for in kernel library? The zstd command line tool can decompress gzip/zlib compressed data, and can compress in the gzip format. However, the zstd format is not compatible

Re: [PATCH v2 3/4] btrfs: Add zstd support

On 2017-06-30 10:21, David Sterba wrote: On Fri, Jun 30, 2017 at 08:16:20AM -0400, E V wrote: On Thu, Jun 29, 2017 at 3:41 PM, Nick Terrell wrote: Add zstd compression and decompression support to BtrFS. zstd at its fastest level compresses almost as well as zlib, while

Re: [PATCH v8 17/18] xfs: minimal conversion to errseq_t writeback error reporting

On Fri, Jun 30, 2017 at 12:45:54PM -0400, Jeff Layton wrote: > Should I aim to do that with an individual patch for each fs, or is it > better to do a swath of them all at once in a single patch here? I'd be perfectly happy with one big patch for all the trivial conversions. -- To unsubscribe

Re: [PATCH v2 0/4] Add xxhash and zstd modules

Hi Nick Terrell, If i understood all correctly, zstd can compress (decompress) data in way compatible with gzip (zlib) Do that also true for in kernel library? If that true, does that make a sense to directly replace zlib with zstd (configured to work like zlib) in place (as example for btrfs zlib

Re: [PATCH v8 17/18] xfs: minimal conversion to errseq_t writeback error reporting

On Thu, 2017-06-29 at 07:12 -0700, Christoph Hellwig wrote: > Nice and simple, this looks great! > > Reviewed-by: Christoph Hellwig Thanks! I think this turned out to be a lot cleaner too. For filesystems that use filemap_write_and_wait_range today this now becomes a pretty

Btrfs progs release 4.11.1

Hi, btrfs-progs version 4.11.1 have been released. It's a small release with handful of fixes and minor other updates. Changes: * image: restoring from multiple devices * dev stats: make --check option work * check: fix false alert with extent hole on a NO_HOLE filesystem * check: lowmem

Re: [PATCH v2 2/4] btrfs: Add new ioctl uapis for qgroup creation / removal

On Fri, May 26, 2017 at 08:44:41PM +, Sargun Dhillon wrote: > This patch introduces two new ioctls to create, and remove qgroups. These > offer a somewhat more intuitive set of operations with the opportunity > to add flags that gate to unintentional manipulation of qgroups. > > The create

Re: [PATCH v2 3/4] btrfs: Warn the user when the legacy btrfs_qgroup_create API is used

On Fri, May 26, 2017 at 08:44:50PM +, Sargun Dhillon wrote: > This patch adds a warning to let the user know when the legacy > qgroup creation / removal API is in use. Eventually, we can > deprecate this API. > > Signed-off-by: Sargun Dhillon > --- > fs/btrfs/ioctl.c | 2

Re: [PATCH v2 4/4] btrfs: Add qgroup_auto_cleanup mount flag to automatically cleanup qgroups

On Fri, May 26, 2017 at 08:45:08PM +, Sargun Dhillon wrote: > This patch introduces a new mount option - qgroup_auto_cleanup. > The purpose of this mount option is to cause btrfs to automatically > delete qgroups on subvolume deletion. This only cleans up the > associated level-0 qgroup, and

Re: [PATCH] Btrfs-progs: convert: do not clear header rev

On Fri, Jun 30, 2017 at 04:52:54PM +0200, David Sterba wrote: >On Tue, Jun 27, 2017 at 12:07:13PM -0700, Liu Bo wrote: >> On Mon, Jun 26, 2017 at 05:55:02PM -0600, Liu Bo wrote: >> > So btrfs_set_header_flags() vs btrfs_set_header_flag, the difference is >> > sort of >> > similar to "=" vs "|=",

Re: How to fix errors that check --mode lomem finds, but --mode normal doesn't?

On Thu, Jun 29, 2017 at 08:30:35AM -0700, Marc MERLIN wrote: >On Thu, Jun 29, 2017 at 09:36:15PM +0800, Lu Fengqi wrote: >> On Wed, Jun 28, 2017 at 07:43:48AM -0700, Marc MERLIN wrote: >> >[cc trimmed] >> > >> >On Wed, Jun 28, 2017 at 03:10:27PM +0800, Lu Fengqi wrote: >> >> Because the output is

Re: [PATCH] Btrfs-progs: convert: do not clear header rev

On Tue, Jun 27, 2017 at 12:07:13PM -0700, Liu Bo wrote: > On Mon, Jun 26, 2017 at 05:55:02PM -0600, Liu Bo wrote: > > So btrfs_set_header_flags() vs btrfs_set_header_flag, the difference is > > sort of > > similar to "=" vs "|=", when creating and initialising a new extent buffer, > > convert

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Fri, Jun 30, 2017 at 08:16:20AM -0400, E V wrote: > On Thu, Jun 29, 2017 at 3:41 PM, Nick Terrell wrote: > > Add zstd compression and decompression support to BtrFS. zstd at its > > fastest level compresses almost as well as zlib, while offering much > > faster compression and

Re: [proposal] making filesystem tools more machine friendly

Le Fri, 30 Jun 2017 10:17:17 +0200 Jan Tulak écrivait: > A structured output is something we should aim for. It helps a lot > with the issues and it is the cheapest option. If it goes well, it can > be later on followed by creating a library, although, at this moment, > that

Branch for 4.13 pull request has been updated

Hi, the branch for 4.13 pull request has been updated, now contains a better fix for the dir item validation, though that still failed generic/066. Will be fixed. Newly added fixes for the intended 1st batch: Jan Kara (1): btrfs: Don't clear SGID when inheriting ACLs Qu Wenruo (1):

Re: [PATCH v2 3/4] btrfs: Add zstd support

On Thu, Jun 29, 2017 at 3:41 PM, Nick Terrell wrote: > Add zstd compression and decompression support to BtrFS. zstd at its > fastest level compresses almost as well as zlib, while offering much > faster compression and decompression, approaching lzo speeds. > > I benchmarked

Cannot mount btrfs file system

I have been running btrfs without problems for years on an up to date Sabayon Linux. The btrfs filesystem is on a luks encrypted partition sdb4, and indludes subvolumes for root, home and swap Following the latest upgrade to the Distro I shut the machine down. When I cae to reboot it failed to

[proposal] making filesystem tools more machine friendly

AKA filesystem API Hi guys Currently, filesystem tools are not made with automation in mind. So any tool that wants to interact with filesystems (be it for automation, or to provide a more user-friendly interface) has to screen scrape everything and cope with changing outputs. I think it is the

Re: [PATCH 1/3] btrfs: convert while loop to list_for_each_entry

On Tue, Jun 27, 2017 at 10:02:24AM +0300, Nikolay Borisov wrote: > No functional changes, just make the loop a bit more readable > > Signed-off-by: Nikolay Borisov 1-3 reviewed and added. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of

Re: [PATCH v3] btrfs: remove unused sectorsize member

On Wed, Jun 28, 2017 at 11:05:22AM +0300, Nikolay Borisov wrote: > The sectorsize member of btrfs_block_group_cache is unused. So remove it, this > reduces the number of holes in the struct. > > With patch: > /* size: 856, cachelines: 14, members: 40 */ > /* sum members: 837, holes: 4, sum holes:

Re: [PATCH] Btrfs-progs: convert: do not clear nodatasum flag in inode item

On Wed, Jun 28, 2017 at 03:29:49PM -0600, Liu Bo wrote: > With the current btrfs-convert, if we convert a ext4 without data checksum, > it'd not set nodatasum flag in inode item, nor create csum item, reading > file ends up with checksum errors. > > Signed-off-by: Liu Bo

Re: [PULL] Btrfs for 4.13, part 1

On Wed, Jun 28, 2017 at 09:49:49AM +0300, Nikolay Borisov wrote: > Dave I run bisection of all failures between -rc6 and your > pull request and here are the results: > > btrfs/048 - e79a33270d05 ("btrfs: Check name_len with boundary in verify > dir_item") > btrfs/053 - b780e22768d3 ("btrfs:

Re: [PATCH v2 0/4] Add xxhash and zstd modules

On Thu, Jun 29, 2017 at 12:41:04PM -0700, Nick Terrell wrote: > lib/zstd/Makefile | 18 + > lib/zstd/bitstream.h | 374 + > lib/zstd/compress.c| 3479 > > lib/zstd/decompress.c | 2526