, so I guess this isn't a very important thing to do :).
It only seems to hit if you give -[cx] before -i. I guess only very
few people use these options in the first place. They are primarily
for hosting providers.
Reviewed-by: Arne Jansen sensi...@gmx.net
Signed-off-by: Zach Brown z
)
{
- struct btrfs_qgroup *qgroup = find_qgroup_rb(fs_info, qgroupid);
- struct btrfs_qgroup_list *list;
+ struct btrfs_qgroup_list *list = NULL;
Why do you initialize list to NULL here? It's always assigned
before used.
otherwise,
Reviewed-by: Arne Jansen sensi...@gmx.net
- if (!qgroup
);
- if (!quota_root) {
- ret = -EINVAL;
- goto out;
- }
-
ret = btrfs_clean_quota_tree(trans, quota_root);
if (ret)
goto out;
Reviewed-by: Arne Jansen sensi...@gmx.net
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs
On 07.08.2013 23:43, Sergei Trofimovich wrote:
From: Sergei Trofimovich sly...@gentoo.org
Found by uselex.rb:
btrfs_reada_detach: [R]: exported from: fs/btrfs/btrfs.o fs/btrfs/built-in.o
fs/btrfs/reada.o
even though the function is currently unused, I'm hesitating to remove it
as it's part
On 08/08/13 19:46, Zach Brown wrote:
even though the function is currently unused, I'm hesitating to remove it
as it's part of the reada-API and might be handy for anyone going to use
the API in the future.
I agree. As replied here,
On 05.08.2013 18:35, Tomasz Chmielewski wrote:
I am trying to use qgroups
functionality with a basic random-write workload, it constantly
keeps leaking memory within few minutes of IO, there is either
out-of-memory killer trying to kill some tasks or there are
page-allocation failures that
On 07/29/13 10:05, Tomasz Chmielewski wrote:
On Mon, 10 Jun 2013 09:41:39 +0200
Arne Jansen sensi...@gmx.net wrote:
Now, my questions:
- what do both 104882176 104882176 numbers represent?
The first number represents the amount of data in that subvolume,
regardless whether that data
On 07/31/13 07:39, Tomasz Chmielewski wrote:
On Wed, 31 Jul 2013 13:13:37 +0800
Wang Shilong wangsl.f...@cn.fujitsu.com wrote:
# git pull origin master
Oops, i am sorry, here should:
git pull origin qgroup
would you please try it again
Excellent, it works:
# btrfs qgroup show -p
On 10.06.2013 08:21, Tomasz Chmielewski wrote:
I'm trying to use btrfs quotas, but I'm unable to find reliable
documentation on its usage.
Let's start with an empty subvolume:
- assign 200 MB space to it:
# btrfs qgroup limit 200m /mnt/btrfs-backup/tester/
- see the usage:
#
On 07.06.2013 16:50, Eric Sandeen wrote:
On 6/7/13 5:29 AM, Dave Chinner wrote:
On Fri, Jun 07, 2013 at 09:18:58AM +0200, Jan Schmidt wrote:
(cc Arne for far-progs discussion)
On Thu, June 06, 2013 at 19:54 (+0200), Eric Sandeen wrote:
On 6/6/13 10:20 AM, Jan Schmidt wrote:
Basic send /
On 05.06.2013 04:09, Jörn Engel wrote:
On Tue, 4 June 2013 14:44:35 -0400, Jörn Engel wrote:
Or while_list_drain?
I'm fine with while_list_drain, although a name starting with list_
like all other list macros would be nice. How about just list_drain?
The next question is where to put it in the
On 06/04/13 16:53, Chris Mason wrote:
Quoting Christoph Hellwig (2013-06-04 10:48:56)
On Mon, Jun 03, 2013 at 03:55:55PM -0400, J??rn Engel wrote:
Actually, when I compare the two invocations, I prefer the
list_for_each_entry_del() variant over list_pop_entry().
while ((ref =
On 09.05.2013 17:14, Remco Hosman - Yerf IT wrote:
kernel: 3.9.0
btrfs-progs: pulled from git this morning
Trying to receive a 5gig send file. the first bit is fast, doing 10 -
50MB/sec.
then it slows down. cpu usage is 50% (dual core machine).
when i do a strace, it looks like this,
On 04/19/13 21:21, Eric Sandeen wrote:
Big patch, but all it does is add statics to functions which
are in fact static, then remove the associated dead-code fallout.
removed functions:
btrfs_iref_to_path()
__btrfs_lookup_delayed_deletion_item()
__btrfs_search_delayed_insertion_item()
On 04/20/13 19:43, Eric Sandeen wrote:
On 4/20/13 7:43 AM, Wang Shilong wrote:
From: Wang Shilong wangsl-f...@cn.fujitsu.com
ulist is a generic structure to iterate tree. we export them
just in the hope it may be used by other modules. However, until
now, it is just used by btrfs. The main
On 15.04.2013 12:37, Wang Shilong wrote:
Step to reproduce:
mkfs.btrfs disk
mount disk mnt
dd if=/dev/zero of=/mnt/data bs=1M count=10
sync
btrfs quota enable mnt
btrfs qgroup create 0/5 mnt
btrfs qgroup limit 5M 0/5 mnt
rm -f /mnt/data
sensi...@gmx.net?
You can add a Reviewed-by: Arne Jansen sensi...@gmx.net
Thanks,
Arne
Thanks,
Wang
Thanks,
Arne
qg-max_rfer) {
ret = -EDQUOT;
goto out;
}
if ((qg-lim_flags BTRFS_QGROUP_LIMIT_MAX_EXCL
On 04/05/13 23:03, Koen De Wit wrote:
When data in a file is overwritten, starting somewhere in the middle of
the file, the overwritten space is counted twice against the space usage
numbers. Is this a bug, or did I something wrong?
Neither. This is a result of how btrfs allocates and
Hello Wang,
On 03/31/13 03:44, Wang Shilong wrote:
Hello Arne, Jan,
When i run stresstest with quota enabled, i hit a panic where
btrfs_find_all_roots() is called. Would you please double check it.
On what kernel version do you hit this (git commit id preferred)?
Can you send us the
On 03/30/13 12:55, Wang Shilong wrote:
snip
On 03/29/13 14:42, Wang Shilong wrote:
From: Wang Shilong wangsl-f...@cn.fujitsu.com
Just remove the unnecessary check and assignment.
Signed-off-by: Wang Shilong wangsl-f...@cn.fujitsu.com
---
fs/btrfs/backref.c | 3 +--
1 file changed, 1
On 03/28/13 11:53, Wang Shilong wrote:
From: Wang Shilong wangsl-f...@cn.fujitsu.com
This patch introduces mutex lock 'quota_lock', and makes
all the user change for quota protected by quota_lock.
Signed-off-by: Wang Shilong wangsl-f...@cn.fujitsu.com
Reviewed-by: Miao Xie
On 03/28/13 11:54, Wang Shilong wrote:
From: Wang Shilong wangsl-f...@cn.fujitsu.com
We use mutex_lock to protect all the user change operaions.
So when we are calling find_qgroup_rb() to check whether
qgroup exists, we don't have to hold spin_lock.
Besides, when enabling/disabling
On 22.03.2013 13:03, Wang Shilong wrote:
Hello Arne,
Since quota rescan has not been implemented yet,
overflow can happen, so until now, we can have a check when
doing accounting in the kernel, if the referenced/exclusive is not
enough to delete, we just make it to be 0 and give a
On 10.03.2013 05:21, Shilong Wang wrote:
Hello, Arne
Steps to reproduce:
mkfs.btrfs disk
mount disk mnt
btrfs quota enable mnt
btrfs sub create mnt/sub
btrfs qgroup create 1/1 mnt
On 11.03.2013 14:31, Wang Shilong wrote:
Hello,
snip
In fact, i think you try to put some work on users, especially when
snapshot happens.
It is complex to track all the group's accounting when having
snapshots..See the following
commands.
btrfs sub snapshot -c
On 11.03.2013 15:15, Wang Shilong wrote:
snip
The worst thing is that i don't think users can master this magic
concept very well.
Normally users don't need very sophisticated scenarios. In fact, they
don't even need higher level quota groups, the basic tracking is
enough. In this case,
On 11.03.2013 15:35, Wang Shilong wrote:
On 11.03.2013 15:15, Wang Shilong wrote:
snip
The worst thing is that i don't think users can master this magic
concept very well.
Normally users don't need very sophisticated scenarios. In fact, they
don't even need higher level quota groups,
to reproduce this with 3.6? If it doesn't happen
there, could you try to git bisect it?
Thanks,
Arne
--Shyam
On Wed, Feb 13, 2013 at 4:52 PM, Arne Jansen sensi...@gmx.net wrote:
Hi Shyam,
I sent a patch to the list
[PATCH] Btrfs: fix crash in log replay with qgroups enabled
.
This will not limit the whole filesystem, but only the root
subvolume. To limit the whole filesystem you'd have to create
a level 1 qgroup and add all subvolumes to it.
-Arne
Signed-off-by: Wang Shilong wangsl-f...@cn.fujitsu.com
Reviewed-by: Miao Xie mi...@cn.fujitsu.com
Cc: Arne Jansen
, as it is of no technical nature.
-Arne
Signed-off-by: Wang Shilong wangsl-f...@cn.fujitsu.com
Acked-by: Miao Xie mi...@cn.fujitsu.com
Cc: Arne Jansen sensi...@gmx.net
---
fs/btrfs/ioctl.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs
On 02/22/13 07:12, Hemanth Kumar wrote:
Signed-off-by: Hemanth Kumar hemanthkuma...@gmail.com
---
299 | 38 ++
299.out | 20
2 files changed, 58 insertions(+)
create mode 100644 299
create mode 100644 299.out
diff --git
On 02/18/13 18:14, Jérôme Poulin wrote:
I experience a kernel panic with General protection fault when doing
a scrub on Kernel 3.8-rc7.
Here is a screenshot: http://tinypic.com/r/34r6nad/6
I'd love to see the first stacktrace...
The weird part is that the scrub completes from initramfs,
, Arne Jansen li...@die-jansens.de wrote:
On 02/18/13 18:14, Jérôme Poulin wrote:
I experience a kernel panic with General protection fault when doing
a scrub on Kernel 3.8-rc7.
Here is a screenshot: http://tinypic.com/r/34r6nad/6
I'd love to see the first stacktrace...
The weird part
On 12.02.2013 08:25, shyam btrfs wrote:
Hi Arne, Jan,
I am using btrfs directly from Linux 3.8rc5 (commit
949db153b6466c6f7cad5a427ecea94985927311). I am trying to use qgroups
functionality with a basic random-write workload, it constantly
keeps leaking memory within few minutes of IO,
On 12.02.2013 08:31, shyam btrfs wrote:
Also immediately after this problem, its impossible to mount the
filesystem. it consistently fails with
no luck here either. I tried a sync-heavy workload and crashed it
in the middle. mount took a while but succeeded.
Maybe your debug tree contains
On 12.02.2013 08:31, shyam btrfs wrote:
Also immediately after this problem, its impossible to mount the
filesystem. it consistently fails with
[ 2092.254428] BUG: unable to handle kernel NULL pointer dereference
at 03c4
[ 2092.255945] IP: [a033d0be]
, which is already initialized.
Signed-off-by: Arne Jansen sensi...@gmx.net
---
fs/btrfs/ctree.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index eea5da7..6eff0fa 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -1222,7
Hi Shyam,
I sent a patch to the list
[PATCH] Btrfs: fix crash in log replay with qgroups enabled
that hopefully addresses this problem. As I haven't been able to
reproduce it, I also haven't been able to test it.
Could be please see if it fixes your problem and makes the filesystem
mountable
Reported-by: Alex Lyakas alex.bt...@zadarastorage.com
Cc: Arne Jansen sensi...@gmx.net
Signed-off-by: Miao Xie mi...@cn.fujitsu.com
---
fs/btrfs/ioctl.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index
On 02/07/13 10:28, Miao Xie wrote:
On Thu, 07 Feb 2013 09:43:47 +0100, Arne Jansen wrote:
On 02/07/13 07:02, Miao Xie wrote:
The argument inherit of btrfs_ioctl_snap_create_transid() was assigned
to NULL during we created the snapshots, so we didn't free it though we
called kfree
Hi Alex,
On 02/06/13 12:18, Alex Lyakas wrote:
Hi Jan, Arne,
I see this code in create_snapshot:
if (inherit) {
pending_snapshot-inherit = *inherit;
*inherit = NULL;/* take responsibility to free it */
}
So, first thing I think it should
Hi,
On 24.01.2013 06:10, praneeth u wrote:
Hello,
We are team of 5 students, interns at Green turtles technologies,
interested in contributing to btrfs.
Any space for contribution in btrfs testing ? we will be updating
pogress twice in a week.
Need suggestions on how to proceed.
The quota
On 24.01.2013 10:39, Lev Vainblat wrote:
Hi all,
I executed the following simple sequence of commands:
# mount /dev/sda /mnt/btrfs
# btrfs quota enable /mnt/btrfs/
# btrfs subvolume create /mnt/btrfs/SV
Create subvolume '/mnt/btrfs/SV'
# btrfs qgroup limit 1m /mnt/btrfs/SV
# dd
On 24.01.2013 16:12, Jerome M wrote:
Hi,
With the current btrfs quota implementation, when you reach a
subvolume quota limit, you can't delete anything without first
removing the limit or enlarge it:
rm: cannot remove `testfile.bin': Disk quota exceeded
Is there any plan to change
Hi Eric,
thanks for reporting this. I sent a small patch series to the list
to fix this.
Sorry I forgot to CC you, will send the patches to you directly again.
It would be great if you could give it some testing.
Thanks,
Arne
On 15.01.2013 21:44, hop...@omnifarious.org wrote:
mkfs.btrfs
Hi Mark,
On 16.01.2013 23:30, Mark Fasheh wrote:
Hi,
The following 4 patches make changes to btrfs-progs in order to
provide support for external software that wants to make use of the
excellent btrfs send ioctl.
The first patch introduces support for the
On 09.01.2013 11:17, Miao Xie wrote:
Hi, Arne
On Wed, 19 Dec 2012 12:40:25 +0100, Arne Jansen wrote:
On 19.12.2012 12:25, Miao Xie wrote:
As we know, there is no backup function for qgroup. when the problem
occurs, the users must recover qgroup configuration manually, it is not
convenient
On 07.01.2013 14:01, Liu Bo wrote:
On Mon, Jan 07, 2013 at 03:48:43PM +0530, Kiran Patil wrote:
Hello,
We have a team of 5 students who would like to contribute to btrfs
filesystem testing using xfstests.
Is there space for them to contribute?
xfstests is lacking of testcases targetting
On 19.12.2012 12:25, Miao Xie wrote:
Hi, everyone.
As we know, there is no backup function for qgroup. when the problem
occurs, the users must recover qgroup configuration manually, it is not
convenient. And besides that, some users might want to import an existed
qgroup configuration into
On 01.11.2012 12:00, Gabriel wrote:
On Thu, 01 Nov 2012 06:06:57 +0100, Arne Jansen wrote:
On 11/01/2012 02:28 AM, Shane Spencer wrote:
That's Plan B. I'll be making a btrfs stream decoder and doing in
place edits. I need to move stuff around to other filesystem types
otherwise I'd just
On 11/01/2012 02:28 AM, Shane Spencer wrote:
That's Plan B. I'll be making a btrfs stream decoder and doing in
place edits. I need to move stuff around to other filesystem types
otherwise I'd just store the stream or apply the stream to a remote
snapshot.
That's the whole point of the
On 10/24/2012 06:53 PM, frantz.hacquard wrote:
Hi,
I don't know if it's the good place to ask my question.
I'm a french student who studies IT.
I'm working on a project with the btrfs filesystem on Gentoo 64 bits.
I have to create snapshots and to compare the differences between them
(new
On 15.10.2012 16:32, Chris Mason wrote:
On Sat, Oct 13, 2012 at 09:41:28AM -0600, David Sterba wrote:
On Sat, Oct 13, 2012 at 09:08:57AM +0100, Rory Campbell-Lange wrote:
Perhaps BTRFS Incremental Stream or Backup Incremental Stream should
be considered, with the file extension .bis.
From
There are some unaligned accesses in progs that cause malfunction or
crashes on ARM.
This patch fixes the ones we stumbled upon.
Signed-off-by: Arne Jansen sensi...@gmx.net
---
btrfs-list.c | 69 +++--
volumes.c|8 --
2 files
There are some unaligned accesses in progs that cause malfunction or
crashes on ARM.
This patch fixes the ones we stumbled upon.
Signed-off-by: Arne Jansen sensi...@gmx.net
---
Change v1-v2:
Somehow sent the wrong patch without the patch to the setget functions.
---
btrfs-list.c | 69
The tool can also generate a manifest file. Given the manifest file, it
can determine which files are missing or in excess, and inform about
metadata / data checksum mismatches.
It builds for linux and solaris.
Signed-off-by: Arne Jansen sensi...@gmx.net
---
It can also be found at
git
The tool can also generate a manifest file. Given the manifest file, it
can determine which files are missing or in excess, and inform about
metadata / data checksum mismatches.
It builds for linux and solaris.
Signed-off-by: Arne Jansen sensi...@gmx.net
---
It can also be found at
git
When sending a device file, the stream was missing the mode. Also the
rdev was encoded wrongly.
Signed-off-by: Arne Jansen sensi...@gmx.net
---
fs/btrfs/send.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index c7beb54..57933e8
On 10/12/12 15:32, Arne Jansen wrote:
The idea of the btrfs send stream format was to generate it in a way that
it is easy to receive on different platforms. Thus the proposed name FITS, for
Filesystem Incremental Backup Stream. We should also build the tools to
receive the stream
Simple tool to parse a fits-stream from stdout.
Signed-off-by: Arne Jansen sensi...@gmx.net
---
The idea of the btrfs send stream format was to generate it in a way that
it is easy to receive on different platforms. Thus the proposed name FITS, for
Filesystem Incremental Backup Stream. We should
is completely self contained. The idea was that it just builds on every
platform.
-Arne
Regards,
Andrey
12.10.2012 17:33 пользователь Arne Jansen sensi...@gmx.net
mailto:sensi...@gmx.net написал:
Simple tool to parse a fits-stream from stdout.
Signed-off-by: Arne Jansen sensi...@gmx.net
On 09.10.2012 09:13, matthieu Barthélemy wrote:
On Mon, Oct 8, 2012 at 9:51 PM, Arne Jansen sensi...@gmx.net wrote:
On 10/08/12 21:31, matthieu Barthélemy wrote:
Are there any plan to maybe get a better 'btrfs quota show' output?
Definitely. The first priority was to get the kernel part
On 10/08/12 21:31, matthieu Barthélemy wrote:
Are there any plan to maybe get a better 'btrfs quota show' output?
Definitely. The first priority was to get the kernel part running, when
that is settled, we can improve the user mode part. There's also still
some work to do to make the tracking
On 10/08/12 18:30, Rory Campbell-Lange wrote:
I can send snapshots to volume, but not volume/dir. Please advise
if what I am doing is incorrect.
Rory
Format usb3 disk and mount
root@orchard:/bkp# mkfs.btrfs /dev/sdb1
WARNING! - Btrfs v0.20-rc1-37-g91d9eec IS EXPERIMENTAL
On 29.09.2012 23:48, Diego Calleja wrote:
On Viernes, 10 de agosto de 2012 15:51:07 Jan Schmidt escribió:
From: Arne Jansen sensi...@gmx.net
Signed-off-by: Jan Schmidt list.bt...@jan-o-sch.net
Signed-off-by: Arne Jansen sensi...@gmx.net
---
This is the rebased version of Arne's qgroup patch
On 04.10.2012 11:26, David Sterba wrote:
@@ -207,16 +266,23 @@ EXPORT_SYMBOL(ulist_add);
* end is reached. No guarantee is made with respect to the order in which
* the elements are returned. They might neither be returned in order of
* addition nor in ascending order.
- * It is allowed
On 02.10.2012 17:27, Josef Bacik wrote:
On Tue, Oct 02, 2012 at 09:05:43AM -0600, David Sterba wrote:
On Tue, Oct 02, 2012 at 10:32:32AM -0400, Josef Bacik wrote:
On Tue, Oct 02, 2012 at 08:25:38AM -0600, David Sterba wrote:
Hi,
On Mon, Sep 24, 2012 at 04:02:59PM -0400, Josef Bacik wrote:
On 07/04/12 13:04, Alexander Block wrote:
On Wed, Jul 4, 2012 at 9:56 AM, Li Zefan lize...@huawei.com wrote:
On 2012/7/4 15:18, chandan r wrote:
This patch adds a new member to the 'struct btrfs_inode' structure to hold
the file creation time.
Well, how do users use this file creation
On 09/24/12 20:11, Josef Bacik wrote:
The reason we offload csumming is because it is CPU intensive, except it is
not on modern intel CPUs. So check to see if we support hardware crc32c,
and if we do just do the csumming in our current threads context. Otherwise
we can farm it off. Thanks,
On 09/22/12 05:38, Jp Wise wrote:
Good morning, I'm working on an offline deduplication script intended to
work around the copy-on-write functionality of BTRFS.
Simply put - is there any existing utility to compare two files (or
dirs) and output if the files share the same physical extents /
On 11.09.2012 07:24, Marios Titas wrote:
On Fri, Sep 7, 2012 at 6:04 PM, Arne Jansen sensi...@gmx.net wrote:
Hi Andreas,
Thanks for giving quota a try. I sent a fix separately with
the subject
[PATCH] Btrfs: btrfs_qgroup_inherit wrongly returns an error
Could you please see if it fixes
This reverts commit 5986802c2fcc754040bb7ed95f30bb16c4a843b7.
Both paths are not error paths but regular cases where non-qgroup
subvols are involved.
Signed-off-by: Arne Jansen sensi...@gmx.net
---
fs/btrfs/qgroup.c |8 ++--
1 files changed, 2 insertions(+), 6 deletions(-)
diff --git
On 11.09.2012 01:38, Jan Engelhardt wrote:
On Tuesday 2012-09-11 01:09, Martin Steigerwald wrote:
What about:
- copy first backup version
- btrfs subvol create first next
- copy next backup version
- btrfs subvol create previous next
Wouldn't btrfs subvolume snapshot, plus rsync
On 09/10/2012 08:13 PM, Andreas Philipp wrote:
Hi Arne,
On 08.09.2012 00:04, Arne Jansen wrote:
Hi Andreas,
On 09/07/2012 09:36 PM, Andreas Philipp wrote:
Hi,
The following steps reproduce the error. My kernel is 3.6-rc4 and
btrfs-progs are at commit
When using the V1-version of the snap/subvol creation ioctl
btrfs_qgroup_inherit wrongly returns an error because no inherit parameter
is given. Fix the return value.
Signed-off-by: Arne Jansen sensi...@gmx.net
---
fs/btrfs/qgroup.c |4 +---
1 files changed, 1 insertions(+), 3 deletions
Hi Andreas,
On 09/07/2012 09:36 PM, Andreas Philipp wrote:
Hi,
The following steps reproduce the error. My kernel is 3.6-rc4 and
btrfs-progs are at commit 89fe5b5f666c247aa3173745fb87c710f3a71a4a
from
git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git
master.
thor
On 16.08.2012 09:57, Wang Sheng-Hui wrote:
For malloc may fail, we should check it before assign
values to the fields of struct btrfs_trans_handle *h.
Signed-off-by: Wang Sheng-Hui shh...@gmail.com
---
transaction.h |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff
On 16.08.2012 15:17, Wang Sheng-Hui wrote:
Add code indent to the bad styled statements.
Signed-off-by: Wang Sheng-Hui shh...@gmail.com
---
root-tree.c | 10 --
1 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/root-tree.c b/root-tree.c
index 782472c..39cfef6
On 16.08.2012 15:26, Wang Sheng-Hui wrote:
On 2012年08月16日 21:23, Arne Jansen wrote:
On 16.08.2012 15:17, Wang Sheng-Hui wrote:
Add code indent to the bad styled statements.
Signed-off-by: Wang Sheng-Hui shh...@gmail.com
---
root-tree.c | 10 --
1 files changed, 4 insertions
With commit
commit d1270cd91f308c9d22b2804720c36ccd32dbc35e
Author: Arne Jansen sensi...@gmx.net
Date: Tue Sep 13 15:16:43 2011 +0200
Btrfs: put back delayed refs that are too new
I added a window where the delayed_ref's head-ref_mod code can diverge
from the sum of the remaining
On 09.08.2012 04:52, Marc MERLIN wrote:
On Tue, Aug 07, 2012 at 11:47:36AM -0700, Marc MERLIN wrote:
On Tue, Aug 07, 2012 at 08:14:23PM +0200, Arne Jansen wrote:
On 08/07/2012 07:40 PM, Marc MERLIN wrote:
Unfortunately I only have a screenshot.
Apparently the panic
.
The qgroups patch added code to put delayed refs back, thus opening this
window very wide.
This patch assures that head-ref_mod always matches the queued refs, but
a window still remains where on-disk refs + delayed_refs miss the ref
currently being run.
Signed-off-by: Arne Jansen sensi...@gmx.net
On 08/07/2012 07:40 PM, Marc MERLIN wrote:
Unfortunately I only have a screenshot.
Apparently the panic was in
btrfs_set_lock_blocking_rw
with a RIP in btrfs_cow_block
Can you please resolve btrfs_cow_block+0x3b to a line number?
gdb btrfs.ko
(gdb) info line *btrfs_cow_block+0x3b
On 08/06/2012 10:10 PM, Chris Mason wrote:
On Fri, Aug 03, 2012 at 01:11:31AM -0600, Alexander Block wrote:
I got a deadlock happening while creating a snapshot and ordered
writes are pending. I can reproduce it 100% using btrfs send/receive.
It happens when I receive a set of streams on a
are blocked.
Signed-off-by: Arne Jansen sensi...@gmx.net
---
fs/btrfs/ctree.c |6
fs/btrfs/ctree.h |1 -
fs/btrfs/delayed-ref.c |8 -
fs/btrfs/disk-io.c |2 -
fs/btrfs/extent-tree.c | 77 +---
5 files changed, 21
On 08/07/2012 07:03 AM, Mitch Harder wrote:
On Mon, Aug 6, 2012 at 3:18 PM, Arne Jansen sensi...@gmx.net wrote:
Commit a168650c introduced a waiting mechanism to prevent busy waiting in
btrfs_run_delayed_refs. This can deadlock with btrfs_run_ordered_operations,
where a tree_mod_seq is held
not complain anymore.
Tested-by: Arne Jansen sensi...@gmx.net
---
fs/btrfs/extent-tree.c | 15 +++
1 files changed, 7 insertions(+), 8 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 45c69c4..55d33b8 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs
On 08/03/2012 04:43 PM, Mitch Harder wrote:
On Wed, Aug 1, 2012 at 7:21 PM, Mitch Harder
mitch.har...@sabayonlinux.org wrote:
On Wed, Aug 1, 2012 at 3:25 PM, Josef Bacik jba...@fusionio.com wrote:
We need an smb_mb() before waitqueue_active to avoid missing wakeups.
Before Mitch was hitting a
On 02.08.2012 12:36, Liu Bo wrote:
On 08/02/2012 06:30 PM, Stefan Behrens wrote:
On Wed, 01 Aug 2012 16:31:54 +0200, Stefan Behrens wrote:
On Wed, 01 Aug 2012 21:31:58 +0800, Liu Bo wrote:
On 08/01/2012 09:07 PM, Jan Schmidt wrote:
On Wed, August 01, 2012 at 14:02 (+0200), Liu Bo wrote:
On
On 02.08.2012 13:34, Liu Bo wrote:
On 08/02/2012 07:18 PM, Arne Jansen wrote:
On 02.08.2012 12:36, Liu Bo wrote:
On 08/02/2012 06:30 PM, Stefan Behrens wrote:
On Wed, 01 Aug 2012 16:31:54 +0200, Stefan Behrens wrote:
On Wed, 01 Aug 2012 21:31:58 +0800, Liu Bo wrote:
On 08/01/2012 09:07 PM
On 02.08.2012 15:57, David Sterba wrote:
On Thu, Aug 02, 2012 at 03:46:50PM +0200, Arne Jansen wrote:
Anyway, for now, our error flag has only been stored in memory, so what
about just keep it until we find a graceful way?
Yeah, we need this patch to restore consistency. We can define a fixed
On 01.08.2012 15:31, Liu Bo wrote:
On 08/01/2012 09:07 PM, Jan Schmidt wrote:
On Wed, August 01, 2012 at 14:02 (+0200), Liu Bo wrote:
On 08/01/2012 07:45 PM, Stefan Behrens wrote:
With commit acce952b0, btrfs was changed to flag the filesystem with
BTRFS_SUPER_FLAG_ERROR and switch to
On 23.07.2012 21:41, Alexander Block wrote:
On Mon, Jul 16, 2012 at 4:56 PM, Arne Jansen sensi...@gmx.net wrote:
On 04.07.2012 15:38, Alexander Block wrote:
+
+ ret = btrfs_update_root(trans, root-fs_info-tree_root,
+ root-root_key, root-root_item
On 07/04/2012 03:38 PM, Alexander Block wrote:
This patch introduces the BTRFS_IOC_SEND ioctl that is
required for send. It allows btrfs-progs to implement
full and incremental sends. Patches for btrfs-progs will
follow.
I had to split the patch as it got larger then 100k which is
the
, I just wanted to get that patch
set out :-)
Thanks,
-Jan
Arne Jansen (11):
Btrfs: qgroup on-disk format
Btrfs: add helper for tree enumeration
Btrfs: check the root passed to btrfs_end_transaction
Btrfs: added helper to create new trees
Btrfs: qgroup state and initialization
looks better. It gives back the merging capability without too much
fiddling with sequences. Although I still think something else is fishy when
merges are needed for correct functionality, this patch seems to fix it while
having additional benefits. Thanks for working on it :)
Acked-by: Arne Jansen
Any news on this? I you give me some hints, I can try to reproduce
it here.
-Arne
On 10.07.2012 08:57, Arne Jansen wrote:
On 10.07.2012 06:16, Sami Liedes wrote:
On Mon, Jul 09, 2012 at 11:05:47AM +0200, Arne Jansen wrote:
* Just before the crash:
btrfs: invalid parameters
on it :)
Acked-by: Arne Jansen sensi...@gmx.net
fs/btrfs/delayed-ref.c | 152
+++-
fs/btrfs/delayed-ref.h |3 +
fs/btrfs/extent-tree.c |9 +++
3 files changed, 137 insertions(+), 27 deletions(-)
diff --git a/fs/btrfs/delayed-ref.c b/fs/btrfs/delayed
On 04.07.2012 15:38, Alexander Block wrote:
This patch introduces uuids for subvolumes. Each
subvolume has it's own uuid. In case it was snapshotted,
it also contains parent_uuid. In case it was received,
it also contains received_uuid.
It also introduces subvolume ctime/otime/stime/rtime.
On 10.07.2012 06:16, Sami Liedes wrote:
On Mon, Jul 09, 2012 at 11:05:47AM +0200, Arne Jansen wrote:
* Just before the crash:
btrfs: invalid parameters for read_extent_buffer: start (32771) eb-len
(32768). eb start is 2261163409408, level 100, generation
4412718571037421157, nritems 538968254. len
1 - 100 of 366 matches
Mail list logo