Re: Btrfs progs release 4.7.1

2016-08-26 Thread Luis Henriques 
David Sterba <dste...@suse.cz> writes:

> On Fri, Aug 26, 2016 at 12:24:10AM +0100, Luis Henriques wrote:
>> On Thu, Aug 25, 2016 at 07:47:27PM +0200, David Sterba wrote:
>> > Hi,
>> > 
>> > btrfs-progs 4.7 have been released. Though it's a minor version release, 
>> > there
>> > are changes that could be considered big but I don't see a reason to hold 
>> > them
>> > until 4.8 is released.
>> ...
>> > Tarballs: https://www.kernel.org/pub/linux/kernel/people/kdave/btrfs-progs/
>> > Git: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git
>> 
>> Looks like the master branch has not been pushed, although I can see the 
>> v4.7.1
>> (and thus I can actually git reset to this release).
>
> Now pushed.

Cool, thanks!

Cheers,
-- 
Luís
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Btrfs progs release 4.7.1

2016-08-25 Thread Luis Henriques 
On Thu, Aug 25, 2016 at 07:47:27PM +0200, David Sterba wrote:
> Hi,
> 
> btrfs-progs 4.7 have been released. Though it's a minor version release, there
> are changes that could be considered big but I don't see a reason to hold them
> until 4.8 is released.
...
> Tarballs: https://www.kernel.org/pub/linux/kernel/people/kdave/btrfs-progs/
> Git: git://git.kernel.org/pub/scm/linux/kernel/git/kdave/btrfs-progs.git

Looks like the master branch has not been pushed, although I can see the v4.7.1
(and thus I can actually git reset to this release).

Cheers,
--
Luís
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] btrfs: Fix warning "variable ‘blocksize’ set but not used"

2016-08-23 Thread Luis Henriques 
Variable 'blocksize' in reada_walk_down() is not used since commit
d3e46fea1b1e ("btrfs: sink blocksize parameter to readahead_tree_block").
This patch simply removes this variable.

Signed-off-by: Luis Henriques <luis.henriq...@canonical.com>
---
 fs/btrfs/extent-tree.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
index 61b494e8e604..41d03a50056f 100644
--- a/fs/btrfs/extent-tree.c
+++ b/fs/btrfs/extent-tree.c
@@ -8450,7 +8450,6 @@ static noinline void reada_walk_down(struct 
btrfs_trans_handle *trans,
u64 refs;
u64 flags;
u32 nritems;
-   u32 blocksize;
struct btrfs_key key;
struct extent_buffer *eb;
int ret;
@@ -8468,7 +8467,6 @@ static noinline void reada_walk_down(struct 
btrfs_trans_handle *trans,
 
eb = path->nodes[wc->level];
nritems = btrfs_header_nritems(eb);
-   blocksize = root->nodesize;
 
for (slot = path->slots[wc->level]; slot < nritems; slot++) {
if (nread >= wc->reada_count)
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] btrfs: Fix warning "variable ‘gen’ set but not used"

2016-08-23 Thread Luis Henriques 
Variable 'gen' in reada_for_search() is not used since commit 58dc4ce43251
("btrfs: remove unused parameter from readahead_tree_block").  This patch
simply removes this variable.

Signed-off-by: Luis Henriques <luis.henriq...@canonical.com>
---
 fs/btrfs/ctree.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index d1c56c94dd5a..dcd39cca7e43 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -2268,7 +2268,6 @@ static void reada_for_search(struct btrfs_root *root,
u64 search;
u64 target;
u64 nread = 0;
-   u64 gen;
struct extent_buffer *eb;
u32 nr;
u32 blocksize;
@@ -2313,7 +2312,6 @@ static void reada_for_search(struct btrfs_root *root,
search = btrfs_node_blockptr(node, nr);
if ((search <= target && target - search <= 65536) ||
(search > target && search - target <= 65536)) {
-   gen = btrfs_node_ptr_generation(node, nr);
readahead_tree_block(root, search);
nread += blocksize;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] btrfs-progs: tests: 006-image-on-missing-device: fix btrfs tool path

2016-07-04 Thread Luis Henriques 
If btrfs isn't in the path, this test will fail with:

[TEST/misc]   006-image-on-missing-device
failed: btrfs fi show /dev/loop0
test failed for case 006-image-on-missing-device
Makefile:226: recipe for target 'test-misc' failed
make: *** [test-misc] Error 1

Fix the test script by adding $TOP to the path.

Signed-off-by: Luis Henriques <hen...@camandro.org>
---
 tests/misc-tests/006-image-on-missing-device/test.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/misc-tests/006-image-on-missing-device/test.sh 
b/tests/misc-tests/006-image-on-missing-device/test.sh
index 8680a707afbb..dd02d93e5fdd 100755
--- a/tests/misc-tests/006-image-on-missing-device/test.sh
+++ b/tests/misc-tests/006-image-on-missing-device/test.sh
@@ -61,12 +61,12 @@ test_run()
run_check $SUDO_HELPER umount $TEST_MNT
 
test_image_dump
-   run_check btrfs fi show $dev1
+   run_check $TOP/btrfs fi show $dev1
# create a degraded raid1 filesystem, check must succeed
# btrfs-image must not loop
run_mayfail wipefs -a $dev2
run_check $SUDO_HELPER losetup -d $dev2
-   run_check btrfs fi show $dev1
+   run_check $TOP/btrfs fi show $dev1
 
test_image_dump
 }
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH] btrfs-progs: tests: 001-simple-unmounted: fix test failure due to bashism

2016-06-24 Thread Luis Henriques 
The usage of 'source' is a bashism, and '.' should be used instead.  This
is causing fuzz-tests/001-simple-unmounted to fail in systems where
/bin/sh isn't bash:

[TEST/fuzz]   001-simple-unmounted
./test.sh: 5: ./test.sh: source: not found
./test.sh: 7: ./test.sh: setup_root_helper: not found
./test.sh: 8: ./test.sh: check_prereq: not found
./test.sh: 18: ./test.sh: check_all_images: not found

Since most (all?) tests actually use /bin/bash, change this test to use
bash too.

Signed-off-by: Luis Henriques <hen...@camandro.org>
---
 tests/fuzz-tests/001-simple-unmounted/test.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/fuzz-tests/001-simple-unmounted/test.sh 
b/tests/fuzz-tests/001-simple-unmounted/test.sh
index bf01a3a45a96..98fe7b0ccb74 100755
--- a/tests/fuzz-tests/001-simple-unmounted/test.sh
+++ b/tests/fuzz-tests/001-simple-unmounted/test.sh
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
 
 # iterate over all fuzzed images and run 'btrfs check'
 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Btrfs stable updates for 4.0

2015-06-17 Thread Luis Henriques 
On Thu, Jun 11, 2015 at 06:06:32PM +0200, David Sterba wrote:
 Hi,
 
 please queue the following patches to 4.0 stable. There are fixes for user
 visible bugs and one usability regression with RAID1 - single conversion
 during balance.
 
 One of the patches does not apply cleanly to 4.0.5, there's a minor conflict 
 in
 patch context (153c35b60c72de9fae06c8e2c8b2c47d79d4, the last one). A 
 reply
 to this mail is the adapted version or you can pull/cherry-pick from
 
   git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-stable-4.0
 
 Subjects:
   Btrfs: send, add missing check for dead clone root
   Btrfs: send, don't leave without decrementing clone root's send_progress
   btrfs: incorrect handling for fiemap_fill_next_extent return
   btrfs: cleanup orphans while looking up default subvolume
   Btrfs: fix range cloning when same inode used as source and destination
   Btrfs: fix uninit variable in clone ioctl
   Btrfs: fix regression in raid level conversion
 Commits:
   5cc2b17e80cf5770f2e585c2d90fd8af1b901258 # 3.14+
   2f1f465ae6da244099af55c066e5355abd8ff620 # 3.14+
   26e726afe01c1c82072cf23a5ed89ce25f39d9f2 # 3.10+
   727b9784b6085c99c2f836bf4fcc2848dc9cf904 # 3.14+

Thanks, I'm applying the above commits to 3.16 kernel as well.

Cheers,
--
Luís

   df858e76723ace61342b118aa4302bd09de4e386 # 4.0+
   de249e66a73d69281cd812087979c6fae552 # 4.0+
   153c35b60c72de9fae06c8e2c8b2c47d79d4 # 4.0+
 
 Thanks.
 --
 To unsubscribe from this list: send the line unsubscribe stable in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Please add 9c4f61f01d269815bb7c37be3ede59c5587747c6 to stable

2015-04-06 Thread Luis Henriques 
On Thu, Apr 02, 2015 at 10:17:47AM -0400, Chris Mason wrote:
 Hi stable friends,
 
 Can you please backport this one to 3.19.y.  It fixes a bug introduced by:
 
 381cf6587f8a8a8e981bc0c18859b51dc756, which was tagged for stable 3.14+
 
 The symptoms of the bug are deadlocks during log reply after a crash.  The
 patch wasn't intentionally fixing the deadlock, which is why we missed it
 when tagging fixes.
 
 Please put this commit everywhere you've cherry-picked
 381cf6587f8a8a8e981bc0c18859b51dc756
 

Thank you, I'll queue this fix for the 3.16 kernel.

Cheers,
--
Luís

 commit 9c4f61f01d269815bb7c37be3ede59c5587747c6
 Author: David Sterba dste...@suse.cz
 Date:   Fri Jan 2 19:12:57 2015 +0100
 
btrfs: simplify insert_orphan_item
 
We can search and add the orphan item in one go,
btrfs_insert_orphan_item will find out if the item already exists.
 
Signed-off-by: David Sterba dste...@suse.cz
 
 -chris
 
 
 
 --
 To unsubscribe from this list: send the line unsubscribe stable in
 the body of a message to majord...@vger.kernel.org
 More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: Btrfs stable updates for 3.12

2013-12-19 Thread Luis Henriques 
On Thu, Dec 19, 2013 at 02:08:51PM +0100, David Sterba wrote:
 On Wed, Dec 18, 2013 at 12:51:54PM -0800, Greg KH wrote:
  On Wed, Dec 18, 2013 at 04:14:02PM +0100, David Sterba wrote:
   Hi,
   
   please queue the following patches to 3.12 stable. They fix a few
   crashes or lockups that were reported by users.
   
   The patch stop using vfs_read in send may seem big for stable, but 
   without it
   the send/receive ioctl hits the global open file limit sooner or later,
   depending on the ram size.
   
   Subjects:
   Btrfs: do a full search everytime in btrfs_search_old_slot
   Btrfs: reset intwrite on transaction abort
   Btrfs: fix memory leak of chunks' extent map
   Btrfs: fix hole check in log_one_extent [bug 1]
   Btrfs: fix incorrect inode acl reset
   Btrfs: stop using vfs_read in send
   Btrfs: take ordered root lock when removing ordered operations 
   inode
   Btrfs: do not run snapshot-aware defragment on error
   Btrfs: fix a crash when running balance and defrag concurrently
   Btrfs: fix lockdep error in async commit
   Commits:
   d4b4087c43cc00a196c5be57fac41f41309f1d56
   e0228285a8cad70e4b7b4833cc650e36ecd8de89
   7d3d1744f8a7d62e4875bd69cc2192a939813880
   ed9e8af88e2551aaa6bf51d8063a2493e2d71597
   8185554d3eb09d23a805456b6fa98dcbb34aa518
   ed2590953bd06b892f0411fc94e19175d32f197a
   93858769172c4e3678917810e9d5de360eb991cc
   6f519564d7d978c00351d9ab6abac3deeac31621
   48ec47364b6d493f0a9cdc116977bf3f34e5c3ec
   b1a06a4b574996692b72b742bf6e6aa0c711a948
   
   all apply cleanly on top of 3.12.5.
  
  all now applied, along with 4 of these that seem to be applicable to
  3.10-stable.
 
 Yes, the 4 from stable-queue/3.10 are ok for 3.10, and for 3.11 if that
 matters.

Thanks, I'm queuing for 3.11 the same commits Greg has applied to the
3.10.

Cheers,
--
Luis
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html