Re: [PATCH] Btrfs-progs new btrfs_error() macro to deprecate fprintf(stderr, ...)

2011-02-10 Thread Eduardo Silva
On Thu, 2011-02-10 at 16:07 +0100, Hubert Kario wrote: > On Thursday, February 10, 2011 15:54:55 Eduardo Silva wrote: > > Hi, > > > > This patch add a new macro called btrfs_error(...) which deprecate the > > use of fprintf(stderr, ...) > > > > regards, &

Re: [PATCH] Btrfs-progs use safe string manipulation functions

2011-02-10 Thread Eduardo Silva
On Thu, 2011-02-10 at 14:52 +0100, Olaf van der Spek wrote: > On Thu, Feb 10, 2011 at 2:37 PM, Eduardo Silva > wrote: > > string_copy seems pointless, it's kinda equivalent to strcpy. > > > > Yeah, but if we are thinking into write some wrappers let's create

Re: [PATCH] Btrfs-progs use safe string manipulation functions

2011-02-10 Thread Eduardo Silva
On Thu, 2011-02-10 at 14:34 +0100, Olaf van der Spek wrote: > On Thu, Feb 10, 2011 at 2:29 PM, Eduardo Silva > wrote: > >> > There's strlcpy, but it's not in glibc because of possible truncation > >> > errors! > >> > >> The

Re: [PATCH] Btrfs-progs use safe string manipulation functions

2011-02-10 Thread Eduardo Silva
f strncpy(3) both function compose safe NULL terminated strings. ---- I check that the code most of the time raise an error if the path is too long, so the new wrappers should be ok... best, Eduardo Silva >From 6e551f4d9482a438beb336c4ec3a54735a15b76c Mon Sep 17 00:00:00 2001 From: Edua

Re: [PATCH] Btrfs-progs use safe string manipulation functions

2011-02-10 Thread Eduardo Silva
On Thu, 2011-02-10 at 12:08 +0100, Thomas Bellman wrote: > On 2011-02-07 13:22, Eduardo Silva wrote: > > > Please find the attached patch which replace unsafe strcpy(3) by > > strncpy(3) functions. > > strncpy() doesn't NUL-terminate the destination buffer if th

[PATCH] Btrfs-progs use safe string manipulation functions

2011-02-07 Thread Eduardo Silva
Please find the attached patch which replace unsafe strcpy(3) by strncpy(3) functions. regards, Eduardo Silva >From 5fc888c71981e4b74ba29dd53bf0d5a65b3ee504 Mon Sep 17 00:00:00 2001 From: Eduardo Silva Date: Mon, 7 Feb 2011 08:55:04 -0300 Subject: [PATCH] [PATCH] Btrfs-progs use safe str