Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-30 Thread Jie Liu
On 08/30/12 13:55, Jie Liu wrote: On 08/30/12 13:44, Anand Jain wrote: Jeff, I don't find the get label ioctl part unless I am missing something. Any idea? Sorry, I took for granted that this patch has already been merged last year. :( To honor your efforts, I'd like to re-send a revised

Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-30 Thread Jie Liu
On 08/30/12 14:28, Anand Jain wrote: The original patch could be revised with this support easily. How about using one structure and one ioctl number for both of them? i.e, #define BTRFS_IOC_FSLABEL_CTL_IOW(BTRFS_IOCTL_MAGIC, 50, struct btrfs_ioctl_fslabel_ctl_args) #define

Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-29 Thread Jie Liu
Hi Anand, I have posted a patch for set label back to last year, which can be found at: https://patchwork.kernel.org/patch/1124642/ Besides that, we have discussed to use 50 as the ioctl(2) number at that time. task assignment in our wiki page:

Re: [PATCH] Btrfs: Add get/set label ioctl

2012-08-29 Thread Jie Liu
, Anand Jain wrote: Ah. I missed that. Thanks. So should use your original patch. -Anand On 29/08/12 17:00, Jie Liu wrote: Hi Anand, I have posted a patch for set label back to last year, which can be found at: https://patchwork.kernel.org/patch/1124642/ Besides that, we have discussed

Re: [RFC PATCH 0/5] btrfs-progs: snapshot diff function

2012-08-26 Thread Jie Liu
On 08/25/12 14:23, Alexander Block wrote: On Fri, Aug 24, 2012 at 4:15 PM, Jeff Liu jeff@oracle.com wrote: Hi Alex, Thanks for taking a look. On 08/24/2012 09:09 PM, Alex Lyakas wrote: Hi Jeff, how do you see this snapshot-diff functionality vs the send/receive functionality that was

Re: [PATCH] btrfs-progs: add malloc check in transaction.h/btrfs_start_transaction

2012-08-16 Thread Jie Liu
On 08/16/12 16:03, Arne Jansen wrote: On 16.08.2012 09:57, Wang Sheng-Hui wrote: For malloc may fail, we should check it before assign values to the fields of struct btrfs_trans_handle *h. Signed-off-by: Wang Sheng-Hui shh...@gmail.com --- transaction.h |5 + 1 files changed, 5