Re: [PATCH v4 3/3] btrfs: zoned: automatically reclaim zones

2021-04-16 Thread David Sterba
On Thu, Apr 15, 2021 at 10:58:35PM +0900, Johannes Thumshirn wrote: > @@ -2974,6 +2982,9 @@ void btrfs_init_fs_info(struct btrfs_fs_info *fs_info) > fs_info->swapfile_pins = RB_ROOT; > > fs_info->send_in_progress = 0; > + > + fs_info->bg_reclaim_threshold = 75; The value should b

Re: [PATCH v4 3/3] btrfs: zoned: automatically reclaim zones

2021-04-16 Thread David Sterba
On Thu, Apr 15, 2021 at 10:58:35PM +0900, Johannes Thumshirn wrote: > --- a/fs/btrfs/ctree.h > +++ b/fs/btrfs/ctree.h > @@ -954,10 +954,14 @@ struct btrfs_fs_info { > struct work_struct async_data_reclaim_work; > struct work_struct preempt_reclaim_work; > > + /* Used to reclaim da

Re: [PATCH v4 3/3] btrfs: zoned: automatically reclaim zones

2021-04-16 Thread Filipe Manana
On Thu, Apr 15, 2021 at 3:00 PM Johannes Thumshirn wrote: > > When a file gets deleted on a zoned file system, the space freed is not > returned back into the block group's free space, but is migrated to > zone_unusable. > > As this zone_unusable space is behind the current write pointer it is not

Re: [PATCH v4 3/3] btrfs: zoned: automatically reclaim zones

2021-04-15 Thread Johannes Thumshirn
On 15/04/2021 20:37, Josef Bacik wrote: > On 4/15/21 9:58 AM, Johannes Thumshirn wrote: >> When a file gets deleted on a zoned file system, the space freed is not >> returned back into the block group's free space, but is migrated to >> zone_unusable. >> >> As this zone_unusable space is behind the

Re: [PATCH v4 3/3] btrfs: zoned: automatically reclaim zones

2021-04-15 Thread Josef Bacik
On 4/15/21 9:58 AM, Johannes Thumshirn wrote: When a file gets deleted on a zoned file system, the space freed is not returned back into the block group's free space, but is migrated to zone_unusable. As this zone_unusable space is behind the current write pointer it is not possible to use it fo

[PATCH v4 3/3] btrfs: zoned: automatically reclaim zones

2021-04-15 Thread Johannes Thumshirn
When a file gets deleted on a zoned file system, the space freed is not returned back into the block group's free space, but is migrated to zone_unusable. As this zone_unusable space is behind the current write pointer it is not possible to use it for new allocations. In the current implementation