Re: [PATCH] Btrfs: dev-replace: make sure target is identical to source when raid56 rebuild fails

2018-03-06 Thread David Sterba
On Fri, Mar 02, 2018 at 04:10:41PM -0700, Liu Bo wrote: > In the last step of scrub_handle_error_block, we try to combine good > copies on all possible mirrors, this works fine for raid1 and raid10, > but not for raid56 as it's doing parity rebuild. > > If parity rebuild doesn't get back with

[PATCH] Btrfs: dev-replace: make sure target is identical to source when raid56 rebuild fails

2018-03-02 Thread Liu Bo
In the last step of scrub_handle_error_block, we try to combine good copies on all possible mirrors, this works fine for raid1 and raid10, but not for raid56 as it's doing parity rebuild. If parity rebuild doesn't get back with correct data which matches its checksum, in case of replace we'd