Re: [PATCH] Btrfs: free btrfs_device in place

2017-10-11 Thread Liu Bo
On Wed, Oct 11, 2017 at 07:54:04PM +0200, David Sterba wrote: > On Tue, Oct 10, 2017 at 03:51:03PM -0600, Liu Bo wrote: > > It's pointless to defer it to a kthread helper as we're not under any > > special context. > > I agree the doubly deferred freeing is pointless. It's a weird mix of > RCU

Re: [PATCH] Btrfs: free btrfs_device in place

2017-10-11 Thread David Sterba
On Tue, Oct 10, 2017 at 03:51:03PM -0600, Liu Bo wrote: > It's pointless to defer it to a kthread helper as we're not under any > special context. I agree the doubly deferred freeing is pointless. It's a weird mix of RCU and workques and understanding all the interactions turned out to be hard,

Re: [PATCH] Btrfs: free btrfs_device in place

2017-10-11 Thread Anand Jain
On 10/11/2017 05:51 AM, Liu Bo wrote: It's pointless to defer it to a kthread helper as we're not under any special context. Reviewed-by: Anand Jain Thanks, Anand Signed-off-by: Liu Bo --- fs/btrfs/volumes.c | 14 ++ 1 file

[PATCH] Btrfs: free btrfs_device in place

2017-10-10 Thread Liu Bo
It's pointless to defer it to a kthread helper as we're not under any special context. Signed-off-by: Liu Bo --- fs/btrfs/volumes.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index