Re: [PATCH] btrfs: do not allow mounting non-subvolumes via subvol option

2011-08-03 Thread David Sterba
On Fri, Jul 29, 2011 at 07:11:28PM +0200, Goffredo Baroncelli wrote: $ btrfs subvol list -p . ID 258 parent 5 top level 5 path subvol ID 259 parent 5 top level 5 path subvol1 ID 260 parent 5 top level 5 path default-subvol1 ID 262 parent 5 top level 5 path p1/p1-snapshot ID 263 parent 259

Re: [PATCH] btrfs: do not allow mounting non-subvolumes via subvol option

2011-08-03 Thread David Sterba
...@oracle.com; David Sterba Subject: [PATCH] btrfs: do not allow mounting non-subvolumes via subvol option There's a missing test whether the path passed to subvol=path option during mount is a real subvolume, allowing any directory located in default subovlume to be passed and accepted for mount

Re: [PATCH] btrfs: do not allow mounting non-subvolumes via subvol option

2011-08-03 Thread C Anthony Risinger
On Wed, Aug 3, 2011 at 1:47 PM, David Sterba d...@jikos.cz wrote: On Sat, Jul 30, 2011 at 12:16:44AM +0800, Zhong, Xin wrote: I believe I have submit a similar patch months ago: http://marc.info/?l=linux-btrfsm=130208585106572w=2 You did! I was not aware of that. I believe adding a helper

Re: [PATCH] btrfs: do not allow mounting non-subvolumes via subvol option

2011-07-29 Thread Goffredo Baroncelli
Hi David, On 07/29/2011 12:14 PM, David Sterba wrote: There's a missing test whether the path passed to subvol=path option during mount is a real subvolume, allowing any directory located in default subovlume to be passed and accepted for mount. (current btrfs progs prevent this early) $ btrfs