Re: [PATCH] fstests: test btrfs fsync after hole punching with no-holes mode

2018-04-02 Thread Filipe Manana
On Thu, Mar 29, 2018 at 7:55 PM, Jayashree Mohan wrote: > Hi Filipe, > > I tried running the xfstest above on kernel 4.15.0 and I haven't been > able to hit the bug. The xfstest passes clean for me. I compared the > btrfs-debug-tree in my case with the one attached by

Re: [PATCH] fstests: test btrfs fsync after hole punching with no-holes mode

2018-03-29 Thread Jayashree Mohan
Hi Filipe, I tried running the xfstest above on kernel 4.15.0 and I haven't been able to hit the bug. The xfstest passes clean for me. I compared the btrfs-debug-tree in my case with the one attached by Eryu, and I see I do not have any xattr as he does. However, for every run of the xfstest, the

Re: [PATCH] fstests: test btrfs fsync after hole punching with no-holes mode

2018-03-29 Thread Filipe Manana
On Wed, Mar 28, 2018 at 11:33 AM, Eryu Guan wrote: > On Wed, Mar 28, 2018 at 09:48:17AM +0100, Filipe Manana wrote: >> On Wed, Mar 28, 2018 at 3:17 AM, Eryu Guan wrote: >> > On Mon, Mar 26, 2018 at 11:59:21PM +0100, fdman...@kernel.org wrote: >> >> From:

Re: [PATCH] fstests: test btrfs fsync after hole punching with no-holes mode

2018-03-28 Thread Eryu Guan
On Wed, Mar 28, 2018 at 09:48:17AM +0100, Filipe Manana wrote: > On Wed, Mar 28, 2018 at 3:17 AM, Eryu Guan wrote: > > On Mon, Mar 26, 2018 at 11:59:21PM +0100, fdman...@kernel.org wrote: > >> From: Filipe Manana > >> > >> Test that when we have the

Re: [PATCH] fstests: test btrfs fsync after hole punching with no-holes mode

2018-03-28 Thread Filipe Manana
On Wed, Mar 28, 2018 at 3:17 AM, Eryu Guan wrote: > On Mon, Mar 26, 2018 at 11:59:21PM +0100, fdman...@kernel.org wrote: >> From: Filipe Manana >> >> Test that when we have the no-holes mode enabled and a specific metadata >> layout, if we punch a hole and

Re: [PATCH] fstests: test btrfs fsync after hole punching with no-holes mode

2018-03-27 Thread Eryu Guan
On Mon, Mar 26, 2018 at 11:59:21PM +0100, fdman...@kernel.org wrote: > From: Filipe Manana > > Test that when we have the no-holes mode enabled and a specific metadata > layout, if we punch a hole and fsync the file, at replay time the whole > hole was preserved. > > This

[PATCH] fstests: test btrfs fsync after hole punching with no-holes mode

2018-03-27 Thread fdmanana
From: Filipe Manana Test that when we have the no-holes mode enabled and a specific metadata layout, if we punch a hole and fsync the file, at replay time the whole hole was preserved. This issue is fixed by the following btrfs patch for the linux kernel: "Btrfs: fix fsync