Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2012-01-19 Thread Jérôme Poulin
Is there any reason why this can't be applied in for-linus? Does it need more testing? Still no corruption here after copying the whole root FS in subvolume after btrfs-convert, this FS is used everyday with big image files, clients backups of Windows directories (small files) and 3 snapshots a day

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2012-01-09 Thread Jérôme Poulin
On Mon, Jan 9, 2012 at 1:58 AM, Marios Titas wrote: >> The simple case of 'cp --reflink' works fine [...] > > It doesn't work here: > > cp: failed to clone `/tmp/test': Invalid cross-device link > > That's with 3.1 + for-linus. This is the problem, it doesn't work because you have to apply the pa

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2012-01-08 Thread Marios Titas
On Fri, Jan 6, 2012 at 12:57, David Sterba wrote: > On Fri, Jan 06, 2012 at 02:04:12PM +0200, Konstantinos Skarlatos wrote: >> Me too wants cp --reflink across subvolumes. Please make this feature >> available to us, as its a "poor man's dedupe" and would give big space >> savings for many use cas

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2012-01-06 Thread David Sterba
On Fri, Jan 06, 2012 at 02:04:12PM +0200, Konstantinos Skarlatos wrote: > Me too wants cp --reflink across subvolumes. Please make this feature > available to us, as its a "poor man's dedupe" and would give big space > savings for many use cases. The simple case of 'cp --reflink' works fine, the

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2012-01-06 Thread Konstantinos Skarlatos
On 22/12/2011 2:24 μμ, Chris Samuel wrote: Christoph, On Sat, 2 Apr 2011 12:40:11 AM Chris Mason wrote: Excerpts from Christoph Hellwig's message of 2011-04-01 09:34:05 -0400: I don't think it's a good idea to introduce any user visible operations over subvolume boundaries. Currently we d

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-12-22 Thread Chris Samuel
Christoph, On Sat, 2 Apr 2011 12:40:11 AM Chris Mason wrote: > Excerpts from Christoph Hellwig's message of 2011-04-01 09:34:05 -0400: > > > I don't think it's a good idea to introduce any user visible > > operations over subvolume boundaries. Currently we don't have > > any operations over mou

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-04-02 Thread Jérôme Poulin
I am very happy to see this patch. It was one of the first thing I tried after making a subvolume, cp --reflink, and it failed. I'll have to try this out. Jérôme Poulin On 2011-04-02, at 12:56, Larry D'Anna wrote: > * Ken Drummond (bt...@kendrummond.com) [110402 11:51]: >> I don't really unders

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-04-02 Thread Larry D'Anna
* Ken Drummond (bt...@kendrummond.com) [110402 11:51]: > I don't really understand the details here, but doesn't the creation of > a snapshot already lead to data extents being shared between > sub-volumes? From a simple user perspective this sounds like a very > useful capability. I was surprise

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-04-02 Thread Ken Drummond
On Fri, 2011-04-01 at 09:34 -0400, Christoph Hellwig wrote: > On Thu, Mar 31, 2011 at 08:02:22AM -0400, Chris Mason wrote: > > Excerpts from Christoph Hellwig's message of 2011-03-31 02:36:36 -0400: > > > On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: > > > > This is a simple patch t

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-04-01 Thread Fajar A. Nugraha
On Fri, Apr 1, 2011 at 8:40 PM, Chris Mason wrote: > Excerpts from Christoph Hellwig's message of 2011-04-01 09:34:05 -0400: >> I don't think it's a good idea to introduce any user visible operations >> over subvolume boundaries.  Currently we don't have any operations over >> mount boundaries, wh

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-04-01 Thread Chris Mason
Excerpts from Christoph Hellwig's message of 2011-04-01 09:34:05 -0400: > On Thu, Mar 31, 2011 at 08:02:22AM -0400, Chris Mason wrote: > > Excerpts from Christoph Hellwig's message of 2011-03-31 02:36:36 -0400: > > > On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: > > > > This is a si

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-04-01 Thread Christoph Hellwig
On Thu, Mar 31, 2011 at 08:02:22AM -0400, Chris Mason wrote: > Excerpts from Christoph Hellwig's message of 2011-03-31 02:36:36 -0400: > > On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: > > > This is a simple patch to allow reflinks to be made crossing subvolume > > > boundaries. > >

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-03-31 Thread Chris Mason
Excerpts from Christoph Hellwig's message of 2011-03-31 02:36:36 -0400: > On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: > > This is a simple patch to allow reflinks to be made crossing subvolume > > boundaries. > > NAK. subvolumes will have to become vfsmounts sooner or later, and

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-03-31 Thread Tomasz Chmielewski
Arne Jansen wrote: On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: This is a simple patch to allow reflinks to be made crossing subvolume boundaries. NAK. subvolumes will have to become vfsmounts sooner or later, and we really must not support any operations spanning mountpoint

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-03-30 Thread Arne Jansen
On 31.03.2011 08:36, Christoph Hellwig wrote: > On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: >> This is a simple patch to allow reflinks to be made crossing subvolume >> boundaries. > > NAK. subvolumes will have to become vfsmounts sooner or later, and we > really must not suppor

Re: [PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-03-30 Thread Christoph Hellwig
On Thu, Mar 31, 2011 at 12:00:11AM -0400, Larry D'Anna wrote: > This is a simple patch to allow reflinks to be made crossing subvolume > boundaries. NAK. subvolumes will have to become vfsmounts sooner or later, and we really must not support any operations spanning mountpoints. -- To unsubscrib

[PATCH 0/2] btrfs: allow cross-subvolume BTRFS_IOC_CLONE

2011-03-30 Thread Larry D'Anna
This is a simple patch to allow reflinks to be made crossing subvolume boundaries. The only complication I found in implementing this is that btrfs_ioctl_clone reuses a btrfs_path. This is a slight problem because once we allow the source and destination inodes to come from different btrfs_roots,