Re: [PATCH 01/22] btrfs: add btrfs_delete_ref_head helper

2018-07-20 Thread David Sterba
fstests run in the sequence from btrfs/001, in qemu, 2G memory, warning and crash at btrfs/124 btrfs/124 [22:58:39] [10100.765898] run fstests btrfs/124 at 2018-07-19 22:58:39 ... [10110.113787] BTRFS: device fsid 8b6b700e-3346-4260-bb2e-c561ba4b9960 devid 1 transid 7 /dev/vdb

Re: [PATCH 01/22] btrfs: add btrfs_delete_ref_head helper

2018-07-20 Thread David Sterba
On Thu, Jul 19, 2018 at 10:49:45AM -0400, Josef Bacik wrote: > --- a/fs/btrfs/extent-tree.c > +++ b/fs/btrfs/extent-tree.c > @@ -2577,12 +2577,9 @@ static int cleanup_ref_head(struct btrfs_trans_handle > *trans, > spin_unlock(_refs->lock); > return 1; > } > -

Re: [PATCH 01/22] btrfs: add btrfs_delete_ref_head helper

2018-07-20 Thread Josef Bacik
On Fri, Jul 20, 2018 at 04:11:29PM +0300, Nikolay Borisov wrote: > > > On 19.07.2018 17:49, Josef Bacik wrote: > > From: Josef Bacik > > > > We do this dance in cleanup_ref_head and check_ref_cleanup, unify it > > into a helper and cleanup the calling functions. > > > > Signed-off-by: Josef

Re: [PATCH 01/22] btrfs: add btrfs_delete_ref_head helper

2018-07-20 Thread Nikolay Borisov
On 19.07.2018 17:49, Josef Bacik wrote: > From: Josef Bacik > > We do this dance in cleanup_ref_head and check_ref_cleanup, unify it > into a helper and cleanup the calling functions. > > Signed-off-by: Josef Bacik > --- > fs/btrfs/delayed-ref.c | 14 ++ >

Re: [PATCH 01/22] btrfs: add btrfs_delete_ref_head helper

2018-07-19 Thread David Sterba
On Thu, Jul 19, 2018 at 12:12:52PM -0400, Josef Bacik wrote: > On Thu, Jul 19, 2018 at 06:08:21PM +0200, David Sterba wrote: > > Please send cover letter for patchsets with more than 1 patch. > > Especially for a patchset with 20+ patches that does not seem to be > > doing anything trivial. > > >

Re: [PATCH 01/22] btrfs: add btrfs_delete_ref_head helper

2018-07-19 Thread Josef Bacik
On Thu, Jul 19, 2018 at 06:08:21PM +0200, David Sterba wrote: > Please send cover letter for patchsets with more than 1 patch. > Especially for a patchset with 20+ patches that does not seem to be > doing anything trivial. > > What problem does this fix, what's the overall idea behind the

Re: [PATCH 01/22] btrfs: add btrfs_delete_ref_head helper

2018-07-19 Thread David Sterba
Please send cover letter for patchsets with more than 1 patch. Especially for a patchset with 20+ patches that does not seem to be doing anything trivial. What problem does this fix, what's the overall idea behind the approach, what workload can trigger that etc. Thanks. -- To unsubscribe from

[PATCH 01/22] btrfs: add btrfs_delete_ref_head helper

2018-07-19 Thread Josef Bacik
From: Josef Bacik We do this dance in cleanup_ref_head and check_ref_cleanup, unify it into a helper and cleanup the calling functions. Signed-off-by: Josef Bacik --- fs/btrfs/delayed-ref.c | 14 ++ fs/btrfs/delayed-ref.h | 3 ++- fs/btrfs/extent-tree.c | 24