[PATCH 08/16] btrfs-progs: fix resource leak in scrub_start()

2013-11-06 Thread Eric Sandeen
In the nothing to resume case we return directly and leak several bits of memory; goto out to free them properly. Resolves-Coverity-CID: 1125934 Resolves-Coverity-CID: 1125935 Resolves-Coverity-CID: 1125936 Signed-off-by: Eric Sandeen sand...@redhat.com --- cmds-scrub.c |3 ++- 1 files

Re: [PATCH 08/16] btrfs-progs: fix resource leak in scrub_start()

2013-11-06 Thread Wang Shilong
Hi Eric, On 11/07/2013 07:15 AM, Eric Sandeen wrote: In the nothing to resume case we return directly and leak several bits of memory; goto out to free them properly. Resolves-Coverity-CID: 1125934 Resolves-Coverity-CID: 1125935 Resolves-Coverity-CID: 1125936 Signed-off-by: Eric Sandeen

Re: [PATCH 08/16] btrfs-progs: fix resource leak in scrub_start()

2013-11-06 Thread Wang Shilong
On 11/07/2013 09:48 AM, Wang Shilong wrote: Hi Eric, On 11/07/2013 07:15 AM, Eric Sandeen wrote: In the nothing to resume case we return directly and leak several bits of memory; goto out to free them properly. Resolves-Coverity-CID: 1125934 Resolves-Coverity-CID: 1125935

Re: [PATCH 08/16] btrfs-progs: fix resource leak in scrub_start()

2013-11-06 Thread Eric Sandeen
On 11/6/13, 7:50 PM, Wang Shilong wrote: On 11/07/2013 09:48 AM, Wang Shilong wrote: Hi Eric, On 11/07/2013 07:15 AM, Eric Sandeen wrote: In the nothing to resume case we return directly and leak several bits of memory; goto out to free them properly. Resolves-Coverity-CID: 1125934

Re: [PATCH 08/16] btrfs-progs: fix resource leak in scrub_start()

2013-11-06 Thread Wang Shilong
On 11/07/2013 11:46 AM, Eric Sandeen wrote: On 11/6/13, 7:50 PM, Wang Shilong wrote: On 11/07/2013 09:48 AM, Wang Shilong wrote: Hi Eric, On 11/07/2013 07:15 AM, Eric Sandeen wrote: In the nothing to resume case we return directly and leak several bits of memory; goto out to free them