Re: [PATCH 1/3] Add the snappy-c compressor to lib v2

2012-02-14 Thread Mitch Harder
On Tue, Feb 14, 2012 at 1:52 PM, Andi Kleen wrote: > >> (BTW:  If you're ever reworking this patch set, I'd like to make an ad >> hoc request for slightly different names for fs/btrfs/snappy.c and >> lib/snappy.c) > > > Why? > It's not a big deal, I just found it confusing at first to see "snappy

Re: [PATCH 1/3] Add the snappy-c compressor to lib v2

2012-02-14 Thread Andi Kleen
(BTW: If you're ever reworking this patch set, I'd like to make an ad hoc request for slightly different names for fs/btrfs/snappy.c and lib/snappy.c) Why? When building a x86 kernel, I get the following errors: CC [M] lib/snappy.o lib/snappy.c: In function 'snappy_init_env': lib/snappy

Re: [PATCH 1/3] Add the snappy-c compressor to lib v2

2012-02-13 Thread Mitch Harder
On Thu, Jan 12, 2012 at 6:28 PM, Andi Kleen wrote: > From: Andi Kleen > > This is a C port of the google snappy compressor. It has roughly > comparable compression to LZO, but is significantly faster on many file > types. For example it beats all other compressors on already > compressed data. >

[PATCH 1/3] Add the snappy-c compressor to lib v2

2012-01-12 Thread Andi Kleen
From: Andi Kleen This is a C port of the google snappy compressor. It has roughly comparable compression to LZO, but is significantly faster on many file types. For example it beats all other compressors on already compressed data. I ported the original C++ code over to C and did some changes to