Re: [PATCH 1/5] Btrfs-progs: fix closing of devices

2013-06-11 Thread Filipe Manana
On 11/06/2013, at 16:00, David Sterba dste...@suse.cz wrote: On Mon, Jun 10, 2013 at 09:07:55PM +0100, Filipe David Borba Manana wrote: --- a/disk-io.c +++ b/disk-io.c @@ -1267,12 +1267,12 @@ static int close_all_devices(struct btrfs_fs_info *fs_info) while (!list_empty(list)) {

[PATCH 1/5] Btrfs-progs: fix closing of devices

2013-06-10 Thread Filipe David Borba Manana
If a device could not be opened in volumes.c:read_one_dev(), a btrfs_device instance was allocated and added to the list of devices of the fs - however this device instance had its fd, name and label fields not initialized. This is problematic in disk-io.c:close_all_devices() as it tries to close

[PATCH 1/5] Btrfs-progs: fix closing of devices

2013-06-10 Thread Filipe David Borba Manana
If a device could not be opened in volumes.c:read_one_dev(), a btrfs_device instance was allocated and added to the list of devices of the fs - however this device instance had its fd, name and label fields not initialized. This is problematic in disk-io.c:close_all_devices() as it tries to close