Re: [PATCH 2/4] btrfs-progs: fsck: Introduce --fix-dev-size option

2017-10-26 Thread Qu Wenruo
On 2017年10月27日 02:58, David Sterba wrote: > On Wed, Oct 11, 2017 at 08:43:24AM +0800, Qu Wenruo wrote: >> On 2017年10月10日 21:16, David Sterba wrote: >>> On Tue, Oct 10, 2017 at 07:51:11AM +, Qu Wenruo wrote: Introduce --fix-dev-size option to fix device related problems. >>> >>> Please

Re: [PATCH 2/4] btrfs-progs: fsck: Introduce --fix-dev-size option

2017-10-26 Thread David Sterba
On Wed, Oct 11, 2017 at 08:43:24AM +0800, Qu Wenruo wrote: > On 2017年10月10日 21:16, David Sterba wrote: > > On Tue, Oct 10, 2017 at 07:51:11AM +, Qu Wenruo wrote: > >> Introduce --fix-dev-size option to fix device related problems. > > > > Please don't add it to 'check', this is not the right

Re: [PATCH 2/4] btrfs-progs: fsck: Introduce --fix-dev-size option

2017-10-10 Thread Qu Wenruo
On 2017年10月10日 21:16, David Sterba wrote: On Tue, Oct 10, 2017 at 07:51:11AM +, Qu Wenruo wrote: Introduce --fix-dev-size option to fix device related problems. Please don't add it to 'check', this is not the right place for the targeted fixes. -> 'btrfs rescue' I'm OK moving the

Re: [PATCH 2/4] btrfs-progs: fsck: Introduce --fix-dev-size option

2017-10-10 Thread David Sterba
On Tue, Oct 10, 2017 at 07:51:11AM +, Qu Wenruo wrote: > Introduce --fix-dev-size option to fix device related problems. Please don't add it to 'check', this is not the right place for the targeted fixes. -> 'btrfs rescue' > This repairing is also included in --repair, but considering the

[PATCH 2/4] btrfs-progs: fsck: Introduce --fix-dev-size option

2017-10-10 Thread Qu Wenruo
Introduce --fix-dev-size option to fix device related problems. This repairing is also included in --repair, but considering the safety and potential affected users, it's better to provide a option to fix and only fix device size related problem to avoid full --repair. Reported-by: Asif