Re: [PATCH 3/3] Btrfs: remove reduplicate check when disabling quota

[Arne Jansen]

On 07.08.2013 07:12, Wang Shilong wrote:
> We have checked 'quota_root' with qgroup_ioctl_lock held before,So
> here the check is reduplicate, remove it.
> 
> Signed-off-by: Wang Shilong 
> Reviewed-by: Miao Xie 
> ---
>  fs/btrfs/qgroup.c | 5 -
>  1 file changed, 5 deletions(-)
> 
> diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
> index b809616..df2841d 100644
> --- a/fs/btrfs/qgroup.c
> +++ b/fs/btrfs/qgroup.c
> @@ -943,11 +943,6 @@ int btrfs_quota_disable(struct btrfs_trans_handle *trans,
>  
>   btrfs_free_qgroup_config(fs_info);
>  
> - if (!quota_root) {
> - ret = -EINVAL;
> - goto out;
> - }
> -
>   ret = btrfs_clean_quota_tree(trans, quota_root);
>   if (ret)
>   goto out;

Reviewed-by: Arne Jansen 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] Btrfs: remove reduplicate check when disabling quota

[Wang Shilong]

We have checked 'quota_root' with qgroup_ioctl_lock held before,So
here the check is reduplicate, remove it.

Signed-off-by: Wang Shilong 
Reviewed-by: Miao Xie 
---
 fs/btrfs/qgroup.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/fs/btrfs/qgroup.c b/fs/btrfs/qgroup.c
index b809616..df2841d 100644
--- a/fs/btrfs/qgroup.c
+++ b/fs/btrfs/qgroup.c
@@ -943,11 +943,6 @@ int btrfs_quota_disable(struct btrfs_trans_handle *trans,
 
btrfs_free_qgroup_config(fs_info);
 
-   if (!quota_root) {
-   ret = -EINVAL;
-   goto out;
-   }
-
ret = btrfs_clean_quota_tree(trans, quota_root);
if (ret)
goto out;
-- 
1.8.0.1

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html